diff options
| author | DioEgizio <83089242+DioEgizio@users.noreply.github.com> | 2023-06-05 20:34:56 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-05 20:34:56 +0200 |
| commit | e1b37f3cd3d9383dcc70d0d7fac29f8158fbc379 (patch) | |
| tree | d4dbfb39a79055cfb32bfd266bb0cde50288ab9e | |
| parent | 0c24827a52994b2f6b441aaf7d7f68275b52cabc (diff) | |
| parent | 5824047ffa4e31f018ddc068c2677ce9b8e5b43d (diff) | |
| download | PrismLauncher-e1b37f3cd3d9383dcc70d0d7fac29f8158fbc379.tar.gz PrismLauncher-e1b37f3cd3d9383dcc70d0d7fac29f8158fbc379.tar.bz2 PrismLauncher-e1b37f3cd3d9383dcc70d0d7fac29f8158fbc379.zip | |
Merge pull request #1108 from Ryex/fix/memory-leak-translation
| -rw-r--r-- | launcher/translations/TranslationsModel.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/launcher/translations/TranslationsModel.cpp b/launcher/translations/TranslationsModel.cpp index 46db4804..23e55c51 100644 --- a/launcher/translations/TranslationsModel.cpp +++ b/launcher/translations/TranslationsModel.cpp @@ -190,7 +190,7 @@ struct TranslationsModel::Private std::unique_ptr<QTranslator> m_qt_translator; std::unique_ptr<QTranslator> m_app_translator; - Net::Download::Ptr m_index_task; + Net::Download* m_index_task; QString m_downloadingTranslation; NetJob::Ptr m_dl_job; NetJob::Ptr m_index_job; @@ -673,8 +673,9 @@ void TranslationsModel::downloadIndex() d->m_index_job.reset(new NetJob("Translations Index", APPLICATION->network())); MetaEntryPtr entry = APPLICATION->metacache()->resolveEntry("translations", "index_v2.json"); entry->setStale(true); - d->m_index_task = Net::Download::makeCached(QUrl(BuildConfig.TRANSLATIONS_BASE_URL + "index_v2.json"), entry); - d->m_index_job->addNetAction(d->m_index_task); + auto task = Net::Download::makeCached(QUrl(BuildConfig.TRANSLATIONS_BASE_URL + "index_v2.json"), entry); + d->m_index_task = task.get(); + d->m_index_job->addNetAction(task); connect(d->m_index_job.get(), &NetJob::failed, this, &TranslationsModel::indexFailed); connect(d->m_index_job.get(), &NetJob::succeeded, this, &TranslationsModel::indexReceived); d->m_index_job->start(); |