aboutsummaryrefslogtreecommitdiff
path: root/launcher/Application.cpp
diff options
context:
space:
mode:
authorSefa Eyeoglu <contact@scrumplex.net>2022-11-10 19:04:42 +0100
committerSefa Eyeoglu <contact@scrumplex.net>2022-11-12 20:28:30 +0100
commitfe94c3609ef875166b71b9f6c540c45eff97a5ab (patch)
tree4d84b18c8639233c47e6fc37bfc673489abdbf03 /launcher/Application.cpp
parent173aed7fd8e73b9e6a6055981ce284ea9cf5d33a (diff)
downloadPrismLauncher-fe94c3609ef875166b71b9f6c540c45eff97a5ab.tar.gz
PrismLauncher-fe94c3609ef875166b71b9f6c540c45eff97a5ab.tar.bz2
PrismLauncher-fe94c3609ef875166b71b9f6c540c45eff97a5ab.zip
fix: implement code review suggestions
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Diffstat (limited to 'launcher/Application.cpp')
-rw-r--r--launcher/Application.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/launcher/Application.cpp b/launcher/Application.cpp
index 8955e297..537e3903 100644
--- a/launcher/Application.cpp
+++ b/launcher/Application.cpp
@@ -1611,10 +1611,9 @@ bool Application::handleDataMigration(const QString& currentData,
const QString& name,
const QString& configFile) const
{
- QString nomigratePath = FS::PathCombine(oldData, BuildConfig.LAUNCHER_NAME + "_nomigrate.txt");
+ QString nomigratePath = FS::PathCombine(currentData, name + "_nomigrate.txt");
QStringList configPaths = { FS::PathCombine(oldData, configFile), FS::PathCombine(oldData, BuildConfig.LAUNCHER_CONFIGFILE) };
- QDir dir; // helper for QDir::exists
QLocale locale;
// Is there a valid config at the old location?
@@ -1677,7 +1676,7 @@ bool Application::handleDataMigration(const QString& currentData,
matcher->add(std::make_shared<SimplePrefixMatcher>("mods/"));
matcher->add(std::make_shared<SimplePrefixMatcher>("themes/"));
- ProgressDialog diag = ProgressDialog();
+ ProgressDialog diag;
DataMigrationTask task(nullptr, oldData, currentData, matcher);
if (diag.execWithTask(&task)) {
qDebug() << "<> Migration succeeded";