NOISSUE prevent -version being passed to the JRE

We want specific JREs, always, not something that is magically resolved.
This counteracts some really bad advice recently being spread on reddit.

1 files changed, 4 insertions, 1 deletions

diff --git a/launcher/LaunchController.cpp b/launcher/LaunchController.cpp
index 792d8381..cc1228f5 100644
--- a/launcher/LaunchController.cpp
+++ b/launcher/LaunchController.cpp
@@ -71,7 +71,10 @@ void LaunchController::executeTask()
         return;
     }
 
-    JavaCommon::checkJVMArgs(m_instance->settings()->get("JvmArgs").toString(), m_parentWidget);
+    if(!JavaCommon::checkJVMArgs(m_instance->settings()->get("JvmArgs").toString(), m_parentWidget)) {
+        emitFailed(tr("Invalid Java arguments specified. Please fix this first."));
+        return;
+    }
 
     login();
 }