diff options
| author | Sefa Eyeoglu <contact@scrumplex.net> | 2022-03-29 11:24:12 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-29 11:24:12 +0200 |
| commit | 5f2e7683764461dd70e5a3593a6bab1cc3e6146d (patch) | |
| tree | 2d16bd4de9b99e22270d7f1614b525c44afe1833 /launcher/modplatform/helpers | |
| parent | 575c92ec479e555fe7cb5ead98794b78c260f820 (diff) | |
| parent | d00c320c0041421e67d5d8ec6deb4427d0f8020c (diff) | |
| download | PrismLauncher-5f2e7683764461dd70e5a3593a6bab1cc3e6146d.tar.gz PrismLauncher-5f2e7683764461dd70e5a3593a6bab1cc3e6146d.tar.bz2 PrismLauncher-5f2e7683764461dd70e5a3593a6bab1cc3e6146d.zip | |
Merge pull request #356 from flowln/version_optimize
Improve mod versions request to Modrinth
Diffstat (limited to 'launcher/modplatform/helpers')
| -rw-r--r-- | launcher/modplatform/helpers/NetworkModAPI.cpp | 10 | ||||
| -rw-r--r-- | launcher/modplatform/helpers/NetworkModAPI.h | 4 |
2 files changed, 7 insertions, 7 deletions
diff --git a/launcher/modplatform/helpers/NetworkModAPI.cpp b/launcher/modplatform/helpers/NetworkModAPI.cpp index 25c7b9fd..6829b837 100644 --- a/launcher/modplatform/helpers/NetworkModAPI.cpp +++ b/launcher/modplatform/helpers/NetworkModAPI.cpp @@ -31,14 +31,14 @@ void NetworkModAPI::searchMods(CallerType* caller, SearchArgs&& args) const netJob->start(); } -void NetworkModAPI::getVersions(CallerType* caller, const QString& addonId) const +void NetworkModAPI::getVersions(CallerType* caller, VersionSearchArgs&& args) const { - auto netJob = new NetJob(QString("%1::ModVersions(%2)").arg(caller->debugName()).arg(addonId), APPLICATION->network()); + auto netJob = new NetJob(QString("%1::ModVersions(%2)").arg(caller->debugName()).arg(args.addonId), APPLICATION->network()); auto response = new QByteArray(); - netJob->addNetAction(Net::Download::makeByteArray(getVersionsURL(addonId), response)); + netJob->addNetAction(Net::Download::makeByteArray(getVersionsURL(args), response)); - QObject::connect(netJob, &NetJob::succeeded, caller, [response, caller, addonId] { + QObject::connect(netJob, &NetJob::succeeded, caller, [response, caller, args] { QJsonParseError parse_error{}; QJsonDocument doc = QJsonDocument::fromJson(*response, &parse_error); if (parse_error.error != QJsonParseError::NoError) { @@ -48,7 +48,7 @@ void NetworkModAPI::getVersions(CallerType* caller, const QString& addonId) cons return; } - caller->versionRequestSucceeded(doc, addonId); + caller->versionRequestSucceeded(doc, args.addonId); }); QObject::connect(netJob, &NetJob::finished, caller, [response, netJob] { diff --git a/launcher/modplatform/helpers/NetworkModAPI.h b/launcher/modplatform/helpers/NetworkModAPI.h index 4d3f7005..000620b2 100644 --- a/launcher/modplatform/helpers/NetworkModAPI.h +++ b/launcher/modplatform/helpers/NetworkModAPI.h @@ -5,9 +5,9 @@ class NetworkModAPI : public ModAPI { public: void searchMods(CallerType* caller, SearchArgs&& args) const override; - void getVersions(CallerType* caller, const QString& addonId) const override; + void getVersions(CallerType* caller, VersionSearchArgs&& args) const override; protected: virtual auto getModSearchURL(SearchArgs& args) const -> QString = 0; - virtual auto getVersionsURL(const QString& addonId) const -> QString = 0; + virtual auto getVersionsURL(VersionSearchArgs& args) const -> QString = 0; }; |