Fix: signal/slot macro -> func pointer & network fixes

- convert qt connect calls to use function pointers instead of the signal/slot macros wherever practical (UI classes were mostly left alone, target was tasks and processes)
- give signals an explicit receivers to use the static method over the instance method wherever practical
- ensure networks tasks are using the `errorOccured` signal added in Qt5.15 over the deprecated `error` signal
- ensure all networks tasks have an sslErrors signal connected
- add seemingly missing `MinecraftAccount::authSucceeded` connection for `MSAInteractive` login flow

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>

1 files changed, 4 insertions, 5 deletions

diff --git a/launcher/settings/SettingsObject.cpp b/launcher/settings/SettingsObject.cpp
index 8a0bc045..634acd34 100644
--- a/launcher/settings/SettingsObject.cpp
+++ b/launcher/settings/SettingsObject.cpp
@@ -132,11 +132,10 @@ bool SettingsObject::reload()
 
 void SettingsObject::connectSignals(const Setting &setting)
 {
-    connect(&setting, SIGNAL(SettingChanged(const Setting &, QVariant)),
-            SLOT(changeSetting(const Setting &, QVariant)));
-    connect(&setting, SIGNAL(SettingChanged(const Setting &, QVariant)),
+    connect(&setting, &Setting::SettingChanged, this, &SettingsObject::changeSetting);
+    connect(&setting, SIGNAL(SettingChanged(const Setting &, QVariant)), this,
             SIGNAL(SettingChanged(const Setting &, QVariant)));
 
-    connect(&setting, SIGNAL(settingReset(Setting)), SLOT(resetSetting(const Setting &)));
-    connect(&setting, SIGNAL(settingReset(Setting)), SIGNAL(settingReset(const Setting &)));
+    connect(&setting, &Setting::settingReset, this, &SettingsObject::resetSetting);
+    connect(&setting, SIGNAL(settingReset(Setting)), this, SIGNAL(settingReset(const Setting &)));
 }