diff options
| author | Rachel Powers <508861+Ryex@users.noreply.github.com> | 2023-05-05 14:07:10 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-05 14:07:10 -0700 |
| commit | b266068644d2caab4f103b0adf7a491b95f52369 (patch) | |
| tree | 8de677072a75350959e3db64d86105a951f231f4 /launcher/tasks | |
| parent | 733619ca741336ba9999af43f4eddd9371462325 (diff) | |
| download | PrismLauncher-b266068644d2caab4f103b0adf7a491b95f52369.tar.gz PrismLauncher-b266068644d2caab4f103b0adf7a491b95f52369.tar.bz2 PrismLauncher-b266068644d2caab4f103b0adf7a491b95f52369.zip | |
Apply suggestions from code review
Co-authored-by: flow <flowlnlnln@gmail.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Diffstat (limited to 'launcher/tasks')
| -rw-r--r-- | launcher/tasks/ConcurrentTask.cpp | 6 | ||||
| -rw-r--r-- | launcher/tasks/Task.h | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/launcher/tasks/ConcurrentTask.cpp b/launcher/tasks/ConcurrentTask.cpp index dbb4d94d..fae2f3dc 100644 --- a/launcher/tasks/ConcurrentTask.cpp +++ b/launcher/tasks/ConcurrentTask.cpp @@ -65,7 +65,7 @@ void ConcurrentTask::addTask(Task::Ptr task) void ConcurrentTask::executeTask() { - // Start One task, startNext hadels starting the up to the m_total_max_size + // Start one task, startNext handles starting the up to the m_total_max_size // while tracking the number currently being done QMetaObject::invokeMethod(this, &ConcurrentTask::startNext, Qt::QueuedConnection); } @@ -293,9 +293,9 @@ void ConcurrentTask::updateState() .arg(QString::number(m_doing.count()), QString::number(m_done.count()), QString::number(totalSize()))); } else { setProgress(m_stepProgress, m_stepTotalProgress); - QString status = tr("Please wait ..."); + QString status = tr("Please wait..."); if (m_queue.size() > 0) { - status = tr("Waiting for 1 task to start ..."); + status = tr("Waiting for a task to start..."); } else if (m_doing.size() > 0) { status = tr("Executing 1 task:"); } else if (m_done.size() > 0) { diff --git a/launcher/tasks/Task.h b/launcher/tasks/Task.h index 04a09187..799ed945 100644 --- a/launcher/tasks/Task.h +++ b/launcher/tasks/Task.h @@ -130,7 +130,7 @@ class Task : public QObject, public QRunnable { void failed(QString reason); void status(QString status); void details(QString details); - void stepProgress(TaskStepProgress const& task_progress); // + void stepProgress(TaskStepProgress const& task_progress); /** Emitted when the canAbort() status has changed. */ |