Fix: signal/slot macro -> func pointer & network fixes

- convert qt connect calls to use function pointers instead of the signal/slot macros wherever practical (UI classes were mostly left alone, target was tasks and processes)
- give signals an explicit receivers to use the static method over the instance method wherever practical
- ensure networks tasks are using the `errorOccured` signal added in Qt5.15 over the deprecated `error` signal
- ensure all networks tasks have an sslErrors signal connected
- add seemingly missing `MinecraftAccount::authSucceeded` connection for `MSAInteractive` login flow

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/launcher/tools/JVisualVM.cpp b/launcher/tools/JVisualVM.cpp
index b1acc3c0..28ffb9cd 100644
--- a/launcher/tools/JVisualVM.cpp
+++ b/launcher/tools/JVisualVM.cpp
@@ -57,8 +57,8 @@ void JVisualVM::beginProfilingImpl(shared_qobject_ptr<LaunchTask> process)
     profiler->setArguments(profilerArgs);
     profiler->setProgram(programPath);
 
-    connect(profiler, SIGNAL(started()), SLOT(profilerStarted()));
-    connect(profiler, SIGNAL(finished(int, QProcess::ExitStatus)), SLOT(profilerFinished(int,QProcess::ExitStatus)));
+    connect(profiler, &QProcess::started, this, &JVisualVM::profilerStarted);
+    connect(profiler, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished), this,  &JVisualVM::profilerFinished);
 
     profiler->start();
     m_profilerProcess = profiler;