diff options
| author | Joshua Goins <josh@redstrate.com> | 2022-01-27 19:06:07 -0500 |
|---|---|---|
| committer | Joshua Goins <josh@redstrate.com> | 2022-01-27 19:06:07 -0500 |
| commit | c1aaf89baa6166707d7d489fe8ec1bcad1155df1 (patch) | |
| tree | fcafb77fdadd378abb9b47cefc847f1d545a2bf7 /launcher/ui/dialogs/AboutDialog.cpp | |
| parent | 33aac2985a79fb7d7eec82c9fb7eac3973779cce (diff) | |
| download | PrismLauncher-c1aaf89baa6166707d7d489fe8ec1bcad1155df1.tar.gz PrismLauncher-c1aaf89baa6166707d7d489fe8ec1bcad1155df1.tar.bz2 PrismLauncher-c1aaf89baa6166707d7d489fe8ec1bcad1155df1.zip | |
Improve the About page
Improves #106. This more clearly marks the original MultiMC contributors,
and now correctly hides the "Build Platform" if this is set as empty. The
version label is now moved under the "PolyMC" title so it looks just a
little bit better (and matches other applications). The copyright on the
"About" page now correctly attributes the MultiMC contributors just like on
the "License" page.
Diffstat (limited to 'launcher/ui/dialogs/AboutDialog.cpp')
| -rw-r--r-- | launcher/ui/dialogs/AboutDialog.cpp | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/launcher/ui/dialogs/AboutDialog.cpp b/launcher/ui/dialogs/AboutDialog.cpp index 46d2f429..bba3f78b 100644 --- a/launcher/ui/dialogs/AboutDialog.cpp +++ b/launcher/ui/dialogs/AboutDialog.cpp @@ -33,7 +33,7 @@ QString getCreditsHtml() stream.setCodec(QTextCodec::codecForName("UTF-8")); stream << "<center>\n"; // TODO: possibly retrieve from git history at build time? - stream << "<h3>" << QObject::tr("Developers", "About Credits") << "</h3>\n"; + stream << "<h3>" << QObject::tr("MultiMC Developers", "About Credits") << "</h3>\n"; stream << "<p>Andrew Okin <<a href='mailto:forkk@forkk.net'>forkk@forkk.net</a>></p>\n"; stream << "<p>Petr Mrázek <<a href='mailto:peterix@gmail.com'>peterix@gmail.com</a>></p>\n"; stream << "<p>Sky Welch <<a href='mailto:multimc@bunnies.io'>multimc@bunnies.io</a>></p>\n"; @@ -83,8 +83,12 @@ AboutDialog::AboutDialog(QWidget *parent) : QDialog(parent), ui(new Ui::AboutDia ui->icon->setPixmap(APPLICATION->getThemedIcon("logo").pixmap(64)); ui->title->setText(launcherName); - ui->versionLabel->setText(tr("Version") +": " + BuildConfig.printableVersionString()); - ui->platformLabel->setText(tr("Platform") +": " + BuildConfig.BUILD_PLATFORM); + ui->versionLabel->setText(BuildConfig.printableVersionString()); + + if (!BuildConfig.BUILD_PLATFORM.isEmpty()) + ui->platformLabel->setText(tr("Platform") +": " + BuildConfig.BUILD_PLATFORM); + else + ui->platformLabel->setVisible(false); if (BuildConfig.VERSION_BUILD >= 0) ui->buildNumLabel->setText(tr("Build Number") +": " + QString::number(BuildConfig.VERSION_BUILD)); |