aboutsummaryrefslogtreecommitdiff
path: root/launcher/ui
diff options
context:
space:
mode:
authordada513 <dada513@protonmail.com>2022-04-20 09:08:48 +0200
committerGitHub <noreply@github.com>2022-04-20 09:08:48 +0200
commit4e97f2a6fee1557c51e2220fe7f1849239da3a2c (patch)
tree9eb78f881b281f6fd0fba1a7031719f287b957a0 /launcher/ui
parent46430469891816c691e448dada5c851042cea4d2 (diff)
parent0682fe544a52a9d018bb05ddcacf4c697a826094 (diff)
downloadPrismLauncher-4e97f2a6fee1557c51e2220fe7f1849239da3a2c.tar.gz
PrismLauncher-4e97f2a6fee1557c51e2220fe7f1849239da3a2c.tar.bz2
PrismLauncher-4e97f2a6fee1557c51e2220fe7f1849239da3a2c.zip
Merge pull request #470 from kthchew/fix/ml-selector-crash
Fix crash if no Minecraft version is selected in the new instance screen
Diffstat (limited to 'launcher/ui')
-rw-r--r--launcher/ui/pages/modplatform/VanillaPage.cpp13
1 files changed, 12 insertions, 1 deletions
diff --git a/launcher/ui/pages/modplatform/VanillaPage.cpp b/launcher/ui/pages/modplatform/VanillaPage.cpp
index 175fda7d..a026947f 100644
--- a/launcher/ui/pages/modplatform/VanillaPage.cpp
+++ b/launcher/ui/pages/modplatform/VanillaPage.cpp
@@ -118,7 +118,18 @@ void VanillaPage::filterChanged()
void VanillaPage::loaderFilterChanged()
{
- auto minecraftVersion = m_selectedVersion->descriptor();
+ QString minecraftVersion;
+ if (m_selectedVersion)
+ {
+ minecraftVersion = m_selectedVersion->descriptor();
+ }
+ else
+ {
+ ui->loaderVersionList->setExactFilter(BaseVersionList::ParentVersionRole, "AAA"); // empty list
+ ui->loaderVersionList->setEmptyString(tr("No Minecraft version is selected."));
+ ui->loaderVersionList->setEmptyMode(VersionListView::String);
+ return;
+ }
if(ui->noneFilter->isChecked())
{
ui->loaderVersionList->setExactFilter(BaseVersionList::ParentVersionRole, "AAA"); // empty list