aboutsummaryrefslogtreecommitdiff
path: root/launcher/ui
diff options
context:
space:
mode:
authorflow <flowlnlnln@gmail.com>2022-08-09 01:58:22 -0300
committerflow <flowlnlnln@gmail.com>2022-08-20 10:45:01 -0300
commitec62d8e97334d3b5a30cea00858e7035468f3609 (patch)
treee87204d6c76c40191fe39d0324ff5bb6a9f787cd /launcher/ui
parent3225f514f64533394e14bf7aee4e61c19a72ed2f (diff)
downloadPrismLauncher-ec62d8e97334d3b5a30cea00858e7035468f3609.tar.gz
PrismLauncher-ec62d8e97334d3b5a30cea00858e7035468f3609.tar.bz2
PrismLauncher-ec62d8e97334d3b5a30cea00858e7035468f3609.zip
refactor: move general code from mod model to its own model
This aims to continue decoupling other types of resources (e.g. resource packs, shader packs, etc) from mods, so that we don't have to continuously watch our backs for changes to one of them affecting the others. To do so, this creates a more general list model for resources, based on the mods one, that allows you to extend it with functionality for other resources. I had to do some template and preprocessor stuff to get around the QObject limitation of not allowing templated classes, so that's sadge :c On the other hand, I tried cleaning up most general-purpose code in the mod model, and added some documentation, because it looks nice :D Signed-off-by: flow <flowlnlnln@gmail.com>
Diffstat (limited to 'launcher/ui')
-rw-r--r--launcher/ui/pages/instance/ExternalResourcesPage.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/launcher/ui/pages/instance/ExternalResourcesPage.cpp b/launcher/ui/pages/instance/ExternalResourcesPage.cpp
index 39fbe3e2..da7c4af0 100644
--- a/launcher/ui/pages/instance/ExternalResourcesPage.cpp
+++ b/launcher/ui/pages/instance/ExternalResourcesPage.cpp
@@ -32,12 +32,12 @@ class SortProxy : public QSortFilterProxyModel {
const auto& mod = model->at(source_row);
- if (filterRegularExpression().match(mod.name()).hasMatch())
+ if (filterRegularExpression().match(mod->name()).hasMatch())
return true;
- if (filterRegularExpression().match(mod.description()).hasMatch())
+ if (filterRegularExpression().match(mod->description()).hasMatch())
return true;
- for (auto& author : mod.authors()) {
+ for (auto& author : mod->authors()) {
if (filterRegularExpression().match(author).hasMatch()) {
return true;
}
@@ -292,6 +292,6 @@ void ExternalResourcesPage::current(const QModelIndex& current, const QModelInde
auto sourceCurrent = m_filterModel->mapToSource(current);
int row = sourceCurrent.row();
- Mod& m = m_model->operator[](row);
+ Mod& m = *m_model->operator[](row);
ui->frame->updateWithMod(m);
}