Merge pull request #1017 from flowln/kill_orphan_metadata

Remove orphaned metadata to avoid problems with auto-updating instances

1 files changed, 11 insertions, 0 deletions

diff --git a/launcher/minecraft/mod/tasks/ModFolderLoadTask.cpp b/launcher/minecraft/mod/tasks/ModFolderLoadTask.cpp
index a2e055ba..9b70e7a1 100644
--- a/launcher/minecraft/mod/tasks/ModFolderLoadTask.cpp
+++ b/launcher/minecraft/mod/tasks/ModFolderLoadTask.cpp
@@ -83,6 +83,17 @@ void ModFolderLoadTask::run()
         }
     }
 
+    // Remove orphan metadata to prevent issues
+    // See https://github.com/PolyMC/PolyMC/issues/996
+    QMutableMapIterator<QString, Mod::Ptr> iter(m_result->mods);
+    while (iter.hasNext()) {
+        auto mod = iter.next().value();
+        if (mod->status() == ModStatus::NotInstalled) {
+            mod->destroy(m_index_dir, false);
+            iter.remove();
+        }
+    }
+
     emit succeeded();
 }