diff options
| author | Sefa Eyeoglu <contact@scrumplex.net> | 2022-07-09 01:10:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-09 01:10:59 +0200 |
| commit | e6fe701727268a5c2284fec2867c0a9bfe10b1aa (patch) | |
| tree | ce1097293bb6b5393fa1172a73cb2f13354c5234 /launcher | |
| parent | 35a698ef725bf250a5348bea8c47ff3470be7515 (diff) | |
| parent | 9ec260619b48447e398445aecd6651d319b8217e (diff) | |
| download | PrismLauncher-e6fe701727268a5c2284fec2867c0a9bfe10b1aa.tar.gz PrismLauncher-e6fe701727268a5c2284fec2867c0a9bfe10b1aa.tar.bz2 PrismLauncher-e6fe701727268a5c2284fec2867c0a9bfe10b1aa.zip | |
Merge pull request #808 from Scrumplex/fix-lgtm-warnings
Diffstat (limited to 'launcher')
| -rw-r--r-- | launcher/minecraft/auth/AccountTask.cpp | 2 | ||||
| -rw-r--r-- | launcher/modplatform/flame/FlameAPI.h | 2 | ||||
| -rw-r--r-- | launcher/translations/POTranslator.cpp | 5 | ||||
| -rw-r--r-- | launcher/translations/POTranslator.h | 1 |
4 files changed, 9 insertions, 1 deletions
diff --git a/launcher/minecraft/auth/AccountTask.cpp b/launcher/minecraft/auth/AccountTask.cpp index 49b6e46f..4118c3c5 100644 --- a/launcher/minecraft/auth/AccountTask.cpp +++ b/launcher/minecraft/auth/AccountTask.cpp @@ -79,6 +79,8 @@ QString AccountTask::getStateMessage() const bool AccountTask::changeState(AccountTaskState newState, QString reason) { m_taskState = newState; + // FIXME: virtual method invoked in constructor. + // We want that behavior, but maybe make it less weird? setStatus(getStateMessage()); switch(newState) { case AccountTaskState::STATE_CREATED: { diff --git a/launcher/modplatform/flame/FlameAPI.h b/launcher/modplatform/flame/FlameAPI.h index 424153d2..aea76ff1 100644 --- a/launcher/modplatform/flame/FlameAPI.h +++ b/launcher/modplatform/flame/FlameAPI.h @@ -59,7 +59,7 @@ class FlameAPI : public NetworkModAPI { }; public: - static auto getMappedModLoader(const ModLoaderTypes loaders) -> const int + static auto getMappedModLoader(const ModLoaderTypes loaders) -> int { // https://docs.curseforge.com/?http#tocS_ModLoaderType if (loaders & Forge) diff --git a/launcher/translations/POTranslator.cpp b/launcher/translations/POTranslator.cpp index 1ffcb9a4..c77ae45d 100644 --- a/launcher/translations/POTranslator.cpp +++ b/launcher/translations/POTranslator.cpp @@ -329,6 +329,11 @@ POTranslator::POTranslator(const QString& filename, QObject* parent) : QTranslat d->reload(); } +POTranslator::~POTranslator() +{ + delete d; +} + QString POTranslator::translate(const char* context, const char* sourceText, const char* disambiguation, int n) const { if(disambiguation) diff --git a/launcher/translations/POTranslator.h b/launcher/translations/POTranslator.h index 6d518560..1634018c 100644 --- a/launcher/translations/POTranslator.h +++ b/launcher/translations/POTranslator.h @@ -9,6 +9,7 @@ class POTranslator : public QTranslator Q_OBJECT public: explicit POTranslator(const QString& filename, QObject * parent = nullptr); + virtual ~POTranslator(); QString translate(const char * context, const char * sourceText, const char * disambiguation, int n) const override; bool isEmpty() const override; private: |