aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CMakeLists.txt8
-rw-r--r--MultiMC.cpp34
-rw-r--r--MultiMC.h84
-rw-r--r--gui/IconPickerDialog.cpp2
-rw-r--r--gui/LegacyModEditDialog.cpp206
-rw-r--r--gui/LegacyModEditDialog.h8
-rw-r--r--gui/OneSixModEditDialog.cpp19
-rw-r--r--gui/OneSixModEditDialog.h6
-rw-r--r--gui/aboutdialog.ui97
-rw-r--r--gui/logindialog.cpp10
-rw-r--r--gui/lwjglselectdialog.cpp6
-rw-r--r--gui/mainwindow.cpp360
-rw-r--r--gui/newinstancedialog.cpp2
-rw-r--r--gui/settingsdialog.cpp4
-rw-r--r--gui/versionselectdialog.cpp2
-rw-r--r--logger/QsDebugOutput.cpp52
-rw-r--r--logger/QsDebugOutput.h34
-rw-r--r--logger/QsLog.cpp141
-rw-r--r--logger/QsLog.h130
-rw-r--r--logger/QsLogDest.cpp83
-rw-r--r--logger/QsLogDest.h53
-rw-r--r--logic/BaseInstance.cpp2
-rw-r--r--logic/BaseInstance.h6
-rw-r--r--logic/BaseInstance_p.h2
-rw-r--r--logic/BaseVersion.h4
-rw-r--r--logic/ForgeInstaller.cpp4
-rw-r--r--logic/ForgeInstaller.h6
-rw-r--r--logic/InstanceFactory.cpp5
-rw-r--r--logic/InstanceLauncher.cpp2
-rw-r--r--logic/LegacyInstance.cpp8
-rw-r--r--logic/LegacyInstance.h8
-rw-r--r--logic/LegacyInstance_p.h8
-rw-r--r--logic/LegacyUpdate.cpp213
-rw-r--r--logic/LegacyUpdate.h2
-rw-r--r--logic/Mod.cpp7
-rw-r--r--logic/ModList.cpp16
-rw-r--r--logic/OneSixAssets.cpp13
-rw-r--r--logic/OneSixInstance.cpp9
-rw-r--r--logic/OneSixInstance.h6
-rw-r--r--logic/OneSixInstance_p.h6
-rw-r--r--logic/OneSixLibrary.cpp2
-rw-r--r--logic/OneSixLibrary.h6
-rw-r--r--logic/OneSixRule.cpp6
-rw-r--r--logic/OneSixRule.h10
-rw-r--r--logic/OneSixUpdate.cpp25
-rw-r--r--logic/OneSixUpdate.h2
-rw-r--r--logic/OneSixVersion.cpp28
-rw-r--r--logic/OneSixVersion.h12
-rw-r--r--logic/lists/ForgeVersionList.cpp20
-rw-r--r--logic/lists/ForgeVersionList.h2
-rw-r--r--logic/lists/InstanceList.cpp218
-rw-r--r--logic/lists/LwjglVersionList.cpp62
-rw-r--r--logic/lists/LwjglVersionList.h6
-rw-r--r--logic/lists/MinecraftVersionList.cpp10
-rw-r--r--logic/net/ByteArrayDownload.cpp13
-rw-r--r--logic/net/ByteArrayDownload.h2
-rw-r--r--logic/net/CacheDownload.cpp10
-rw-r--r--logic/net/CacheDownload.h2
-rw-r--r--logic/net/Download.h18
-rw-r--r--logic/net/DownloadJob.cpp22
-rw-r--r--logic/net/DownloadJob.h2
-rw-r--r--logic/net/FileDownload.cpp12
-rw-r--r--logic/net/FileDownload.h2
-rw-r--r--logic/net/ForgeXzDownload.cpp26
-rw-r--r--logic/net/ForgeXzDownload.h2
-rw-r--r--logic/net/HttpMetaCache.cpp6
-rw-r--r--logic/net/HttpMetaCache.h2
-rw-r--r--logic/net/LoginTask.cpp4
-rw-r--r--logic/tasks/Task.cpp2
69 files changed, 1375 insertions, 827 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e0637054..7ecfb690 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -168,6 +168,14 @@ MultiMC.h
MultiMC.cpp
MultiMCVersion.h
+# Logging
+logger/QsDebugOutput.cpp
+logger/QsDebugOutput.h
+logger/QsLog.cpp
+logger/QsLog.h
+logger/QsLogDest.cpp
+logger/QsLogDest.h
+
# GUI
gui/mainwindow.h
gui/mainwindow.cpp
diff --git a/MultiMC.cpp b/MultiMC.cpp
index ee9a9bf8..b685ed13 100644
--- a/MultiMC.cpp
+++ b/MultiMC.cpp
@@ -20,6 +20,8 @@
#include "cmdutils.h"
#include <inisettingsobject.h>
#include <setting.h>
+#include <logger/QsLog.h>
+#include <logger/QsLogDest.h>
#include "config.h"
using namespace Util::Commandline;
@@ -123,6 +125,9 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv)
// change directory
QDir::setCurrent(args["dir"].toString());
+ // init the logger
+ initLogger();
+
// load settings
initGlobalSettings();
@@ -156,11 +161,11 @@ MultiMC::~MultiMC()
{
if (m_mmc_translator)
{
- removeTranslator(m_mmc_translator.data());
+ removeTranslator(m_mmc_translator.get());
}
if (m_qt_translator)
{
- removeTranslator(m_qt_translator.data());
+ removeTranslator(m_qt_translator.get());
}
}
@@ -172,7 +177,7 @@ void MultiMC::initTranslations()
{
std::cout << "Loading Qt Language File for "
<< QLocale::system().name().toLocal8Bit().constData() << "...";
- if (!installTranslator(m_qt_translator.data()))
+ if (!installTranslator(m_qt_translator.get()))
{
std::cout << " failed.";
m_qt_translator.reset();
@@ -190,7 +195,7 @@ void MultiMC::initTranslations()
{
std::cout << "Loading MMC Language File for "
<< QLocale::system().name().toLocal8Bit().constData() << "...";
- if (!installTranslator(m_mmc_translator.data()))
+ if (!installTranslator(m_mmc_translator.get()))
{
std::cout << " failed.";
m_mmc_translator.reset();
@@ -203,6 +208,19 @@ void MultiMC::initTranslations()
}
}
+void MultiMC::initLogger()
+{
+ // init the logging mechanism
+ QsLogging::Logger &logger = QsLogging::Logger::instance();
+ logger.setLoggingLevel(QsLogging::TraceLevel);
+ m_fileDestination = QsLogging::DestinationFactory::MakeFileDestination("MultiMC.log");
+ m_debugDestination = QsLogging::DestinationFactory::MakeDebugOutputDestination();
+ logger.addDestination(m_fileDestination.get());
+ logger.addDestination(m_debugDestination.get());
+ // log all the things
+ logger.setLoggingLevel(QsLogging::TraceLevel);
+}
+
void MultiMC::initGlobalSettings()
{
m_settings.reset(new INISettingsObject("multimc.cfg", this));
@@ -275,7 +293,7 @@ void MultiMC::initHttpMetaCache()
m_metacache->Load();
}
-QSharedPointer<IconList> MultiMC::icons()
+std::shared_ptr<IconList> MultiMC::icons()
{
if (!m_icons)
{
@@ -284,7 +302,7 @@ QSharedPointer<IconList> MultiMC::icons()
return m_icons;
}
-QSharedPointer<LWJGLVersionList> MultiMC::lwjgllist()
+std::shared_ptr<LWJGLVersionList> MultiMC::lwjgllist()
{
if (!m_lwjgllist)
{
@@ -293,7 +311,7 @@ QSharedPointer<LWJGLVersionList> MultiMC::lwjgllist()
return m_lwjgllist;
}
-QSharedPointer<ForgeVersionList> MultiMC::forgelist()
+std::shared_ptr<ForgeVersionList> MultiMC::forgelist()
{
if (!m_forgelist)
{
@@ -302,7 +320,7 @@ QSharedPointer<ForgeVersionList> MultiMC::forgelist()
return m_forgelist;
}
-QSharedPointer<MinecraftVersionList> MultiMC::minecraftlist()
+std::shared_ptr<MinecraftVersionList> MultiMC::minecraftlist()
{
if (!m_minecraftlist)
{
diff --git a/MultiMC.h b/MultiMC.h
index c634dd33..ec28cab2 100644
--- a/MultiMC.h
+++ b/MultiMC.h
@@ -1,9 +1,12 @@
#pragma once
#include <QApplication>
-#include <QSharedPointer>
#include "MultiMCVersion.h"
#include "config.h"
+#include <memory>
+#include "logger/QsLog.h"
+#include "logger/QsLogDest.h"
+
class MinecraftVersionList;
class LWJGLVersionList;
@@ -29,67 +32,72 @@ public:
Succeeded,
Initialized,
};
-
+
public:
- MultiMC ( int& argc, char** argv );
+ MultiMC(int &argc, char **argv);
virtual ~MultiMC();
-
- QSharedPointer<SettingsObject> settings()
+
+ std::shared_ptr<SettingsObject> settings()
{
return m_settings;
- };
-
- QSharedPointer<InstanceList> instances()
+ }
+
+ std::shared_ptr<InstanceList> instances()
{
return m_instances;
- };
-
- QSharedPointer<IconList> icons();
-
+ }
+
+ std::shared_ptr<IconList> icons();
+
Status status()
{
return m_status;
}
-
+
MultiMCVersion version()
{
return m_version;
}
-
- QSharedPointer<QNetworkAccessManager> qnam()
+
+ std::shared_ptr<QNetworkAccessManager> qnam()
{
return m_qnam;
}
-
- QSharedPointer<HttpMetaCache> metacache()
+
+ std::shared_ptr<HttpMetaCache> metacache()
{
return m_metacache;
}
-
- QSharedPointer<LWJGLVersionList> lwjgllist();
-
- QSharedPointer<ForgeVersionList> forgelist();
-
- QSharedPointer<MinecraftVersionList> minecraftlist();
-
+
+ std::shared_ptr<LWJGLVersionList> lwjgllist();
+
+ std::shared_ptr<ForgeVersionList> forgelist();
+
+ std::shared_ptr<MinecraftVersionList> minecraftlist();
+
private:
+ void initLogger();
+
void initGlobalSettings();
-
+
void initHttpMetaCache();
-
+
void initTranslations();
+
private:
- QSharedPointer<QTranslator> m_qt_translator;
- QSharedPointer<QTranslator> m_mmc_translator;
- QSharedPointer<SettingsObject> m_settings;
- QSharedPointer<InstanceList> m_instances;
- QSharedPointer<IconList> m_icons;
- QSharedPointer<QNetworkAccessManager> m_qnam;
- QSharedPointer<HttpMetaCache> m_metacache;
- QSharedPointer<LWJGLVersionList> m_lwjgllist;
- QSharedPointer<ForgeVersionList> m_forgelist;
- QSharedPointer<MinecraftVersionList> m_minecraftlist;
-
+ std::shared_ptr<QTranslator> m_qt_translator;
+ std::shared_ptr<QTranslator> m_mmc_translator;
+ std::shared_ptr<SettingsObject> m_settings;
+ std::shared_ptr<InstanceList> m_instances;
+ std::shared_ptr<IconList> m_icons;
+ std::shared_ptr<QNetworkAccessManager> m_qnam;
+ std::shared_ptr<HttpMetaCache> m_metacache;
+ std::shared_ptr<LWJGLVersionList> m_lwjgllist;
+ std::shared_ptr<ForgeVersionList> m_forgelist;
+ std::shared_ptr<MinecraftVersionList> m_minecraftlist;
+ QsLogging::DestinationPtr m_fileDestination;
+ QsLogging::DestinationPtr m_debugDestination;
+
Status m_status = MultiMC::Failed;
MultiMCVersion m_version = {VERSION_MAJOR, VERSION_MINOR, VERSION_REVISION, VERSION_BUILD};
-}; \ No newline at end of file
+};
diff --git a/gui/IconPickerDialog.cpp b/gui/IconPickerDialog.cpp
index 8f5d8256..6a1ca546 100644
--- a/gui/IconPickerDialog.cpp
+++ b/gui/IconPickerDialog.cpp
@@ -39,7 +39,7 @@ IconPickerDialog::IconPickerDialog(QWidget *parent) :
contentsWidget->installEventFilter(this);
- contentsWidget->setModel(MMC->icons().data());
+ contentsWidget->setModel(MMC->icons().get());
auto buttonAdd = ui->buttonBox->addButton(tr("Add Icon"),QDialogButtonBox::ResetRole);
auto buttonRemove = ui->buttonBox->addButton(tr("Remove Icon"),QDialogButtonBox::ResetRole);
diff --git a/gui/LegacyModEditDialog.cpp b/gui/LegacyModEditDialog.cpp
index 053aef6b..c240daff 100644
--- a/gui/LegacyModEditDialog.cpp
+++ b/gui/LegacyModEditDialog.cpp
@@ -3,7 +3,7 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
@@ -28,49 +28,47 @@
#include <QEvent>
#include <QKeyEvent>
-LegacyModEditDialog::LegacyModEditDialog( LegacyInstance* inst, QWidget* parent ) :
- m_inst(inst),
- QDialog(parent),
- ui(new Ui::LegacyModEditDialog)
+LegacyModEditDialog::LegacyModEditDialog(LegacyInstance *inst, QWidget *parent)
+ : m_inst(inst), QDialog(parent), ui(new Ui::LegacyModEditDialog)
{
ui->setupUi(this);
-
+
// Jar mods
{
ensureFolderPathExists(m_inst->jarModsDir());
m_jarmods = m_inst->jarModList();
- ui->jarModsTreeView->setModel(m_jarmods.data());
+ ui->jarModsTreeView->setModel(m_jarmods.get());
#ifndef Q_OS_LINUX
// FIXME: internal DnD causes segfaults later
ui->jarModsTreeView->setDragDropMode(QAbstractItemView::DragDrop);
// FIXME: DnD is glitched with contiguous (we move only first item in selection)
ui->jarModsTreeView->setSelectionMode(QAbstractItemView::SingleSelection);
#endif
- ui->jarModsTreeView->installEventFilter( this );
+ ui->jarModsTreeView->installEventFilter(this);
m_jarmods->startWatching();
}
// Core mods
{
ensureFolderPathExists(m_inst->coreModsDir());
m_coremods = m_inst->coreModList();
- ui->coreModsTreeView->setModel(m_coremods.data());
- ui->coreModsTreeView->installEventFilter( this );
+ ui->coreModsTreeView->setModel(m_coremods.get());
+ ui->coreModsTreeView->installEventFilter(this);
m_coremods->startWatching();
}
// Loader mods
{
ensureFolderPathExists(m_inst->loaderModsDir());
m_mods = m_inst->loaderModList();
- ui->loaderModTreeView->setModel(m_mods.data());
- ui->loaderModTreeView->installEventFilter( this );
+ ui->loaderModTreeView->setModel(m_mods.get());
+ ui->loaderModTreeView->installEventFilter(this);
m_mods->startWatching();
}
// texture packs
{
ensureFolderPathExists(m_inst->texturePacksDir());
m_texturepacks = m_inst->texturePackList();
- ui->texPackTreeView->setModel(m_texturepacks.data());
- ui->texPackTreeView->installEventFilter( this );
+ ui->texPackTreeView->setModel(m_texturepacks.get());
+ ui->texPackTreeView->installEventFilter(this);
m_texturepacks->startWatching();
}
}
@@ -84,113 +82,111 @@ LegacyModEditDialog::~LegacyModEditDialog()
delete ui;
}
-bool LegacyModEditDialog::coreListFilter ( QKeyEvent* keyEvent )
+bool LegacyModEditDialog::coreListFilter(QKeyEvent *keyEvent)
{
- switch(keyEvent->key())
+ switch (keyEvent->key())
{
- case Qt::Key_Delete:
- on_rmCoreBtn_clicked();
- return true;
- case Qt::Key_Plus:
- on_addCoreBtn_clicked();
- return true;
- default:
- break;
+ case Qt::Key_Delete:
+ on_rmCoreBtn_clicked();
+ return true;
+ case Qt::Key_Plus:
+ on_addCoreBtn_clicked();
+ return true;
+ default:
+ break;
}
- return QDialog::eventFilter( ui->coreModsTreeView, keyEvent );
+ return QDialog::eventFilter(ui->coreModsTreeView, keyEvent);
}
-bool LegacyModEditDialog::jarListFilter ( QKeyEvent* keyEvent )
+bool LegacyModEditDialog::jarListFilter(QKeyEvent *keyEvent)
{
- switch(keyEvent->key())
+ switch (keyEvent->key())
{
- case Qt::Key_Up:
+ case Qt::Key_Up:
+ {
+ if (keyEvent->modifiers() & Qt::ControlModifier)
{
- if(keyEvent->modifiers() & Qt::ControlModifier)
- {
- on_moveJarUpBtn_clicked();
- return true;
- }
- break;
+ on_moveJarUpBtn_clicked();
+ return true;
}
- case Qt::Key_Down:
+ break;
+ }
+ case Qt::Key_Down:
+ {
+ if (keyEvent->modifiers() & Qt::ControlModifier)
{
- if(keyEvent->modifiers() & Qt::ControlModifier)
- {
- on_moveJarDownBtn_clicked();
- return true;
- }
- break;
- }
- case Qt::Key_Delete:
- on_rmJarBtn_clicked();
- return true;
- case Qt::Key_Plus:
- on_addJarBtn_clicked();
+ on_moveJarDownBtn_clicked();
return true;
- default:
- break;
+ }
+ break;
}
- return QDialog::eventFilter( ui->jarModsTreeView, keyEvent );
+ case Qt::Key_Delete:
+ on_rmJarBtn_clicked();
+ return true;
+ case Qt::Key_Plus:
+ on_addJarBtn_clicked();
+ return true;
+ default:
+ break;
+ }
+ return QDialog::eventFilter(ui->jarModsTreeView, keyEvent);
}
-bool LegacyModEditDialog::loaderListFilter ( QKeyEvent* keyEvent )
+bool LegacyModEditDialog::loaderListFilter(QKeyEvent *keyEvent)
{
- switch(keyEvent->key())
+ switch (keyEvent->key())
{
- case Qt::Key_Delete:
- on_rmModBtn_clicked();
- return true;
- case Qt::Key_Plus:
- on_addModBtn_clicked();
- return true;
- default:
- break;
+ case Qt::Key_Delete:
+ on_rmModBtn_clicked();
+ return true;
+ case Qt::Key_Plus:
+ on_addModBtn_clicked();
+ return true;
+ default:
+ break;
}
- return QDialog::eventFilter( ui->loaderModTreeView, keyEvent );
+ return QDialog::eventFilter(ui->loaderModTreeView, keyEvent);
}
-bool LegacyModEditDialog::texturePackListFilter ( QKeyEvent* keyEvent )
+bool LegacyModEditDialog::texturePackListFilter(QKeyEvent *keyEvent)
{
- switch(keyEvent->key())
+ switch (keyEvent->key())
{
- case Qt::Key_Delete:
- on_rmTexPackBtn_clicked();
- return true;
- case Qt::Key_Plus:
- on_addTexPackBtn_clicked();
- return true;
- default:
- break;
+ case Qt::Key_Delete:
+ on_rmTexPackBtn_clicked();
+ return true;
+ case Qt::Key_Plus:
+ on_addTexPackBtn_clicked();
+ return true;
+ default:
+ break;
}
- return QDialog::eventFilter( ui->texPackTreeView, keyEvent );
+ return QDialog::eventFilter(ui->texPackTreeView, keyEvent);
}
-
-bool LegacyModEditDialog::eventFilter ( QObject* obj, QEvent* ev )
+bool LegacyModEditDialog::eventFilter(QObject *obj, QEvent *ev)
{
if (ev->type() != QEvent::KeyPress)
{
- return QDialog::eventFilter( obj, ev );
+ return QDialog::eventFilter(obj, ev);
}
- QKeyEvent *keyEvent = static_cast<QKeyEvent*>(ev);
- if(obj == ui->jarModsTreeView)
+ QKeyEvent *keyEvent = static_cast<QKeyEvent *>(ev);
+ if (obj == ui->jarModsTreeView)
return jarListFilter(keyEvent);
- if(obj == ui->coreModsTreeView)
+ if (obj == ui->coreModsTreeView)
return coreListFilter(keyEvent);
- if(obj == ui->loaderModTreeView)
+ if (obj == ui->loaderModTreeView)
return loaderListFilter(keyEvent);
- if(obj == ui->texPackTreeView)
+ if (obj == ui->texPackTreeView)
return texturePackListFilter(keyEvent);
- return QDialog::eventFilter( obj, ev );
+ return QDialog::eventFilter(obj, ev);
}
-
void LegacyModEditDialog::on_addCoreBtn_clicked()
{
//: Title of core mod selection dialog
QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Select Core Mods"));
- for(auto filename:fileNames)
+ for (auto filename : fileNames)
{
m_coremods->stopWatching();
m_coremods->installMod(QFileInfo(filename));
@@ -199,21 +195,22 @@ void LegacyModEditDialog::on_addCoreBtn_clicked()
}
void LegacyModEditDialog::on_addForgeBtn_clicked()
{
- VersionSelectDialog vselect(MMC->forgelist().data(), this);
+ VersionSelectDialog vselect(MMC->forgelist().get(), this);
vselect.setFilter(1, m_inst->intendedVersionId());
if (vselect.exec() && vselect.selectedVersion())
{
- ForgeVersionPtr forge = vselect.selectedVersion().dynamicCast<ForgeVersion>();
- if(!forge)
+ ForgeVersionPtr forge =
+ std::dynamic_pointer_cast<ForgeVersion> (vselect.selectedVersion());
+ if (!forge)
return;
auto entry = MMC->metacache()->resolveEntry("minecraftforge", forge->filename);
- if(entry->stale)
+ if (entry->stale)
{
- DownloadJob * fjob = new DownloadJob("Forge download");
+ DownloadJob *fjob = new DownloadJob("Forge download");
fjob->addCacheDownload(forge->universal_url, entry);
ProgressDialog dlg(this);
dlg.exec(fjob);
- if(dlg.result() == QDialog::Accepted)
+ if (dlg.result() == QDialog::Accepted)
{
m_jarmods->stopWatching();
m_jarmods->installMod(QFileInfo(entry->getFullPath()));
@@ -236,7 +233,7 @@ void LegacyModEditDialog::on_addJarBtn_clicked()
{
//: Title of jar mod selection dialog
QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Select Jar Mods"));
- for(auto filename:fileNames)
+ for (auto filename : fileNames)
{
m_jarmods->stopWatching();
m_jarmods->installMod(QFileInfo(filename));
@@ -247,7 +244,7 @@ void LegacyModEditDialog::on_addModBtn_clicked()
{
//: Title of regular mod selection dialog
QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Select Loader Mods"));
- for(auto filename:fileNames)
+ for (auto filename : fileNames)
{
m_mods->stopWatching();
m_mods->installMod(QFileInfo(filename));
@@ -258,7 +255,7 @@ void LegacyModEditDialog::on_addTexPackBtn_clicked()
{
//: Title of texture pack selection dialog
QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Select Texture Packs"));
- for(auto filename:fileNames)
+ for (auto filename : fileNames)
{
m_texturepacks->stopWatching();
m_texturepacks->installMod(QFileInfo(filename));
@@ -270,8 +267,8 @@ void LegacyModEditDialog::on_moveJarDownBtn_clicked()
{
int first, last;
auto list = ui->jarModsTreeView->selectionModel()->selectedRows();
-
- if(!lastfirst(list, first, last))
+
+ if (!lastfirst(list, first, last))
return;
m_jarmods->moveModsDown(first, last);
@@ -280,8 +277,8 @@ void LegacyModEditDialog::on_moveJarUpBtn_clicked()
{
int first, last;
auto list = ui->jarModsTreeView->selectionModel()->selectedRows();
-
- if(!lastfirst(list, first, last))
+
+ if (!lastfirst(list, first, last))
return;
m_jarmods->moveModsUp(first, last);
}
@@ -289,8 +286,8 @@ void LegacyModEditDialog::on_rmCoreBtn_clicked()
{
int first, last;
auto list = ui->coreModsTreeView->selectionModel()->selectedRows();
-
- if(!lastfirst(list, first, last))
+