summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJesse Plamondon-Willard <Pathoschild@users.noreply.github.com>2018-12-13 00:34:28 -0500
committerJesse Plamondon-Willard <Pathoschild@users.noreply.github.com>2018-12-13 00:34:28 -0500
commitcd277e915f85260c8af665b5aeb44368badf06e8 (patch)
tree5ad41162f8e327c4263dbc02f3c1715b95a2a424
parent3fef9bb2a5cc39fc6ba15199b0889fae5533c5f0 (diff)
downloadSMAPI-cd277e915f85260c8af665b5aeb44368badf06e8.tar.gz
SMAPI-cd277e915f85260c8af665b5aeb44368badf06e8.tar.bz2
SMAPI-cd277e915f85260c8af665b5aeb44368badf06e8.zip
fix NPCDisposition asset propagation breaking NPC data
-rw-r--r--docs/release-notes.md1
-rw-r--r--src/SMAPI/Metadata/CoreAssetPropagator.cs2
2 files changed, 2 insertions, 1 deletions
diff --git a/docs/release-notes.md b/docs/release-notes.md
index 6033b141..6c10b4ac 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -2,6 +2,7 @@
## Upcoming release
* For players:
* Fixed error when a mod makes invalid changes to an NPC schedule.
+ * Fixed invalid NPC data propagated when a mod changes NPC dispositions.
* Fixed `Display.RenderedWorld` event broken in SMAPI 2.9.1.
## 2.9.1
diff --git a/src/SMAPI/Metadata/CoreAssetPropagator.cs b/src/SMAPI/Metadata/CoreAssetPropagator.cs
index 4667be7e..a44ab7d1 100644
--- a/src/SMAPI/Metadata/CoreAssetPropagator.cs
+++ b/src/SMAPI/Metadata/CoreAssetPropagator.cs
@@ -504,7 +504,7 @@ namespace StardewModdingAPI.Metadata
if (!character.isVillager() || !dispositions.ContainsKey(character.Name))
continue;
- NPC clone = new NPC(null, Vector2.Zero, 0, character.Name);
+ NPC clone = new NPC(null, character.Position, character.DefaultMap, character.FacingDirection, character.Name, null, character.Portrait, eventActor: false);
character.Age = clone.Age;
character.Manners = clone.Manners;
character.SocialAnxiety = clone.SocialAnxiety;