diff options
| author | Ishan Jalan <44338423+ishanjalan@users.noreply.github.com> | 2022-07-24 12:07:38 +0530 |
|---|---|---|
| committer | Ishan Jalan <44338423+ishanjalan@users.noreply.github.com> | 2022-07-24 12:07:38 +0530 |
| commit | dd2e3e9d933c69aba2a11815191046903c7fa5ee (patch) | |
| tree | 4dae53dbd9fa0789be752ef53243052657dd1622 /src/SMAPI.Installer/assets | |
| parent | a50a730886e2649472011e5c0eca5113b3774555 (diff) | |
| download | SMAPI-dd2e3e9d933c69aba2a11815191046903c7fa5ee.tar.gz SMAPI-dd2e3e9d933c69aba2a11815191046903c7fa5ee.tar.bz2 SMAPI-dd2e3e9d933c69aba2a11815191046903c7fa5ee.zip | |
Jetbrains Rider suggestions
I ran the file on Rider and it had a few suggestions
<img width="506" alt="image" src="https://user-images.githubusercontent.com/44338423/180635394-cb45defa-47f4-444c-ad10-e0fc89522fe7.png">
Diffstat (limited to 'src/SMAPI.Installer/assets')
| -rw-r--r-- | src/SMAPI.Installer/assets/unix-launcher.sh | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/src/SMAPI.Installer/assets/unix-launcher.sh b/src/SMAPI.Installer/assets/unix-launcher.sh index b9d468a0..88a3a328 100644 --- a/src/SMAPI.Installer/assets/unix-launcher.sh +++ b/src/SMAPI.Installer/assets/unix-launcher.sh @@ -55,7 +55,7 @@ if [ "$(uname)" == "Darwin" ]; then if [ "$USE_CURRENT_SHELL" == "false" ]; then echo "Reopening in the Terminal app..." echo '#!/bin/sh' > /tmp/open-smapi-terminal.command - echo "\"$0\" $@ --use-current-shell" >> /tmp/open-smapi-terminal.command + echo "\"$0\" $* --use-current-shell" >> /tmp/open-smapi-terminal.command chmod +x /tmp/open-smapi-terminal.command cat /tmp/open-smapi-terminal.command open -W /tmp/open-smapi-terminal.command @@ -71,8 +71,8 @@ fi ########## # script must be run from the game folder if [ ! -f "Stardew Valley.dll" ]; then - echo "Oops! SMAPI must be placed in the Stardew Valley game folder.\nSee instructions: https://stardewvalleywiki.com/Modding:Player_Guide"; - read + printf "Oops! SMAPI must be placed in the Stardew Valley game folder.\nSee instructions: https://stardewvalleywiki.com/Modding:Player_Guide"; + read -r exit 1 fi @@ -102,37 +102,39 @@ else # find the true shell behind x-terminal-emulator if [ "$TERMINAL_NAME" = "x-terminal-emulator" ]; then - export TERMINAL_NAME="$(basename "$(readlink -f $(command -v x-terminal-emulator))")" + TERMINAL_NAME="$(basename "$(readlink -f "$(command -v x-terminal-emulator)")")" + export TERMINAL_NAME fi # run in selected terminal and account for quirks - export TERMINAL_PATH="$(command -v $TERMINAL_NAME)" - if [ -x $TERMINAL_PATH ]; then + TERMINAL_PATH="$(command -v "$TERMINAL_NAME")" + export TERMINAL_PATH + if [ -x "$TERMINAL_PATH" ]; then case $TERMINAL_NAME in terminal|termite) # consumes only one argument after -e # options containing space characters are unsupported - exec $TERMINAL_NAME -e "env TERM=xterm $LAUNCH_FILE $@" + exec "$TERMINAL_NAME" -e "env TERM=xterm $LAUNCH_FILE $*" ;; xterm|konsole|alacritty) # consumes all arguments after -e - exec $TERMINAL_NAME -e env TERM=xterm $LAUNCH_FILE "$@" + exec "$TERMINAL_NAME" -e env TERM=xterm $LAUNCH_FILE "$*" ;; terminator|xfce4-terminal|mate-terminal) # consumes all arguments after -x - exec $TERMINAL_NAME -x env TERM=xterm $LAUNCH_FILE "$@" + exec "$TERMINAL_NAME" -x env TERM=xterm $LAUNCH_FILE "$*" ;; gnome-terminal) # consumes all arguments after -- - exec $TERMINAL_NAME -- env TERM=xterm $LAUNCH_FILE "$@" + exec "$TERMINAL_NAME" -- env TERM=xterm $LAUNCH_FILE "$*" ;; kitty) # consumes all trailing arguments - exec $TERMINAL_NAME env TERM=xterm $LAUNCH_FILE "$@" + exec "$TERMINAL_NAME" env TERM=xterm $LAUNCH_FILE "$*" ;; *) |