add unit tests for metadata loading & validation (#285)

3 files changed, 223 insertions, 0 deletions

diff --git a/src/StardewModdingAPI.Tests/Framework/Sample.cs b/src/StardewModdingAPI.Tests/Framework/Sample.cs
new file mode 100644
index 00000000..10006f1e
--- /dev/null
+++ b/src/StardewModdingAPI.Tests/Framework/Sample.cs
@@ -0,0 +1,30 @@
+using System;
+
+namespace StardewModdingAPI.Tests.Framework
+{
+    /// <summary>Provides sample values for unit testing.</summary>
+    internal static class Sample
+    {
+        /*********
+        ** Properties
+        *********/
+        /// <summary>A random number generator.</summary>
+        private static readonly Random Random = new Random();
+
+
+        /*********
+        ** Properties
+        *********/
+        /// <summary>Get a sample string.</summary>
+        public static string String()
+        {
+            return Guid.NewGuid().ToString("N");
+        }
+
+        /// <summary>Get a sample integer.</summary>
+        public static int Int()
+        {
+            return Sample.Random.Next();
+        }
+    }
+}
diff --git a/src/StardewModdingAPI.Tests/ModResolverTests.cs b/src/StardewModdingAPI.Tests/ModResolverTests.cs
new file mode 100644
index 00000000..37e7c416
--- /dev/null
+++ b/src/StardewModdingAPI.Tests/ModResolverTests.cs
@@ -0,0 +1,191 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using Moq;
+using Newtonsoft.Json;
+using NUnit.Framework;
+using StardewModdingAPI.Framework.Models;
+using StardewModdingAPI.Framework.ModLoading;
+using StardewModdingAPI.Framework.Serialisation;
+using StardewModdingAPI.Tests.Framework;
+
+namespace StardewModdingAPI.Tests
+{
+    [TestFixture]
+    public class ModResolverTests
+    {
+        /*********
+        ** Unit tests
+        *********/
+        [Test(Description = "Assert that the resolver correctly reads manifest data from a randomised file.")]
+        public void ReadBasicManifest()
+        {
+            // create manifest data
+            IDictionary<string, object> originalDependency = new Dictionary<string, object>
+            {
+                [nameof(IManifestDependency.UniqueID)] = Sample.String()
+            };
+            IDictionary<string, object> original = new Dictionary<string, object>
+            {
+                [nameof(IManifest.Name)] = Sample.String(),
+                [nameof(IManifest.Author)] = Sample.String(),
+                [nameof(IManifest.Version)] = new SemanticVersion(Sample.Int(), Sample.Int(), Sample.Int(), Sample.String()),
+                [nameof(IManifest.Description)] = Sample.String(),
+                [nameof(IManifest.UniqueID)] = $"{Sample.String()}.{Sample.String()}",
+                [nameof(IManifest.EntryDll)] = $"{Sample.String()}.dll",
+                [nameof(IManifest.MinimumApiVersion)] = $"{Sample.Int()}.{Sample.Int()}-{Sample.String()}",
+                [nameof(IManifest.Dependencies)] = new[] { originalDependency },
+                ["ExtraString"] = Sample.String(),
+                ["ExtraInt"] = Sample.Int()
+            };
+
+            // write to filesystem
+            string rootFolder = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString("N"));
+            string modFolder = Path.Combine(rootFolder, Guid.NewGuid().ToString("N"));
+            string filename = Path.Combine(modFolder, "manifest.json");
+            Directory.CreateDirectory(modFolder);
+            File.WriteAllText(filename, JsonConvert.SerializeObject(original));
+
+            // act
+            IModMetadata[] mods = new ModResolver().ReadManifests(rootFolder, new JsonHelper(), new ModCompatibility[0]).ToArray();
+            IModMetadata mod = mods.FirstOrDefault();
+
+            // assert
+            Assert.AreEqual(1, mods.Length, 0, $"Expected to find one manifest, found {mods.Length} instead.");
+            Assert.IsNotNull(mod, "The loaded manifest shouldn't be null.");
+            Assert.AreEqual(null, mod.Compatibility, "The compatibility record should be null since we didn't provide one.");
+            Assert.AreEqual(modFolder, mod.DirectoryPath, "The directory path doesn't match.");
+            Assert.AreEqual(ModMetadataStatus.Found, mod.Status, "The status doesn't match.");
+            Assert.AreEqual(null, mod.Error, "The error should be null since parsing should have succeeded.");
+
+            Assert.AreEqual(original[nameof(IManifest.Name)], mod.DisplayName, "The display name should use the manifest name.");
+            Assert.AreEqual(original[nameof(IManifest.Name)], mod.Manifest.Name, "The manifest's name doesn't match.");
+            Assert.AreEqual(original[nameof(IManifest.Author)], mod.Manifest.Author, "The manifest's author doesn't match.");
+            Assert.AreEqual(original[nameof(IManifest.Description)], mod.Manifest.Description, "The manifest's description doesn't match.");
+            Assert.AreEqual(original[nameof(IManifest.EntryDll)], mod.Manifest.EntryDll, "The manifest's entry DLL doesn't match.");
+            Assert.AreEqual(original[nameof(IManifest.MinimumApiVersion)], mod.Manifest.MinimumApiVersion, "The manifest's minimum API version doesn't match.");
+            Assert.AreEqual(original[nameof(IManifest.Version)]?.ToString(), mod.Manifest.Version?.ToString(), "The manifest's version doesn't match.");
+
+            Assert.IsNotNull(mod.Manifest.ExtraFields, "The extra fields should not be null.");
+            Assert.AreEqual(2, mod.Manifest.ExtraFields.Count, "The extra fields should contain two values.");
+            Assert.AreEqual(original["ExtraString"], mod.Manifest.ExtraFields["ExtraString"], "The manifest's extra fields should contain an 'ExtraString' value.");
+            Assert.AreEqual(original["ExtraInt"], mod.Manifest.ExtraFields["ExtraInt"], "The manifest's extra fields should contain an 'ExtraInt' value.");
+
+            Assert.IsNotNull(mod.Manifest.Dependencies, "The dependencies field should not be null.");
+            Assert.AreEqual(1, mod.Manifest.Dependencies.Length, "The dependencies field should contain one value.");
+            Assert.AreEqual(originalDependency[nameof(IManifestDependency.UniqueID)], mod.Manifest.Dependencies[0].UniqueID, "The first dependency's unique ID doesn't match.");
+        }
+
+        [Test(Description = "Assert that validation skips manifests that have already failed without calling any other properties.")]
+        public void ValidateManifest_Skips_Failed()
+        {
+            // arrange
+            Mock<IModMetadata> mock = new Mock<IModMetadata>(MockBehavior.Strict);
+            mock.Setup(p => p.Status).Returns(ModMetadataStatus.Failed);
+
+            // act
+            new ModResolver().ValidateManifests(new[] { mock.Object }, apiVersion: new SemanticVersion("1.0"));
+
+            // assert
+            mock.VerifyGet(p => p.Status, Times.Once, "The validation did not check the manifest status.");
+        }
+
+        [Test(Description = "Assert that validation fails if the mod has 'assume broken' compatibility.")]
+        public void ValidateManifest_ModCompatibility_AssumeBroken_Fails()
+        {
+            // arrange
+            Mock<IModMetadata> mock = new Mock<IModMetadata>(MockBehavior.Strict);
+            mock.Setup(p => p.Status).Returns(ModMetadataStatus.Found);
+            mock.Setup(p => p.Compatibility).Returns(new ModCompatibility { Compatibility = ModCompatibilityType.AssumeBroken });
+            mock.Setup(p => p.SetStatus(ModMetadataStatus.Failed, It.IsAny<string>())).Returns(() => mock.Object);
+
+            // act
+            new ModResolver().ValidateManifests(new[] { mock.Object }, apiVersion: new SemanticVersion("1.0"));
+
+            // assert
+            mock.Verify(p => p.SetStatus(ModMetadataStatus.Failed, It.IsAny<string>()), Times.Once, "The validation did not fail the metadata.");
+        }
+
+        [Test(Description = "Assert that validation fails when the minimum API version is higher than the current SMAPI version.")]
+        public void ValidateManifest_MinimumApiVersion_Fails()
+        {
+            // arrange
+            Mock<IModMetadata> mock = new Mock<IModMetadata>(MockBehavior.Strict);
+            mock.Setup(p => p.Status).Returns(ModMetadataStatus.Found);
+            mock.Setup(p => p.Compatibility).Returns(() => null);
+            mock.Setup(p => p.Manifest).Returns(this.GetRandomManifest("1.1"));
+            mock.Setup(p => p.SetStatus(ModMetadataStatus.Failed, It.IsAny<string>())).Returns(() => mock.Object);
+
+            // act
+            new ModResolver().ValidateManifests(new[] { mock.Object }, apiVersion: new SemanticVersion("1.0"));
+
+            // assert
+            mock.Verify(p => p.SetStatus(ModMetadataStatus.Failed, It.IsAny<string>()), Times.Once, "The validation did not fail the metadata.");
+        }
+
+        [Test(Description = "Assert that validation fails when the manifest references a DLL that does not exist.")]
+        public void ValidateManifest_MissingEntryDLL_Fails()
+        {
+            // arrange
+            Mock<IModMetadata> mock = new Mock<IModMetadata>(MockBehavior.Strict);
+            mock.Setup(p => p.Status).Returns(ModMetadataStatus.Found);
+            mock.Setup(p => p.Compatibility).Returns(() => null);
+            mock.Setup(p => p.Manifest).Returns(this.GetRandomManifest());
+            mock.Setup(p => p.DirectoryPath).Returns(Path.GetTempPath());
+            mock.Setup(p => p.SetStatus(ModMetadataStatus.Failed, It.IsAny<string>())).Returns(() => mock.Object);
+
+            // act
+            new ModResolver().ValidateManifests(new[] { mock.Object }, apiVersion: new SemanticVersion("1.0"));
+
+            // assert
+            mock.Verify(p => p.SetStatus(ModMetadataStatus.Failed, It.IsAny<string>()), Times.Once, "The validation did not fail the metadata.");
+        }
+
+        [Test(Description = "Assert that validation fails when the manifest references a DLL that does not exist.")]
+        public void ValidateManifest_Valid_Passes()
+        {
+            // set up manifest
+            IManifest manifest = this.GetRandomManifest();
+
+            // create DLL
+            string modFolder = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString("N"));
+            Directory.CreateDirectory(modFolder);
+            File.WriteAllText(Path.Combine(modFolder, manifest.EntryDll), "");
+
+            // arrange
+            Mock<IModMetadata> mock = new Mock<IModMetadata>(MockBehavior.Strict);
+            mock.Setup(p => p.Status).Returns(ModMetadataStatus.Found);
+            mock.Setup(p => p.Compatibility).Returns(() => null);
+            mock.Setup(p => p.Manifest).Returns(manifest);
+            mock.Setup(p => p.DirectoryPath).Returns(modFolder);
+
+            // act
+            new ModResolver().ValidateManifests(new[] { mock.Object }, apiVersion: new SemanticVersion("1.0"));
+
+            // assert
+            // if Moq doesn't throw a method-not-setup exception, the validation didn't override the status.
+        }
+
+
+
+        /*********
+        ** Private methods
+        *********/
+        /// <summary>Get a randomised basic manifest.</summary>
+        /// <param name="minVersion">The minimum API version.</param>
+        private Manifest GetRandomManifest(string minVersion = null)
+        {
+            return new Manifest
+            {
+                Name = Sample.String(),
+                Author = Sample.String(),
+                Version = new SemanticVersion(Sample.Int(), Sample.Int(), Sample.Int(), Sample.String()),
+                Description = Sample.String(),
+                UniqueID = $"{Sample.String()}.{Sample.String()}",
+                EntryDll = $"{Sample.String()}.dll",
+                MinimumApiVersion = minVersion
+            };
+        }
+    }
+}
diff --git a/src/StardewModdingAPI.Tests/StardewModdingAPI.Tests.csproj b/src/StardewModdingAPI.Tests/StardewModdingAPI.Tests.csproj
index 78dbb281..c84adbd7 100644
--- a/src/StardewModdingAPI.Tests/StardewModdingAPI.Tests.csproj
+++ b/src/StardewModdingAPI.Tests/StardewModdingAPI.Tests.csproj
@@ -48,7 +48,9 @@
     <Compile Include="..\GlobalAssemblyInfo.cs">
       <Link>Properties\GlobalAssemblyInfo.cs</Link>
     </Compile>
+    <Compile Include="ModResolverTests.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
+    <Compile Include="Framework\Sample.cs" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />