diff options
| -rw-r--r-- | src/SMAPI.ModBuildConfig/DeployModTask.cs | 58 |
1 files changed, 32 insertions, 26 deletions
diff --git a/src/SMAPI.ModBuildConfig/DeployModTask.cs b/src/SMAPI.ModBuildConfig/DeployModTask.cs index 70761a2f..1581b282 100644 --- a/src/SMAPI.ModBuildConfig/DeployModTask.cs +++ b/src/SMAPI.ModBuildConfig/DeployModTask.cs @@ -79,38 +79,44 @@ namespace StardewModdingAPI.ModBuildConfig this.Log.LogMessage(MessageImportance.High, $"[mod build package] Handling build with options {string.Join(", ", properties)}"); } - // check if manifest file exists - FileInfo manifestFile = new(Path.Combine(this.ProjectDir, "manifest.json")); - if (!manifestFile.Exists) - { - this.Log.LogError("[mod build package] The mod does not have a manifest.json file."); - return false; - } + // skip if nothing to do + // (This must be checked before the manifest validation, to allow cases like unit test projects.) + if (!this.EnableModDeploy && !this.EnableModZip) + return true; - // check if the json is valid + // validate the manifest file Manifest manifest; - try { - new JsonHelper().ReadJsonFileIfExists(manifestFile.FullName, out manifest); - } - catch (JsonReaderException ex) - { - // log the inner exception, otherwise the message will be generic - Exception exToShow = ex.InnerException ?? ex; - this.Log.LogError($"[mod build package] Failed to parse manifest.json: {exToShow.Message}"); - return false; - } + // check if manifest file exists + FileInfo manifestFile = new(Path.Combine(this.ProjectDir, "manifest.json")); + if (!manifestFile.Exists) + { + this.Log.LogError("[mod build package] The mod does not have a manifest.json file."); + return false; + } - // validate the manifest's fields - if (!ManifestValidator.TryValidate(manifest, out string error)) - { - this.Log.LogError($"[mod build package] The mod manifest is invalid: {error}"); - return false; - } + // check if the json is valid + try + { + new JsonHelper().ReadJsonFileIfExists(manifestFile.FullName, out manifest); + } + catch (JsonReaderException ex) + { + // log the inner exception, otherwise the message will be generic + Exception exToShow = ex.InnerException ?? ex; + this.Log.LogError($"[mod build package] Failed to parse manifest.json: {exToShow.Message}"); + return false; + } - if (!this.EnableModDeploy && !this.EnableModZip) - return true; // nothing to do + // validate the manifest's fields + if (!ManifestValidator.TryValidate(manifest, out string error)) + { + this.Log.LogError($"[mod build package] The mod manifest is invalid: {error}"); + return false; + } + } + // deploy files try { // parse extra DLLs to bundle |