Merge pull request #683 from Emirlol/chocolate-factory-helper

Add chocolate factory helper

1 files changed, 11 insertions, 4 deletions

diff --git a/src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/ItemTooltip.java b/src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/ItemTooltip.java
index c6caaf41..8c083e25 100644
--- a/src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/ItemTooltip.java
+++ b/src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/ItemTooltip.java
@@ -2,7 +2,6 @@ package de.hysky.skyblocker.skyblock.item.tooltip;
 
 import com.google.gson.JsonObject;
 import de.hysky.skyblocker.SkyblockerMod;
-import de.hysky.skyblocker.config.SkyblockerConfig;
 import de.hysky.skyblocker.config.SkyblockerConfigManager;
 import de.hysky.skyblocker.config.configs.GeneralConfig;
 import de.hysky.skyblocker.skyblock.item.MuseumItemCache;
@@ -394,15 +393,23 @@ public class ItemTooltip {
         return message;
     }
 
+    //This is static to not create a new text object for each line in every item
+    private static final Text BUMPY_LINE = Text.literal("-----------------").formatted(Formatting.DARK_GRAY, Formatting.STRIKETHROUGH);
+
     private static void smoothenLines(List<Text> lines) {
         for (int i = 0; i < lines.size(); i++) {
-            Text line = lines.get(i);
-            if (line.getString().equals("-----------------")) {
-                lines.set(i, Text.literal("                    ").formatted(Formatting.DARK_GRAY, Formatting.STRIKETHROUGH, Formatting.BOLD));
+            List<Text> lineSiblings = lines.get(i).getSiblings();
+            //Compare the first sibling rather than the whole object as the style of the root object can change while visually staying the same
+            if (lineSiblings.size() == 1 && lineSiblings.getFirst().equals(BUMPY_LINE)) {
+                lines.set(i, createSmoothLine());
             }
         }
     }
 
+    public static Text createSmoothLine() {
+        return Text.literal("                    ").formatted(Formatting.DARK_GRAY, Formatting.STRIKETHROUGH, Formatting.BOLD);
+    }
+
     // If these options is true beforehand, the client will get first data of these options while loading.
     // After then, it will only fetch the data if it is on Skyblock.
     public static int minute = 0;