aboutsummaryrefslogtreecommitdiff
path: root/src/main/java
diff options
context:
space:
mode:
authorshedaniel <daniel@shedaniel.me>2021-01-26 11:34:52 +0800
committershedaniel <daniel@shedaniel.me>2021-01-26 11:34:52 +0800
commitb880d3f9d5784af60dbfec0b800216e99ca05f65 (patch)
treecee0a68ee2145c9b7a8caad47fd2d98ff8ff1538 /src/main/java
parent10f5eb0612d04b645f72f878ea00775f4986a443 (diff)
downloadarchitectury-loom-b880d3f9d5784af60dbfec0b800216e99ca05f65.tar.gz
architectury-loom-b880d3f9d5784af60dbfec0b800216e99ca05f65.tar.bz2
architectury-loom-b880d3f9d5784af60dbfec0b800216e99ca05f65.zip
Don't add tasks before run to idea anymore for arch
Diffstat (limited to 'src/main/java')
-rw-r--r--src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java37
-rw-r--r--src/main/java/net/fabricmc/loom/task/GenVsCodeProjectTask.java4
2 files changed, 8 insertions, 33 deletions
diff --git a/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java b/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java
index 4b60be99..fff6e9f3 100644
--- a/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java
+++ b/src/main/java/net/fabricmc/loom/configuration/ide/RunConfig.java
@@ -61,11 +61,12 @@ public class RunConfig {
public String configName;
public String eclipseProjectName;
public String ideaModuleName;
+ public String vscodeProjectName;
public String mainClass;
public String runDir;
public String vmArgs;
public String programArgs;
- public List<String> tasksBeforeRun = new ArrayList<>();
+ public List<String> vscodeBeforeRun = new ArrayList<>();
public final Map<String, String> envVariables = new HashMap<>();
public Element genRuns(Element doc) {
@@ -92,25 +93,6 @@ public class RunConfig {
}
}
- if (!tasksBeforeRun.isEmpty()) {
- Element methodElement = this.addXml(root, "method", ImmutableMap.of("v", "2"));
-
- this.addXml(methodElement, "option", ImmutableMap.of("name", "Make", "enabled", "true"));
-
- for (String s : tasksBeforeRun) {
- String project = s.substring(0, s.lastIndexOf(':'));
- String task = s.substring(s.lastIndexOf(':') + 1);
- this.addXml(methodElement, "option", ImmutableMap.<String, String>builder()
- .put("name", "Gradle.BeforeRunTask")
- .put("enabled", "true")
- .put("tasks", task)
- .put("externalProjectPath", project)
- .put("vmOptions", "")
- .put("scriptParameters", "")
- .build());
- }
- }
-
return root;
}
@@ -145,6 +127,7 @@ public class RunConfig {
runConfig.configName += extension.isRootProject() ? "" : " (" + project.getPath() + ")";
runConfig.eclipseProjectName = project.getExtensions().getByType(EclipseModel.class).getProject().getName();
runConfig.ideaModuleName = getIdeaModuleName(project);
+ runConfig.vscodeProjectName = extension.isRootProject() ? "" : project.getPath();
runConfig.runDir = "file://$PROJECT_DIR$/" + extension.runDir;
runConfig.vmArgs = "";
@@ -212,7 +195,7 @@ public class RunConfig {
populate(project, extension, ideaClient, "client");
ideaClient.vmArgs += getOSClientJVMArgs();
ideaClient.vmArgs += " -Dfabric.dli.main=" + getMainClass("client", extension);
- ideaClient.tasksBeforeRun = new ArrayList<>(extension.getTasksBeforeRun());
+ ideaClient.vscodeBeforeRun = new ArrayList<>(extension.getTasksBeforeRun());
return ideaClient;
}
@@ -225,7 +208,7 @@ public class RunConfig {
ideaServer.programArgs = "nogui ";
populate(project, extension, ideaServer, "server");
ideaServer.vmArgs += " -Dfabric.dli.main=" + getMainClass("server", extension);
- ideaServer.tasksBeforeRun = new ArrayList<>(extension.getTasksBeforeRun());
+ ideaServer.vscodeBeforeRun = new ArrayList<>(extension.getTasksBeforeRun());
return ideaServer;
}
@@ -269,16 +252,6 @@ public class RunConfig {
dummyConfig = dummyConfig.replace("%ENVS%", envs);
- StringBuilder tasksToRun = new StringBuilder();
-
- for (String s : tasksBeforeRun) {
- String project = s.substring(0, s.lastIndexOf(':'));
- String task = s.substring(s.lastIndexOf(':') + 1);
- tasksToRun.append(" <option name=\"Gradle.BeforeRunTask\" enabled=\"true\" tasks=\"").append(task).append("\" externalProjectPath=\"").append(project).append("\" vmOptions=\"\" scriptParameters=\"\" />");
- }
-
- dummyConfig = dummyConfig.replace("%TASKS%", tasksToRun.toString());
-
return dummyConfig;
}
diff --git a/src/main/java/net/fabricmc/loom/task/GenVsCodeProjectTask.java b/src/main/java/net/fabricmc/loom/task/GenVsCodeProjectTask.java
index 795adb44..1882975a 100644
--- a/src/main/java/net/fabricmc/loom/task/GenVsCodeProjectTask.java
+++ b/src/main/java/net/fabricmc/loom/task/GenVsCodeProjectTask.java
@@ -186,14 +186,16 @@ public class GenVsCodeProjectTask extends AbstractLoomTask {
public Map<String, String> env = new LinkedHashMap<>();
public transient List<String> tasksBeforeRun = new ArrayList<>();
public String preLaunchTask = null;
+ public String projectName = null;
VsCodeConfiguration(RunConfig runConfig) {
this.name = runConfig.configName;
this.mainClass = runConfig.mainClass;
this.vmArgs = runConfig.vmArgs;
this.args = runConfig.programArgs;
+ this.projectName = runConfig.vscodeProjectName;
this.env.putAll(runConfig.envVariables);
- this.tasksBeforeRun.addAll(runConfig.tasksBeforeRun);
+ this.tasksBeforeRun.addAll(runConfig.vscodeBeforeRun);
}
}