1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
|
/*
* Copyright 2014-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
*/
package superFields
import org.jetbrains.dokka.DokkaConfiguration
import org.jetbrains.dokka.base.testApi.testRunner.BaseAbstractTest
import org.jetbrains.dokka.links.DRI
import org.jetbrains.dokka.model.InheritedMember
import org.jetbrains.dokka.model.IsVar
import org.jetbrains.dokka.model.KotlinVisibility
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertNotNull
import kotlin.test.assertNull
import utils.JavaCode
@JavaCode
class DescriptorSuperPropertiesTest : BaseAbstractTest() {
private val commonTestConfiguration = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/")
analysisPlatform = "jvm"
name = "jvm"
}
}
}
@Test
fun `kotlin inheriting java should append only getter`() {
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| private int a = 1;
| public int getA() { return a; }
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
commonTestConfiguration
) {
this.documentablesTransformationStage = { module ->
val kotlinProperties = module.packages.single().classlikes.single { it.name == "B" }.properties
val property = kotlinProperties.single { it.name == "a" }
val propertyInheritedFrom = property.extra[InheritedMember]?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), propertyInheritedFrom)
assertNull(property.setter)
assertNotNull(property.getter)
val getterInheritedFrom = property.getter?.extra?.get(InheritedMember)?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), getterInheritedFrom)
assertNull(property.extra[IsVar])
}
}
}
@Test
fun `kotlin inheriting java should ignore setter lookalike for non accessible field`() {
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| private int a = 1;
|
| public void setA(int a) { this.a = a; }
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
commonTestConfiguration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "B" }
val property = testedClass.properties.firstOrNull { it.name == "a" }
assertNull(property, "Inherited property `a` should not be visible as it's not accessible")
val setterLookalike = testedClass.functions.firstOrNull { it.name == "setA" }
assertNotNull(setterLookalike) {
"Expected setA to be a regular function because field `a` is neither var nor val from Kotlin's " +
"interop perspective, it's not accessible."
}
}
}
}
@Test
fun `kotlin inheriting java should append getter and setter`() {
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| private int a = 1;
| public int getA() { return a; }
| public void setA(int a) { this.a = a; }
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
commonTestConfiguration
) {
documentablesMergingStage = { module ->
val kotlinProperties = module.packages.single().classlikes.single { it.name == "B" }.properties
val property = kotlinProperties.single { it.name == "a" }
property.extra[InheritedMember]?.inheritedFrom?.values?.single()?.run {
assertEquals(
DRI(packageName = "test", classNames = "A"),
this
)
}
val getter = property.getter
assertNotNull(getter)
assertEquals("getA", getter.name)
val getterInheritedFrom = getter.extra[InheritedMember]?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), getterInheritedFrom)
val setter = property.setter
assertNotNull(setter)
assertEquals("setA", setter.name)
val setterInheritedFrom = setter.extra[InheritedMember]?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), setterInheritedFrom)
assertNotNull(property.extra[IsVar])
}
}
}
@Test
fun `should have special getter and setter names for boolean property inherited from java`() {
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| private boolean bool = true;
| public boolean isBool() { return bool; }
| public void setBool(boolean bool) { this.bool = bool; }
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
commonTestConfiguration
) {
documentablesMergingStage = { module ->
val kotlinProperties = module.packages.single().classlikes.single { it.name == "B" }.properties
val boolProperty = kotlinProperties.single { it.name == "bool" }
val getter = boolProperty.getter
assertNotNull(getter)
assertEquals("isBool", getter.name)
val setter = boolProperty.setter
assertNotNull(setter)
assertEquals("setBool", setter.name)
assertNotNull(boolProperty.extra[IsVar])
}
}
}
// incorrect test https://github.com/Kotlin/dokka/issues/3128
@Test
fun `kotlin inheriting java should not append anything since field is public api`() {
val configuration = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/")
analysisPlatform = "jvm"
name = "jvm"
documentedVisibilities = setOf(
DokkaConfiguration.Visibility.PUBLIC,
DokkaConfiguration.Visibility.PROTECTED
)
}
}
}
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| protected int a = 1;
| public int getA() { return a; }
| public void setA(int a) { this.a = a; }
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "B" }
val property = testedClass.properties.single { it.name == "a" }
assertNull(property.getter)
assertNull(property.setter)
assertEquals(2, testedClass.functions.size)
assertEquals("getA", testedClass.functions[0].name)
assertEquals("setA", testedClass.functions[1].name)
val inheritedFrom = property.extra[InheritedMember]?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), inheritedFrom)
assertNotNull(property.extra[IsVar])
}
}
}
@Test
fun `should inherit property visibility from getter`() {
val configuration = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/")
analysisPlatform = "jvm"
name = "jvm"
documentedVisibilities = setOf(
DokkaConfiguration.Visibility.PUBLIC,
DokkaConfiguration.Visibility.PROTECTED
)
}
}
}
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| private int a = 1;
| protected int getA() { return a; }
| protected void setA(int a) { this.a = a; }
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "B" }
assertEquals(0, testedClass.functions.size)
val property = testedClass.properties.single { it.name == "a" }
assertNotNull(property.getter)
assertNotNull(property.setter)
val propertyVisibility = property.visibility.values.single()
assertEquals(KotlinVisibility.Protected, propertyVisibility)
val getterVisibility = property.getter?.visibility?.values?.single()
assertEquals(KotlinVisibility.Protected, getterVisibility)
val setterVisibility = property.setter?.visibility?.values?.single()
assertEquals(KotlinVisibility.Protected, setterVisibility)
val inheritedFrom = property.extra[InheritedMember]?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), inheritedFrom)
assertNotNull(property.extra[IsVar])
}
}
}
@Test // checking for mapping between kotlin and java visibility
fun `should resolve inherited java protected field as protected`() {
val configuration = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/")
analysisPlatform = "jvm"
name = "jvm"
documentedVisibilities = setOf(
DokkaConfiguration.Visibility.PUBLIC,
DokkaConfiguration.Visibility.PROTECTED
)
}
}
}
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| protected int protectedProperty = 0;
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "B" }
assertEquals(0, testedClass.functions.size)
val property = testedClass.properties.single { it.name == "protectedProperty" }
assertNull(property.getter)
assertNull(property.setter)
val propertyVisibility = property.visibility.values.single()
assertEquals(KotlinVisibility.Protected, propertyVisibility)
val inheritedFrom = property.extra[InheritedMember]?.inheritedFrom?.values?.single()
assertEquals(DRI(packageName = "test", classNames = "A"), inheritedFrom)
assertNotNull(property.extra[IsVar])
}
}
}
@Test
fun `should mark final property inherited from java as val`() {
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| public final int a = 1;
|}
|
|/src/test/B.kt
|package test
|class B : A {}
""".trimIndent(),
commonTestConfiguration
) {
documentablesMergingStage = { module ->
val kotlinProperties = module.packages.single().classlikes.single { it.name == "B" }.properties
val property = kotlinProperties.single { it.name == "a" }
assertNull(property.extra[IsVar])
}
}
}
}
|
