aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoel Spilker <r.spilker@gmail.com>2012-01-09 21:45:43 +0100
committerRoel Spilker <r.spilker@gmail.com>2012-01-09 21:45:43 +0100
commit2ddf708b37f32e5c618927dd3e7dc8ac0e2e18d4 (patch)
tree09eee8b3889fbd711e35b43be8cd37a666d20b74
parent101adef99c670cd05951a1ef66c1530b4234c1ca (diff)
downloadlombok-2ddf708b37f32e5c618927dd3e7dc8ac0e2e18d4.tar.gz
lombok-2ddf708b37f32e5c618927dd3e7dc8ac0e2e18d4.tar.bz2
lombok-2ddf708b37f32e5c618927dd3e7dc8ac0e2e18d4.zip
The line about lombok added to the about dialog wasn't working for all eclipse releases and ways to boot up eclipse. Now it does. Also added an item for this in the changelog.
-rw-r--r--doc/changelog.markdown1
-rw-r--r--src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java4
-rw-r--r--src/eclipseAgent/lombok/eclipse/agent/PatchFixes.java5
3 files changed, 5 insertions, 5 deletions
diff --git a/doc/changelog.markdown b/doc/changelog.markdown
index a0e6d0a6..9a0856ee 100644
--- a/doc/changelog.markdown
+++ b/doc/changelog.markdown
@@ -5,6 +5,7 @@ Lombok Changelog
* REGRESSION: 0.10.6 causes ClassNotFoundErrors when using ecj (and thus, play framework, gwt, etc). [Issue #320](http://code.google.com/p/projectlombok/issues/detail?id=320)
* BUGFIX: Eclipse refactoring Extract Interface was broken when using lombok annotation to generate methods. [Issue #86](http://code.google.com/p/projectlombok/issues/detail?id=86)
* BUGFIX: Eclipse action Sort Members was broken when using lombok annotation to generate methods or fields. [Issue #265](http://code.google.com/p/projectlombok/issues/detail?id=265)
+* ENHANCEMENT: Lombok now adds a line to the Eclipse About dialog about itself.
### v0.10.6 (December 19th, 2011)
* PERFORMANCE: Performance issues (memory leaks) when using lombok in netbeans, introduced in 0.10, have been fixed. [Issue #242](http://code.google.com/p/projectlombok/issues/detail?id=242)
diff --git a/src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java b/src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java
index 220aa9e2..a721b468 100644
--- a/src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java
+++ b/src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java
@@ -158,8 +158,8 @@ public class EclipsePatcher extends Agent {
*/
sm.addScript(ScriptBuilder.wrapReturnValue()
.target(new MethodTarget("org.eclipse.core.internal.runtime.Product", "getProperty", "java.lang.String", "java.lang.String"))
- .wrapMethod(new Hook("lombok.eclipse.agent.PatchFixes", "addLombokNotesToEclipseAboutDialog", "java.lang.String", "java.lang.String", "org.eclipse.core.internal.runtime.Product", "java.lang.String"))
- .request(StackRequest.RETURN_VALUE, StackRequest.THIS, StackRequest.PARAM1)
+ .wrapMethod(new Hook("lombok.eclipse.agent.PatchFixes", "addLombokNotesToEclipseAboutDialog", "java.lang.String", "java.lang.String", "java.lang.String"))
+ .request(StackRequest.RETURN_VALUE, StackRequest.PARAM1)
.transplant().build());
}
diff --git a/src/eclipseAgent/lombok/eclipse/agent/PatchFixes.java b/src/eclipseAgent/lombok/eclipse/agent/PatchFixes.java
index 8103806b..53d60bde 100644
--- a/src/eclipseAgent/lombok/eclipse/agent/PatchFixes.java
+++ b/src/eclipseAgent/lombok/eclipse/agent/PatchFixes.java
@@ -34,7 +34,6 @@ import lombok.core.DiagnosticsReceiver;
import lombok.core.PostCompiler;
import lombok.core.Version;
-import org.eclipse.core.internal.runtime.Product;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.jdt.core.IAnnotatable;
import org.eclipse.jdt.core.IAnnotation;
@@ -50,8 +49,8 @@ import org.eclipse.jdt.internal.core.dom.rewrite.TokenScanner;
import org.eclipse.jdt.internal.corext.refactoring.structure.ASTNodeSearchUtil;
public class PatchFixes {
- public static String addLombokNotesToEclipseAboutDialog(String origReturnValue, Product product, String key) {
- if ("Eclipse SDK".equals(product.getName()) && "aboutText".equals(key)) {
+ public static String addLombokNotesToEclipseAboutDialog(String origReturnValue, String key) {
+ if ("aboutText".equals(key)) {
return origReturnValue + "\n\nLombok " + Version.getFullVersion() + " is installed. http://projectlombok.org/";
}