aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReinier Zwitserloot <reinier@zwitserloot.com>2014-02-10 21:56:35 +0100
committerReinier Zwitserloot <reinier@zwitserloot.com>2014-02-10 21:56:35 +0100
commitd78135180c8f9e9f4c6c361679759d3eacb63be3 (patch)
tree6450085e10d9dfd9dc901d8cc837727d7372bf09
parentdb24fd42c5732856a894dbdc5e1827ea31792757 (diff)
downloadlombok-d78135180c8f9e9f4c6c361679759d3eacb63be3.tar.gz
lombok-d78135180c8f9e9f4c6c361679759d3eacb63be3.tar.bz2
lombok-d78135180c8f9e9f4c6c361679759d3eacb63be3.zip
[deps] Updated eclipse deps to 3.9 tree. This also enables testing java7 features on ecj.
[Log] updated naming for @Log (topic= instead of mchmulder's 'value').
-rw-r--r--AUTHORS2
-rw-r--r--buildScripts/ivy-repo/org.eclipse.custom-core.runtime-3.9.0.xml14
-rw-r--r--buildScripts/ivy-repo/org.eclipse.custom-ecj-4.3.1.xml14
-rw-r--r--buildScripts/ivy-repo/org.eclipse.custom-equinox.common-3.6.200.xml14
-rw-r--r--buildScripts/ivy-repo/org.eclipse.custom-jdt.core-3.9.1.xml14
-rw-r--r--buildScripts/ivy-repo/org.eclipse.custom-jdt.ui-3.9.1.xml14
-rw-r--r--buildScripts/ivy-repo/org.eclipse.custom-osgi-3.9.0.xml14
-rw-r--r--buildScripts/ivy.xml12
-rw-r--r--src/core/lombok/eclipse/handlers/HandleLog.java12
-rw-r--r--src/core/lombok/extern/apachecommons/CommonsLog.java2
-rw-r--r--src/core/lombok/extern/java/Log.java2
-rw-r--r--src/core/lombok/extern/log4j/Log4j.java2
-rw-r--r--src/core/lombok/extern/log4j/Log4j2.java2
-rw-r--r--src/core/lombok/extern/slf4j/Slf4j.java2
-rw-r--r--src/core/lombok/extern/slf4j/XSlf4j.java2
-rw-r--r--src/core/lombok/javac/handlers/HandleLog.java14
-rw-r--r--test/core/src/lombok/AbstractRunTests.java13
-rw-r--r--test/core/src/lombok/RunTestsViaEcj.java3
-rw-r--r--test/transform/resource/after-ecj/LoggerCommons.java2
-rw-r--r--test/transform/resource/after-ecj/LoggerJul.java2
-rw-r--r--test/transform/resource/after-ecj/LoggerLog4j.java2
-rw-r--r--test/transform/resource/after-ecj/LoggerLog4j2.java2
-rw-r--r--test/transform/resource/after-ecj/LoggerSlf4j.java2
-rw-r--r--test/transform/resource/after-ecj/LoggerXSlf4j.java2
-rw-r--r--test/transform/resource/after-ecj/NonNullWithSneakyThrows.java3
-rw-r--r--test/transform/resource/after-ecj/SneakyThrowsMultiple.java18
-rw-r--r--test/transform/resource/after-ecj/SneakyThrowsPlain.java12
-rw-r--r--test/transform/resource/after-ecj/SneakyThrowsSingle.java9
-rw-r--r--test/transform/resource/after-ecj/ValComplex.java2
-rw-r--r--test/transform/resource/after-ecj/ValInTryWithResources.java14
-rw-r--r--test/transform/resource/after-ecj/ValLessSimple.java3
-rw-r--r--test/transform/resource/before/LoggerCommons.java2
-rw-r--r--test/transform/resource/before/LoggerJul.java2
-rw-r--r--test/transform/resource/before/LoggerLog4j.java2
-rw-r--r--test/transform/resource/before/LoggerLog4j2.java2
-rw-r--r--test/transform/resource/before/LoggerSlf4j.java2
-rw-r--r--test/transform/resource/before/LoggerXSlf4j.java2
-rw-r--r--usage_examples/LogExample_pre.jpage2
-rw-r--r--website/features/Log.html7
39 files changed, 182 insertions, 64 deletions
diff --git a/AUTHORS b/AUTHORS
index 32369734..f79ca61e 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -1,12 +1,12 @@
Lombok contributors in alphabetical order:
Jappe van der Hel <jappe.vanderhel@gmail.com>
+Maarten Mulders <mthmulders@users.noreply.github.com>
Philipp Eichhorn <peichhor@web.de>
Reinier Zwitserloot <reinier@zwitserloot.com>
Robbert Jan Grootjans <grootjans@gmail.com>
Roel Spilker <r.spilker@gmail.com>
Sander Koning <askoning@gmail.com>
Taiki Sugawara <buzz.taiki@gmail.com>
-Maarten Mulders <mthmulders@users.noreply.github.com>
By adding your name to this list, you grant full and irrevocable copyright and patent indemnity to Project Lombok and all use of Project Lombok, and you certify that you have the right to do so for all commits you add to Project Lombok.
diff --git a/buildScripts/ivy-repo/org.eclipse.custom-core.runtime-3.9.0.xml b/buildScripts/ivy-repo/org.eclipse.custom-core.runtime-3.9.0.xml
new file mode 100644
index 00000000..45d6a9c3
--- /dev/null
+++ b/buildScripts/ivy-repo/org.eclipse.custom-core.runtime-3.9.0.xml
@@ -0,0 +1,14 @@
+<ivy-module version="2.0">
+ <info organisation="org.eclipse.custom" module="core.runtime" revision="3.9.0" publication="20130326125500">
+ <license name="Eclipse Public Licence v1.0" url="http://www.eclipse.org/org/documents/epl-v10.php" />
+ <description homepage="http://www.eclipse.org/eclipse/" />
+ </info>
+ <configurations>
+ <conf name="default" />
+ <conf name="sources" />
+ </configurations>
+ <publications>
+ <artifact conf="default" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.core.runtime_3.9.0.v20130326-1255.jar" />
+ <artifact type="zip" conf="sources" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.core.runtime_3.9.0.v20130326-1255-sources.jar" />
+ </publications>
+</ivy-module>
diff --git a/buildScripts/ivy-repo/org.eclipse.custom-ecj-4.3.1.xml b/buildScripts/ivy-repo/org.eclipse.custom-ecj-4.3.1.xml
new file mode 100644
index 00000000..4ebfc8a4
--- /dev/null
+++ b/buildScripts/ivy-repo/org.eclipse.custom-ecj-4.3.1.xml
@@ -0,0 +1,14 @@
+<ivy-module version="2.0">
+ <info organisation="org.eclipse.custom" module="ecj" revision="4.3.1" publication="20140210214200">
+ <license name="Eclipse Public Licence v1.0" url="http://www.eclipse.org/org/documents/epl-v10.php" />
+ <description homepage="http://www.eclipse.org/eclipse/" />
+ </info>
+ <configurations>
+ <conf name="default" />
+ <conf name="sources" />
+ </configurations>
+ <publications>
+ <artifact conf="default" url="http://projectlombok.org/ivyrepo/eclipse/ecj-4.3.1.jar" />
+ <artifact type="zip" conf="sources" url="http://projectlombok.org/ivyrepo/eclipse/ecjsrc-4.3.1.zip" />
+ </publications>
+</ivy-module>
diff --git a/buildScripts/ivy-repo/org.eclipse.custom-equinox.common-3.6.200.xml b/buildScripts/ivy-repo/org.eclipse.custom-equinox.common-3.6.200.xml
new file mode 100644
index 00000000..74f7a705
--- /dev/null
+++ b/buildScripts/ivy-repo/org.eclipse.custom-equinox.common-3.6.200.xml
@@ -0,0 +1,14 @@
+<ivy-module version="2.0">
+ <info organisation="org.eclipse.custom" module="equinox.common" revision="3.6.200" publication="20130402150500">
+ <license name="Eclipse Public Licence v1.0" url="http://www.eclipse.org/org/documents/epl-v10.php" />
+ <description homepage="http://www.eclipse.org/eclipse/" />
+ </info>
+ <configurations>
+ <conf name="default" />
+ <conf name="sources" />
+ </configurations>
+ <publications>
+ <artifact conf="default" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.equinox.common_3.6.200.v20130402-1505.jar" />
+ <artifact type="zip" conf="sources" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.equinox.common_3.6.200.v20130402-1505-sources.jar" />
+ </publications>
+</ivy-module> \ No newline at end of file
diff --git a/buildScripts/ivy-repo/org.eclipse.custom-jdt.core-3.9.1.xml b/buildScripts/ivy-repo/org.eclipse.custom-jdt.core-3.9.1.xml
new file mode 100644
index 00000000..0e7c5363
--- /dev/null
+++ b/buildScripts/ivy-repo/org.eclipse.custom-jdt.core-3.9.1.xml
@@ -0,0 +1,14 @@
+<ivy-module version="2.0">
+ <info organisation="org.eclipse.custom" module="jdt.core" revision="3.9.1" publication="20130905083700">
+ <license name="Eclipse Public Licence v1.0" url="http://www.eclipse.org/org/documents/epl-v10.php" />
+ <description homepage="http://www.eclipse.org/eclipse/" />
+ </info>
+ <configurations>
+ <conf name="default" />
+ <conf name="sources" />
+ </configurations>
+ <publications>
+ <artifact conf="default" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.jdt.core_3.9.1.v20130905-0837.jar" />
+ <artifact type="zip" conf="sources" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.jdt.core_3.9.1.v20130905-0837-sources.jar" />
+ </publications>
+</ivy-module>
diff --git a/buildScripts/ivy-repo/org.eclipse.custom-jdt.ui-3.9.1.xml b/buildScripts/ivy-repo/org.eclipse.custom-jdt.ui-3.9.1.xml
new file mode 100644
index 00000000..0577ee8a
--- /dev/null
+++ b/buildScripts/ivy-repo/org.eclipse.custom-jdt.ui-3.9.1.xml
@@ -0,0 +1,14 @@
+<ivy-module version="2.0">
+ <info organisation="org.eclipse.custom" module="jdt.ui" revision="3.9.1" publication="20130820142700">
+ <license name="Eclipse Public Licence v1.0" url="http://www.eclipse.org/org/documents/epl-v10.php" />
+ <description homepage="http://www.eclipse.org/eclipse/" />
+ </info>
+ <configurations>
+ <conf name="default" />
+ <conf name="sources" />
+ </configurations>
+ <publications>
+ <artifact conf="default" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.jdt.ui_3.9.1.v20130820-1427.jar" />
+ <artifact type="zip" conf="sources" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.jdt.ui_3.9.1.v20130820-1427-sources.jar" />
+ </publications>
+</ivy-module>
diff --git a/buildScripts/ivy-repo/org.eclipse.custom-osgi-3.9.0.xml b/buildScripts/ivy-repo/org.eclipse.custom-osgi-3.9.0.xml
new file mode 100644
index 00000000..247d76de
--- /dev/null
+++ b/buildScripts/ivy-repo/org.eclipse.custom-osgi-3.9.0.xml
@@ -0,0 +1,14 @@
+<ivy-module version="2.0">
+ <info organisation="org.eclipse.custom" module="osgi" revision="3.9.0" publication="20130529171000">
+ <license name="Eclipse Public Licence v1.0" url="http://www.eclipse.org/org/documents/epl-v10.php" />
+ <description homepage="http://www.eclipse.org/eclipse/" />
+ </info>
+ <configurations>
+ <conf name="default" />
+ <conf name="sources" />
+ </configurations>
+ <publications>
+ <artifact conf="default" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.osgi_3.9.0.v20130529-1710.jar" />
+ <artifact type="zip" conf="sources" url="http://projectlombok.org/ivyrepo/eclipse/org.eclipse.osgi_3.9.0.v20130529-1710-sources.jar" />
+ </publications>
+</ivy-module>
diff --git a/buildScripts/ivy.xml b/buildScripts/ivy.xml
index bcf5ecd1..eed69ac3 100644
--- a/buildScripts/ivy.xml
+++ b/buildScripts/ivy.xml
@@ -35,17 +35,17 @@
<dependency org="net.java.openjdk.custom" name="javac6" rev="1.6.0.18" conf="javac6->runtime; contrib->sources" />
<dependency org="net.java.openjdk.custom" name="javac7" rev="1.7.0" conf="javac7->runtime; contrib->sources" />
- <dependency org="org.eclipse.custom" name="ecj" rev="3.6.2" conf="ecj->default; contrib->sources" />
+ <dependency org="org.eclipse.custom" name="ecj" rev="4.3.1" conf="ecj->default; contrib->sources" />
<dependency org="netbeans.org" name="boot" rev="6.8beta" conf="netbeansBuild->build" />
<dependency org="netbeans.org" name="openide.modules" rev="6.8beta" conf="netbeansBuild->build" />
<dependency org="netbeans.org" name="openide.util" rev="6.8beta" conf="netbeansBuild->build" />
<dependency org="netbeans.org" name="modules.java.source" rev="6.8beta" conf="netbeansBuild->build" />
- <dependency org="org.eclipse.custom" name="core.runtime" rev="3.6.0" conf="eclipseBuild->default; contrib->sources" />
- <dependency org="org.eclipse.custom" name="jdt.core" rev="3.6.0" conf="eclipseBuild->default; contrib->sources" />
- <dependency org="org.eclipse.custom" name="jdt.ui" rev="3.6.0" conf="eclipseBuild->default; contrib->sources" />
- <dependency org="org.eclipse.custom" name="equinox.common" rev="3.6.0" conf="eclipseBuild->default; contrib->sources" />
- <dependency org="org.eclipse.custom" name="osgi" rev="3.6.0" conf="eclipseBuild->default; contrib->sources" />
+ <dependency org="org.eclipse.custom" name="core.runtime" rev="3.9.0" conf="eclipseBuild->default; contrib->sources" />
+ <dependency org="org.eclipse.custom" name="jdt.core" rev="3.9.1" conf="eclipseBuild->default; contrib->sources" />
+ <dependency org="org.eclipse.custom" name="jdt.ui" rev="3.9.1" conf="eclipseBuild->default; contrib->sources" />
+ <dependency org="org.eclipse.custom" name="equinox.common" rev="3.6.200" conf="eclipseBuild->default; contrib->sources" />
+ <dependency org="org.eclipse.custom" name="osgi" rev="3.9.0" conf="eclipseBuild->default; contrib->sources" />
</dependencies>
</ivy-module>
diff --git a/src/core/lombok/eclipse/handlers/HandleLog.java b/src/core/lombok/eclipse/handlers/HandleLog.java
index 56160b39..cf1e8018 100644
--- a/src/core/lombok/eclipse/handlers/HandleLog.java
+++ b/src/core/lombok/eclipse/handlers/HandleLog.java
@@ -161,7 +161,7 @@ public class HandleLog {
@ProviderFor(EclipseAnnotationHandler.class)
public static class HandleCommonsLog extends EclipseAnnotationHandler<lombok.extern.apachecommons.CommonsLog> {
@Override public void handle(AnnotationValues<lombok.extern.apachecommons.CommonsLog> annotation, Annotation source, EclipseNode annotationNode) {
- processAnnotation(LoggingFramework.COMMONS, annotation, source, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.COMMONS, annotation, source, annotationNode, annotation.getInstance().topic());
}
}
@@ -171,7 +171,7 @@ public class HandleLog {
@ProviderFor(EclipseAnnotationHandler.class)
public static class HandleJulLog extends EclipseAnnotationHandler<lombok.extern.java.Log> {
@Override public void handle(AnnotationValues<lombok.extern.java.Log> annotation, Annotation source, EclipseNode annotationNode) {
- processAnnotation(LoggingFramework.JUL, annotation, source, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.JUL, annotation, source, annotationNode, annotation.getInstance().topic());
}
}
@@ -181,7 +181,7 @@ public class HandleLog {
@ProviderFor(EclipseAnnotationHandler.class)
public static class HandleLog4jLog extends EclipseAnnotationHandler<lombok.extern.log4j.Log4j> {
@Override public void handle(AnnotationValues<lombok.extern.log4j.Log4j> annotation, Annotation source, EclipseNode annotationNode) {
- processAnnotation(LoggingFramework.LOG4J, annotation, source, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.LOG4J, annotation, source, annotationNode, annotation.getInstance().topic());
}
}
@@ -191,7 +191,7 @@ public class HandleLog {
@ProviderFor(EclipseAnnotationHandler.class)
public static class HandleLog4j2Log extends EclipseAnnotationHandler<lombok.extern.log4j.Log4j2> {
@Override public void handle(AnnotationValues<lombok.extern.log4j.Log4j2> annotation, Annotation source, EclipseNode annotationNode) {
- processAnnotation(LoggingFramework.LOG4J2, annotation, source, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.LOG4J2, annotation, source, annotationNode, annotation.getInstance().topic());
}
}
@@ -201,7 +201,7 @@ public class HandleLog {
@ProviderFor(EclipseAnnotationHandler.class)
public static class HandleSlf4jLog extends EclipseAnnotationHandler<lombok.extern.slf4j.Slf4j> {
@Override public void handle(AnnotationValues<lombok.extern.slf4j.Slf4j> annotation, Annotation source, EclipseNode annotationNode) {
- processAnnotation(LoggingFramework.SLF4J, annotation, source, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.SLF4J, annotation, source, annotationNode, annotation.getInstance().topic());
}
}
@@ -211,7 +211,7 @@ public class HandleLog {
@ProviderFor(EclipseAnnotationHandler.class)
public static class HandleXSlf4jLog extends EclipseAnnotationHandler<lombok.extern.slf4j.XSlf4j> {
@Override public void handle(AnnotationValues<lombok.extern.slf4j.XSlf4j> annotation, Annotation source, EclipseNode annotationNode) {
- processAnnotation(LoggingFramework.XSLF4J, annotation, source, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.XSLF4J, annotation, source, annotationNode, annotation.getInstance().topic());
}
}
diff --git a/src/core/lombok/extern/apachecommons/CommonsLog.java b/src/core/lombok/extern/apachecommons/CommonsLog.java
index 34ac0fe6..2e31edf7 100644
--- a/src/core/lombok/extern/apachecommons/CommonsLog.java
+++ b/src/core/lombok/extern/apachecommons/CommonsLog.java
@@ -62,5 +62,5 @@ public @interface CommonsLog {
/**
* Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
*/
- String value() default "";
+ String topic() default "";
} \ No newline at end of file
diff --git a/src/core/lombok/extern/java/Log.java b/src/core/lombok/extern/java/Log.java
index dfa2e2aa..f8cbf03f 100644
--- a/src/core/lombok/extern/java/Log.java
+++ b/src/core/lombok/extern/java/Log.java
@@ -61,5 +61,5 @@ public @interface Log {
/**
* Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
*/
- String value() default "";
+ String topic() default "";
} \ No newline at end of file
diff --git a/src/core/lombok/extern/log4j/Log4j.java b/src/core/lombok/extern/log4j/Log4j.java
index 0fe74599..d3164047 100644
--- a/src/core/lombok/extern/log4j/Log4j.java
+++ b/src/core/lombok/extern/log4j/Log4j.java
@@ -62,5 +62,5 @@ public @interface Log4j {
/**
* Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
*/
- String value() default "";
+ String topic() default "";
} \ No newline at end of file
diff --git a/src/core/lombok/extern/log4j/Log4j2.java b/src/core/lombok/extern/log4j/Log4j2.java
index 96fab793..0267d98c 100644
--- a/src/core/lombok/extern/log4j/Log4j2.java
+++ b/src/core/lombok/extern/log4j/Log4j2.java
@@ -62,5 +62,5 @@ public @interface Log4j2 {
/**
* Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
*/
- String value() default "";
+ String topic() default "";
} \ No newline at end of file
diff --git a/src/core/lombok/extern/slf4j/Slf4j.java b/src/core/lombok/extern/slf4j/Slf4j.java
index c4495990..5d6e7d8c 100644
--- a/src/core/lombok/extern/slf4j/Slf4j.java
+++ b/src/core/lombok/extern/slf4j/Slf4j.java
@@ -60,5 +60,5 @@ public @interface Slf4j {
/**
* Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
*/
- String value() default "";
+ String topic() default "";
}
diff --git a/src/core/lombok/extern/slf4j/XSlf4j.java b/src/core/lombok/extern/slf4j/XSlf4j.java
index 306057f0..0f2efe26 100644
--- a/src/core/lombok/extern/slf4j/XSlf4j.java
+++ b/src/core/lombok/extern/slf4j/XSlf4j.java
@@ -60,5 +60,5 @@ public @interface XSlf4j {
/**
* Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
*/
- String value() default "";
+ String topic() default "";
}
diff --git a/src/core/lombok/javac/handlers/HandleLog.java b/src/core/lombok/javac/handlers/HandleLog.java
index 12b0cb5c..36f3bbb5 100644
--- a/src/core/lombok/javac/handlers/HandleLog.java
+++ b/src/core/lombok/javac/handlers/HandleLog.java
@@ -25,9 +25,7 @@ import static lombok.javac.handlers.JavacHandlerUtil.*;
import java.lang.annotation.Annotation;
-import lombok.NoArgsConstructor;
import lombok.core.AnnotationValues;
-import lombok.extern.slf4j.Slf4j;
import lombok.javac.JavacAnnotationHandler;
import lombok.javac.JavacNode;
import lombok.javac.JavacTreeMaker;
@@ -111,7 +109,7 @@ public class HandleLog {
@ProviderFor(JavacAnnotationHandler.class)
public static class HandleCommonsLog extends JavacAnnotationHandler<lombok.extern.apachecommons.CommonsLog> {
@Override public void handle(AnnotationValues<lombok.extern.apachecommons.CommonsLog> annotation, JCAnnotation ast, JavacNode annotationNode) {
- processAnnotation(LoggingFramework.COMMONS, annotation, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.COMMONS, annotation, annotationNode, annotation.getInstance().topic());
}
}
@@ -121,7 +119,7 @@ public class HandleLog {
@ProviderFor(JavacAnnotationHandler.class)
public static class HandleJulLog extends JavacAnnotationHandler<lombok.extern.java.Log> {
@Override public void handle(AnnotationValues<lombok.extern.java.Log> annotation, JCAnnotation ast, JavacNode annotationNode) {
- processAnnotation(LoggingFramework.JUL, annotation, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.JUL, annotation, annotationNode, annotation.getInstance().topic());
}
}
@@ -131,7 +129,7 @@ public class HandleLog {
@ProviderFor(JavacAnnotationHandler.class)
public static class HandleLog4jLog extends JavacAnnotationHandler<lombok.extern.log4j.Log4j> {
@Override public void handle(AnnotationValues<lombok.extern.log4j.Log4j> annotation, JCAnnotation ast, JavacNode annotationNode) {
- processAnnotation(LoggingFramework.LOG4J, annotation, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.LOG4J, annotation, annotationNode, annotation.getInstance().topic());
}
}
@@ -141,7 +139,7 @@ public class HandleLog {
@ProviderFor(JavacAnnotationHandler.class)
public static class HandleLog4j2Log extends JavacAnnotationHandler<lombok.extern.log4j.Log4j2> {
@Override public void handle(AnnotationValues<lombok.extern.log4j.Log4j2> annotation, JCAnnotation ast, JavacNode annotationNode) {
- processAnnotation(LoggingFramework.LOG4J2, annotation, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.LOG4J2, annotation, annotationNode, annotation.getInstance().topic());
}
}
@@ -151,7 +149,7 @@ public class HandleLog {
@ProviderFor(JavacAnnotationHandler.class)
public static class HandleSlf4jLog extends JavacAnnotationHandler<lombok.extern.slf4j.Slf4j> {
@Override public void handle(AnnotationValues<lombok.extern.slf4j.Slf4j> annotation, JCAnnotation ast, JavacNode annotationNode) {
- processAnnotation(LoggingFramework.SLF4J, annotation, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.SLF4J, annotation, annotationNode, annotation.getInstance().topic());
}
}
@@ -161,7 +159,7 @@ public class HandleLog {
@ProviderFor(JavacAnnotationHandler.class)
public static class HandleXSlf4jLog extends JavacAnnotationHandler<lombok.extern.slf4j.XSlf4j> {
@Override public void handle(AnnotationValues<lombok.extern.slf4j.XSlf4j> annotation, JCAnnotation ast, JavacNode annotationNode) {
- processAnnotation(LoggingFramework.XSLF4J, annotation, annotationNode, annotation.getInstance().value());
+ processAnnotation(LoggingFramework.XSLF4J, annotation, annotationNode, annotation.getInstance().topic());
}
}
diff --git a/test/core/src/lombok/AbstractRunTests.java b/test/core/src/lombok/AbstractRunTests.java
index 2f3f0988..e84aec0d 100644
--- a/test/core/src/lombok/AbstractRunTests.java
+++ b/test/core/src/lombok/AbstractRunTests.java
@@ -225,8 +225,8 @@ public abstract class AbstractRunTests {
actualLines = removeBlanks(actualLines);
int size = Math.min(expectedLines.length, actualLines.length);
for (int i = 0; i < size; i++) {
- String expected = expectedLines[i];
- String actual = actualLines[i];
+ String expected = trimRight(expectedLines[i]);
+ String actual = trimRight(actualLines[i]);
assertEquals(String.format("Difference in %s on line %d", name, i + 1), expected, actual);
}
if (expectedLines.length > actualLines.length) {
@@ -237,6 +237,15 @@ public abstract class AbstractRunTests {
}
}
+ private static String trimRight(String in) {
+ int endIdx = in.length() - 1;
+ while (endIdx > -1 && Character.isWhitespace(in.charAt(endIdx))) {
+ endIdx--;
+ }
+
+ return in.substring(0, endIdx);
+ }
+
private static String[] removeBlanks(String[] in) {
List<String> out = new ArrayList<String>();
for (String s : in) {
diff --git a/test/core/src/lombok/RunTestsViaEcj.java b/test/core/src/lombok/RunTestsViaEcj.java
index 586c124a..4f3e2794 100644
--- a/test/core/src/lombok/RunTestsViaEcj.java
+++ b/test/core/src/lombok/RunTestsViaEcj.java
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010-2013 The Project Lombok Authors.
+ * Copyright (C) 2010-2014 The Project Lombok Authors.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
@@ -70,6 +70,7 @@ public class RunTestsViaEcj extends AbstractRunTests {
warnings.put(CompilerOptions.OPTION_ReportUnusedLabel, "ignore");
warnings.put(CompilerOptions.OPTION_ReportUnusedImport, "ignore");
warnings.put(CompilerOptions.OPTION_ReportUnusedPrivateMember, "ignore");
+ warnings.put(CompilerOptions.OPTION_Source, CompilerOptions.VERSION_1_7);
options.set(warnings);
return options;
}
diff --git a/test/transform/resource/after-ecj/LoggerCommons.java b/test/transform/resource/after-ecj/LoggerCommons.java
index 50d07a14..df102a12 100644
--- a/test/transform/resource/after-ecj/LoggerCommons.java
+++ b/test/transform/resource/after-ecj/LoggerCommons.java
@@ -15,7 +15,7 @@ import lombok.extern.apachecommons.CommonsLog;
super();
}
}
-@CommonsLog("DifferentName") class LoggerCommonsWithDifferentName {
+@CommonsLog(topic = "DifferentName") class LoggerCommonsWithDifferentName {
private static final org.apache.commons.logging.Log log = org.apache.commons.logging.LogFactory.getLog("DifferentName");
<clinit>() {
}
diff --git a/test/transform/resource/after-ecj/LoggerJul.java b/test/transform/resource/after-ecj/LoggerJul.java
index 3aa8181d..8aa4f59a 100644
--- a/test/transform/resource/after-ecj/LoggerJul.java
+++ b/test/transform/resource/after-ecj/LoggerJul.java
@@ -15,7 +15,7 @@ import lombok.extern.java.Log;
super();
}
}
-@Log("DifferentName") class LoggerJulWithDifferentName {
+@Log(topic = "DifferentName") class LoggerJulWithDifferentName {
private static final java.util.logging.Logger log = java.util.logging.Logger.getLogger("DifferentName");
<clinit>() {
}
diff --git a/test/transform/resource/after-ecj/LoggerLog4j.java b/test/transform/resource/after-ecj/LoggerLog4j.java
index a6c52d61..948412e2 100644
--- a/test/transform/resource/after-ecj/LoggerLog4j.java
+++ b/test/transform/resource/after-ecj/LoggerLog4j.java
@@ -15,7 +15,7 @@ import lombok.extern.log4j.Log4j;
super();
}
}
-@Log4j("DifferentName") class LoggerLog4jWithDifferentName {
+@Log4j(topic = "DifferentName") class LoggerLog4jWithDifferentName {
private static final org.apache.log4j.Logger log = org.apache.log4j.Logger.getLogger("DifferentName");
<clinit>() {
}
diff --git a/test/transform/resource/after-ecj/LoggerLog4j2.java b/test/transform/resource/after-ecj/LoggerLog4j2.java
index 3243ef2d..c2fcd428 100644
--- a/test/transform/resource/after-ecj/LoggerLog4j2.java
+++ b/test/transform/resource/after-ecj/LoggerLog4j2.java
@@ -15,7 +15,7 @@ import lombok.extern.log4j.Log4j2;
super();
}
}
-@Log4j2("DifferentName") class LoggerLog4j2WithDifferentName {
+@Log4j2(topic = "DifferentName") class LoggerLog4j2WithDifferentName {
private static final org.apache.logging.log4j.Logger log = org.apache.logging.log4j.LogManager.getLogger("DifferentName");
<clinit>() {
}
diff --git a/test/transform/resource/after-ecj/LoggerSlf4j.java b/test/transform/resource/after-ecj/LoggerSlf4j.java
index a34f85d7..9c5405cb 100644
--- a/test/transform/resource/after-ecj/LoggerSlf4j.java
+++ b/test/transform/resource/after-ecj/LoggerSlf4j.java
@@ -29,7 +29,7 @@ class LoggerSlf4jOuter {
}
}
-@Slf4j("DifferentLogger") class LoggerSlf4jWithDifferentLoggerName {
+@Slf4j(topic = "DifferentLogger") class LoggerSlf4jWithDifferentLoggerName {
private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger("DifferentLogger");
<clinit>() {
}
diff --git a/test/transform/resource/after-ecj/LoggerXSlf4j.java b/test/transform/resource/after-ecj/LoggerXSlf4j.java
index 4cd4cb94..916859a4 100644
--- a/test/transform/resource/after-ecj/LoggerXSlf4j.java
+++ b/test/transform/resource/after-ecj/LoggerXSlf4j.java
@@ -15,7 +15,7 @@ import lombok.extern.slf4j.XSlf4j;
super();
}
}
-@XSlf4j("DifferentName") class LoggerXSlf4jWithDifferentName {
+@XSlf4j(topic = "DifferentName") class LoggerXSlf4jWithDifferentName {
private static final org.slf4j.ext.XLogger log = org.slf4j.ext.XLoggerFactory.getXLogger("DifferentName");
<clinit>() {
}
diff --git a/test/transform/resource/after-ecj/NonNullWithSneakyThrows.java b/test/transform/resource/after-ecj/NonNullWithSneakyThrows.java
index fac8dcdd..1a57be29 100644
--- a/test/transform/resource/after-ecj/NonNullWithSneakyThrows.java
+++ b/