Fixed issue 164. Oh yes. Party time!

skipPrintAst was a singleton global, so, yes, thread race issues all over the place.

1 files changed, 0 insertions, 23 deletions

diff --git a/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java b/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java
index 45d58df3..6dbdfb18 100644
--- a/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java
+++ b/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java
@@ -25,7 +25,6 @@ import static lombok.eclipse.Eclipse.*;
 
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
-import org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration;
 import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -38,7 +37,6 @@ import lombok.Getter;
 import lombok.Lombok;
 import lombok.core.AnnotationValues;
 import lombok.core.AST.Kind;
-import lombok.core.debug.DebugSnapshotStore;
 import lombok.core.handlers.TransformationsUtil;
 import lombok.eclipse.Eclipse;
 import lombok.eclipse.EclipseNode;
@@ -451,27 +449,6 @@ public class EclipseHandlerUtil {
 		method.annotations = createSuppressWarningsAll(method, method.annotations);
 		TypeDeclaration parent = (TypeDeclaration) type.get();
 		
-		if (parent.scope != null && method.scope == null) {
-			// We think this means heisenbug #164 is about to happen later in some other worker thread.
-			// To improve our ability to figure out what the heck is going on, let's generate a log so we can ask those who stumble on this about it,
-			// and thus see a far more useful stack trace.
-			boolean report = true;
-			for (StackTraceElement elem : Thread.currentThread().getStackTrace()) {
-				// We intentionally hook into the middle of ClassScope filling in BlockScopes for PatchDelegate,
-				// meaning that will trigger a false positive. Detect it and do not report the occurence of #164 if so.
-				if ("lombok.eclipse.agent.PatchDelegate".equals(elem.getClassName())) {
-					report = false;
-					break;
-				}
-			}
-			
-			if (report) {
-				CompilationUnitDeclaration cud = (CompilationUnitDeclaration) type.top().get();
-				String logFileLocation = DebugSnapshotStore.INSTANCE.print(cud, "Printing: injecting whilst scope is already built.");
-				Eclipse.warning("We believe you may have stumbled on issue 164. Please upload file " + logFileLocation + " to: http://code.google.com/p/projectlombok/issues/detail?id=164", new Throwable());
-			}
-		}
-		
 		if (parent.methods == null) {
 			parent.methods = new AbstractMethodDeclaration[1];
 			parent.methods[0] = method;