[configuration] Merge branch 'master' as we work on configuration.

* Conflict due to adding topic() feature to logger in master, and 'field name' feature in config branch.
* master has since updated to shiny new eclipse dep versions and the 'ant eclipseForDebugging' feature, but this branch added deps. Addressed that.
* Renamed 'loggerCategory' to 'loggerTopic'. I know, that wasn't exactly right to do in a merge, but, there you have it.
* Test infrastructure changed in configuration branch, and tests had been added in master branch.

Conflicts:
	build.xml
	buildScripts/ivy.xml
	src/core/lombok/eclipse/handlers/HandleLog.java
	src/core/lombok/extern/apachecommons/CommonsLog.java
	src/core/lombok/extern/java/Log.java
	src/core/lombok/extern/log4j/Log4j.java
	src/core/lombok/extern/log4j/Log4j2.java
	src/core/lombok/javac/handlers/HandleLog.java
	test/transform/resource/after-ecj/ValInTryWithResources.java

1 files changed, 10 insertions, 5 deletions

diff --git a/src/core/lombok/javac/LombokOptions.java b/src/core/lombok/javac/LombokOptions.java
index 60d0ce5e..034cbafd 100644
--- a/src/core/lombok/javac/LombokOptions.java
+++ b/src/core/lombok/javac/LombokOptions.java
@@ -25,13 +25,14 @@ import java.util.HashSet;
 import java.util.Set;
 
 import lombok.delombok.FormatPreferences;
+import lombok.delombok.LombokOptionsFactory;
 
 import com.sun.tools.javac.tree.JCTree.JCCompilationUnit;
 import com.sun.tools.javac.util.Context;
 import com.sun.tools.javac.util.Options;
 
 public abstract class LombokOptions extends Options {
-	private boolean deleteLombokAnnotations = true;
+	private boolean deleteLombokAnnotations = false;
 	private final Set<JCCompilationUnit> changed = new HashSet<JCCompilationUnit>();
 	private FormatPreferences formatPreferences = new FormatPreferences(null);
 	
@@ -48,13 +49,13 @@ public abstract class LombokOptions extends Options {
 	}
 	
 	public static void markChanged(Context context, JCCompilationUnit ast) {
-		Options options = context.get(Options.optionsKey);
-		if (options instanceof LombokOptions) ((LombokOptions) options).changed.add(ast);
+		LombokOptions options = LombokOptionsFactory.getDelombokOptions(context);
+		options.changed.add(ast);
 	}
 	
 	public static boolean shouldDeleteLombokAnnotations(Context context) {
-		Options options = context.get(Options.optionsKey);
-		return (options instanceof LombokOptions) && ((LombokOptions) options).deleteLombokAnnotations;
+		LombokOptions options = LombokOptionsFactory.getDelombokOptions(context);
+		return options.deleteLombokAnnotations;
 	}
 	
 	protected LombokOptions(Context context) {
@@ -62,4 +63,8 @@ public abstract class LombokOptions extends Options {
 	}
 	
 	public abstract void putJavacOption(String optionName, String value);
+	
+	public void deleteLombokAnnotations() {
+		this.deleteLombokAnnotations = true;
+	}
 }