diff options
| author | Andre Brait <andrebrait@gmail.com> | 2020-07-14 12:25:25 +0200 |
|---|---|---|
| committer | Roel Spilker <r.spilker@gmail.com> | 2020-09-24 22:25:15 +0200 |
| commit | c91a7dc8cac69f7324d38057206d2d027a2f22ac (patch) | |
| tree | a897542235437b719b3914acd47594b5d1b78cba /src/core/lombok | |
| parent | a4866a8d23466813d30bf9102ba26cb3fecebc47 (diff) | |
| download | lombok-c91a7dc8cac69f7324d38057206d2d027a2f22ac.tar.gz lombok-c91a7dc8cac69f7324d38057206d2d027a2f22ac.tar.bz2 lombok-c91a7dc8cac69f7324d38057206d2d027a2f22ac.zip | |
Undo unnecessary change, add TODO
Diffstat (limited to 'src/core/lombok')
| -rwxr-xr-x | src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java | 1 | ||||
| -rw-r--r-- | src/core/lombok/javac/handlers/HandleEqualsAndHashCode.java | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java b/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java index 4c5f3083..cf735dee 100755 --- a/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java +++ b/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java @@ -272,6 +272,7 @@ public class HandleEqualsAndHashCode extends EclipseAnnotationHandler<EqualsAndH method.returnType = TypeReference.baseTypeReference(TypeIds.T_int, 0); setGeneratedBy(method.returnType, source); Annotation overrideAnnotation = makeMarkerAnnotation(TypeConstants.JAVA_LANG_OVERRIDE, source); + // TODO: maybe not add this annotation if cacheHashCode is true because we *do* modify a field if (getCheckerFrameworkVersion(type).generateSideEffectFree()) { method.annotations = new Annotation[] { overrideAnnotation, generateNamedAnnotation(source, CheckerFrameworkVersion.NAME__SIDE_EFFECT_FREE) }; } else { diff --git a/src/core/lombok/javac/handlers/HandleEqualsAndHashCode.java b/src/core/lombok/javac/handlers/HandleEqualsAndHashCode.java index 063fb780..5b5595b5 100644 --- a/src/core/lombok/javac/handlers/HandleEqualsAndHashCode.java +++ b/src/core/lombok/javac/handlers/HandleEqualsAndHashCode.java @@ -110,7 +110,7 @@ public class HandleEqualsAndHashCode extends JavacAnnotationHandler<EqualsAndHas Boolean doNotUseGettersConfiguration = typeNode.getAst().readConfiguration(ConfigurationKeys.EQUALS_AND_HASH_CODE_DO_NOT_USE_GETTERS); FieldAccess access = doNotUseGettersConfiguration == null || !doNotUseGettersConfiguration ? FieldAccess.GETTER : FieldAccess.PREFER_FIELD; - + java.util.List<Included<JavacNode, EqualsAndHashCode.Include>> members = InclusionExclusionUtils.handleEqualsAndHashCodeMarking(typeNode, null, null); generateMethods(typeNode, source, members, null, false, false, access, List.<JCAnnotation>nil()); |