diff options
author | Jan Rieke <rieke@subshell.com> | 2018-08-16 17:58:05 +0200 |
---|---|---|
committer | Jan Rieke <rieke@subshell.com> | 2018-08-16 17:58:05 +0200 |
commit | 31aef5219d6e6a39afe5dfa5d888bddd6e942e25 (patch) | |
tree | 911c13bbaf052ae0ac08c0c386f27fe69d180b3e /src/core | |
parent | 46837d6d8be26cea9d0b8cf2959866ac308cbf2d (diff) | |
download | lombok-31aef5219d6e6a39afe5dfa5d888bddd6e942e25.tar.gz lombok-31aef5219d6e6a39afe5dfa5d888bddd6e942e25.tar.bz2 lombok-31aef5219d6e6a39afe5dfa5d888bddd6e942e25.zip |
only assign value once so that final fields work (javac)
Diffstat (limited to 'src/core')
-rw-r--r-- | src/core/lombok/javac/handlers/HandleSuperBuilder.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/core/lombok/javac/handlers/HandleSuperBuilder.java b/src/core/lombok/javac/handlers/HandleSuperBuilder.java index cc295beb..aaf94dd8 100644 --- a/src/core/lombok/javac/handlers/HandleSuperBuilder.java +++ b/src/core/lombok/javac/handlers/HandleSuperBuilder.java @@ -420,14 +420,15 @@ public class HandleSuperBuilder extends JavacAnnotationHandler<SuperBuilder> { JCFieldAccess fieldInThis = maker.Select(maker.Ident(typeNode.toName("this")), bfd.rawName); JCStatement assign = maker.Exec(maker.Assign(fieldInThis, rhs)); - statements.append(assign); - // In case of @Builder.Default, set the value to the default if it was NOT set in the builder. + // In case of @Builder.Default, set the value to the default if it was not set in the builder. if (bfd.nameOfSetFlag != null) { JCFieldAccess setField = maker.Select(maker.Ident(builderVariableName), bfd.nameOfSetFlag); fieldInThis = maker.Select(maker.Ident(typeNode.toName("this")), bfd.rawName); JCAssign assignDefault = maker.Assign(fieldInThis, maker.Apply(typeParameterNames(maker, ((JCClassDecl) typeNode.get()).typarams), maker.Select(maker.Ident(((JCClassDecl) typeNode.get()).name), bfd.nameOfDefaultProvider), List.<JCExpression>nil())); - statements.append(maker.If(maker.Unary(CTC_NOT, setField), maker.Exec(assignDefault), null)); + statements.append(maker.If(setField, assign, maker.Exec(assignDefault))); + } else { + statements.append(assign); } List<JCAnnotation> nonNulls = findAnnotations(bfd.originalFieldNode, NON_NULL_PATTERN); |