diff options
| author | Jan Rieke <rieke@subshell.com> | 2018-09-24 16:46:00 +0200 | 
|---|---|---|
| committer | Jan Rieke <rieke@subshell.com> | 2018-09-24 16:46:00 +0200 | 
| commit | b5648976b6501bdf755814d8d8a096c33f6997ec (patch) | |
| tree | aafe939cdc6fdda41719deb42f03c77934cb5209 /src/core | |
| parent | fd4c9d4bff6e75b30a3ee247edafaabc6888a691 (diff) | |
| parent | aee4e76d864e01b5d453409e703ad54852fa57bb (diff) | |
| download | lombok-b5648976b6501bdf755814d8d8a096c33f6997ec.tar.gz lombok-b5648976b6501bdf755814d8d8a096c33f6997ec.tar.bz2 lombok-b5648976b6501bdf755814d8d8a096c33f6997ec.zip | |
Merge remote-tracking branch 'upstream/master' into superToBuilder
Diffstat (limited to 'src/core')
25 files changed, 359 insertions, 87 deletions
| diff --git a/src/core/lombok/ConfigurationKeys.java b/src/core/lombok/ConfigurationKeys.java index 184ded27..2cca27fa 100644 --- a/src/core/lombok/ConfigurationKeys.java +++ b/src/core/lombok/ConfigurationKeys.java @@ -27,6 +27,7 @@ import lombok.core.configuration.CallSuperType;  import lombok.core.configuration.ConfigurationKey;  import lombok.core.configuration.FlagUsageType;  import lombok.core.configuration.NullCheckExceptionType; +import lombok.core.configuration.TypeName;  /**   * A container class containing all lombok configuration keys that do not belong to a specific annotation. @@ -563,4 +564,12 @@ public class ConfigurationKeys {  	 * If set to {@code true}, no further {@code lombok.config} files will be checked.  	 */  	public static final ConfigurationKey<Boolean> STOP_BUBBLING = new ConfigurationKey<Boolean>("config.stopBubbling", "Tell the configuration system it should stop looking for other configuration files (default: false).") {}; + +	/** +	 * lombok configuration: {@code lombok.copyableAnnotations} += <TypeName: fully-qualified annotation class name>. +	 * +	 * Copy these annotations to getters, setters, withers, builder-setters, etc. +	 */ +	public static final ConfigurationKey<List<TypeName>> COPYABLE_ANNOTATIONS = new ConfigurationKey<List<TypeName>>("lombok.copyableAnnotations", "Copy these annotations to getters, setters, withers, builder-setters, etc.") {}; +  } diff --git a/src/core/lombok/NonNull.java b/src/core/lombok/NonNull.java index 58538583..caf6ed05 100644 --- a/src/core/lombok/NonNull.java +++ b/src/core/lombok/NonNull.java @@ -41,7 +41,7 @@ import java.lang.annotation.Target;   * this annotation will <strong>be deleted</strong> from the lombok package. If the need to update an import statement scares   * you, you should use your own annotation named {@code @NonNull} instead of this one.   */ -@Target({ElementType.FIELD, ElementType.METHOD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE}) +@Target({ElementType.FIELD, ElementType.METHOD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})  @Retention(RetentionPolicy.CLASS)  @Documented  public @interface NonNull { diff --git a/src/core/lombok/core/TypeLibrary.java b/src/core/lombok/core/TypeLibrary.java index cdaf7a70..ceaf5f90 100644 --- a/src/core/lombok/core/TypeLibrary.java +++ b/src/core/lombok/core/TypeLibrary.java @@ -45,6 +45,12 @@ public class TypeLibrary {  		qualified = null;  	} +	public TypeLibrary(TypeLibrary parent) { +		unqualifiedToQualifiedMap = new HashMap<String, String>(); +		unqualified = null; +		qualified = null; +	} +	  	public void lock() {  		this.locked = true;  	} diff --git a/src/core/lombok/core/handlers/HandlerUtil.java b/src/core/lombok/core/handlers/HandlerUtil.java index 0d64c550..296b70b4 100644 --- a/src/core/lombok/core/handlers/HandlerUtil.java +++ b/src/core/lombok/core/handlers/HandlerUtil.java @@ -27,7 +27,6 @@ import java.util.Collections;  import java.util.HashSet;  import java.util.List;  import java.util.Set; -import java.util.regex.Pattern;  import lombok.AllArgsConstructor;  import lombok.ConfigurationKeys; @@ -77,6 +76,33 @@ public class HandlerUtil {  		return 43;  	} +	public static final List<String> NONNULL_ANNOTATIONS, BASE_COPYABLE_ANNOTATIONS; +	static { +		NONNULL_ANNOTATIONS = Collections.unmodifiableList(Arrays.asList(new String[] { +			"lombok.NonNull", +			"javax.annotation.Nonnull", +			"edu.umd.cs.findbugs.annotations.NonNull", +			"org.jetbrains.annotations.NotNull", +			"android.support.annotation.NonNull", +			"org.eclipse.jdt.annotation.NonNull", +		})); +		BASE_COPYABLE_ANNOTATIONS = Collections.unmodifiableList(Arrays.asList(new String[] { +			"lombok.NonNull", +			"javax.annotation.Nonnull", +			"edu.umd.cs.findbugs.annotations.NonNull", +			"org.jetbrains.annotations.NotNull", +			"android.support.annotation.NonNull", +			"org.eclipse.jdt.annotation.NonNull", +			"javax.annotation.Nullable", +			"javax.annotation.CheckForNull", +			"edu.umd.cs.findbugs.annotations.UnknownNullness", +			"edu.umd.cs.findbugs.annotations.Nullable", +			"org.jetbrains.annotations.Nullable", +			"android.support.annotation.Nullable", +			"org.eclipse.jdt.annotation.Nullable", +		})); +	} +	  	/** Checks if the given name is a valid identifier.  	 *   	 * If it is, this returns {@code true} and does nothing else. @@ -222,12 +248,6 @@ public class HandlerUtil {  	        constructor and the implied starts-out-as-null state that goes with it is in fact mandatory' which happens with javax.validation.constraints.NotNull.  	        Various problems with spring have also been reported. See issue #287, issue #271, and issue #43. */ -	/** Matches the simple part of any annotation that lombok considers as indicative of NonNull status. */ -	public static final Pattern NON_NULL_PATTERN = Pattern.compile("^(?:nonnull)$", Pattern.CASE_INSENSITIVE); -	 -	/** Matches the simple part of any annotation that lombok considers as indicative of Nullable status. */ -	public static final Pattern NULLABLE_PATTERN = Pattern.compile("^(?:nullable|checkfornull)$", Pattern.CASE_INSENSITIVE); -	  	public static final String DEFAULT_EXCEPTION_FOR_NON_NULL = "java.lang.NullPointerException";  	/** diff --git a/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java b/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java index 1e29764a..5d582aad 100644 --- a/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java +++ b/src/core/lombok/eclipse/handlers/EclipseHandlerUtil.java @@ -48,6 +48,7 @@ import lombok.core.AnnotationValues;  import lombok.core.AnnotationValues.AnnotationValue;  import lombok.core.TypeResolver;  import lombok.core.configuration.NullCheckExceptionType; +import lombok.core.configuration.TypeName;  import lombok.core.debug.ProblemReporter;  import lombok.core.handlers.HandlerUtil;  import lombok.eclipse.Eclipse; @@ -448,6 +449,24 @@ public class EclipseHandlerUtil {  		return out;  	} +	public static Annotation[] getTypeUseAnnotations(TypeReference from) { +		Annotation[][] a; +		try { +			a = (Annotation[][]) reflect(TYPE_REFERENCE__ANNOTATIONS, from); +		} catch (Exception e) { +			return null; +		} +		if (a == null) return null; +		Annotation[] b = a[a.length - 1]; +		return b.length == 0 ? null : b; +	} +	 +	public static void removeTypeUseAnnotations(TypeReference from) { +		try { +			reflectSet(TYPE_REFERENCE__ANNOTATIONS, from, null); +		} catch (Exception ignore) {} +	} +	  	public static TypeReference namePlusTypeParamsToTypeReference(char[] typeName, TypeParameter[] params, long p) {  		if (params != null && params.length > 0) {  			TypeReference[] refs = new TypeReference[params.length]; @@ -672,6 +691,47 @@ public class EclipseHandlerUtil {  		}  	} +	public static boolean hasNonNullAnnotations(EclipseNode node) { +		AbstractVariableDeclaration avd = (AbstractVariableDeclaration) node.get(); +		if (avd.annotations == null) return false; +		for (Annotation annotation : avd.annotations) { +			TypeReference typeRef = annotation.type; +			if (typeRef != null && typeRef.getTypeName() != null) { +				for (String bn : NONNULL_ANNOTATIONS) if (typeMatches(bn, node, typeRef)) return true; +			} +		} +		return false; +	} +	 +	private static final Annotation[] EMPTY_ANNOTATIONS_ARRAY = new Annotation[0]; +	 +	/** +	 * Searches the given field node for annotations and returns each one that is 'copyable' (either via configuration or from the base list). +	 */ +	public static Annotation[] findCopyableAnnotations(EclipseNode node) { +		AbstractVariableDeclaration avd = (AbstractVariableDeclaration) node.get(); +		if (avd.annotations == null) return EMPTY_ANNOTATIONS_ARRAY; +		List<Annotation> result = new ArrayList<Annotation>(); +		List<TypeName> configuredCopyable = node.getAst().readConfiguration(ConfigurationKeys.COPYABLE_ANNOTATIONS); +		 +		for (Annotation annotation : avd.annotations) { +			TypeReference typeRef = annotation.type; +			boolean match = false; +			if (typeRef != null && typeRef.getTypeName() != null) { +				for (TypeName cn : configuredCopyable) if (typeMatches(cn.toString(), node, typeRef)) { +					result.add(annotation); +					match = true; +					break; +				} +				if (!match) for (String bn : BASE_COPYABLE_ANNOTATIONS) if (typeMatches(bn, node, typeRef)) { +					result.add(annotation); +					break; +				} +			} +		} +		return result.toArray(EMPTY_ANNOTATIONS_ARRAY); +	} +	  	/**  	 * Checks if the provided annotation type is likely to be the intended type for the given annotation node.  	 *  diff --git a/src/core/lombok/eclipse/handlers/HandleBuilder.java b/src/core/lombok/eclipse/handlers/HandleBuilder.java index 3b10483d..f6e0a175 100644 --- a/src/core/lombok/eclipse/handlers/HandleBuilder.java +++ b/src/core/lombok/eclipse/handlers/HandleBuilder.java @@ -106,6 +106,7 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {  	}  	public static class BuilderFieldData { +		Annotation[] annotations;  		TypeReference type;  		char[] rawName;  		char[] name; @@ -199,9 +200,12 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {  				EclipseNode isDefault = findAnnotation(Builder.Default.class, fieldNode);  				boolean isFinal = ((fd.modifiers & ClassFileConstants.AccFinal) != 0) || (valuePresent && !hasAnnotation(NonFinal.class, fieldNode)); +				Annotation[] copyableAnnotations = findCopyableAnnotations(fieldNode); +				  				BuilderFieldData bfd = new BuilderFieldData();  				bfd.rawName = fieldNode.getName().toCharArray();  				bfd.name = removePrefixFromField(fieldNode); +				bfd.annotations = copyAnnotations(fd, copyableAnnotations);  				bfd.type = fd.type;  				bfd.singularData = getSingularData(fieldNode, ast);  				bfd.originalFieldNode = fieldNode; @@ -374,8 +378,12 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {  				if (param.getKind() != Kind.ARGUMENT) continue;  				BuilderFieldData bfd = new BuilderFieldData();  				Argument arg = (Argument) param.get(); +				 +				Annotation[] copyableAnnotations = findCopyableAnnotations(param); +				  				bfd.rawName = arg.name;  				bfd.name = arg.name; +				bfd.annotations = copyAnnotations(arg, copyableAnnotations);  				bfd.type = arg.type;  				bfd.singularData = getSingularData(param, ast);  				bfd.originalFieldNode = param; @@ -744,13 +752,13 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {  	public void makeSetterMethodsForBuilder(EclipseNode builderType, BuilderFieldData bfd, EclipseNode sourceNode, boolean fluent, boolean chain) {  		boolean deprecate = isFieldDeprecated(bfd.originalFieldNode);  		if (bfd.singularData == null || bfd.singularData.getSingularizer() == null) { -			makeSimpleSetterMethodForBuilder(builderType, deprecate, bfd.createdFields.get(0), bfd.nameOfSetFlag, sourceNode, fluent, chain); +			makeSimpleSetterMethodForBuilder(builderType, deprecate, bfd.createdFields.get(0), bfd.nameOfSetFlag, sourceNode, fluent, chain, bfd.annotations);  		} else {  			bfd.singularData.getSingularizer().generateMethods(bfd.singularData, deprecate, builderType, fluent, chain);  		}  	} -	private void makeSimpleSetterMethodForBuilder(EclipseNode builderType, boolean deprecate, EclipseNode fieldNode, char[] nameOfSetFlag, EclipseNode sourceNode, boolean fluent, boolean chain) { +	private void makeSimpleSetterMethodForBuilder(EclipseNode builderType, boolean deprecate, EclipseNode fieldNode, char[] nameOfSetFlag, EclipseNode sourceNode, boolean fluent, boolean chain, Annotation[] annotations) {  		TypeDeclaration td = (TypeDeclaration) builderType.get();  		AbstractMethodDeclaration[] existing = td.methods;  		if (existing == null) existing = EMPTY; @@ -767,7 +775,7 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {  		String setterName = fluent ? fieldNode.getName() : HandlerUtil.buildAccessorName("set", fieldNode.getName());  		MethodDeclaration setter = HandleSetter.createSetter(td, deprecate, fieldNode, setterName, nameOfSetFlag, chain, ClassFileConstants.AccPublic, -			sourceNode, Collections.<Annotation>emptyList(), Collections.<Annotation>emptyList()); +			sourceNode, Collections.<Annotation>emptyList(), annotations != null ? Arrays.asList(copyAnnotations(sourceNode.get(), annotations)) : Collections.<Annotation>emptyList());  		injectMethod(builderType, setter);  	} diff --git a/src/core/lombok/eclipse/handlers/HandleConstructor.java b/src/core/lombok/eclipse/handlers/HandleConstructor.java index 6c7b4caf..cb07115a 100644 --- a/src/core/lombok/eclipse/handlers/HandleConstructor.java +++ b/src/core/lombok/eclipse/handlers/HandleConstructor.java @@ -139,7 +139,7 @@ public class HandleConstructor {  			FieldDeclaration fieldDecl = (FieldDeclaration) child.get();  			if (!filterField(fieldDecl)) continue;  			boolean isFinal = (fieldDecl.modifiers & ClassFileConstants.AccFinal) != 0; -			boolean isNonNull = nullMarked && findAnnotations(fieldDecl, NON_NULL_PATTERN).length != 0; +			boolean isNonNull = nullMarked && hasNonNullAnnotations(child);  			if ((isFinal || isNonNull) && fieldDecl.initialization == null) fields.add(child);  		}  		return fields; @@ -403,13 +403,12 @@ public class HandleConstructor {  			assigns.add(assignment);  			long fieldPos = (((long) field.sourceStart) << 32) | field.sourceEnd;  			Argument parameter = new Argument(fieldName, fieldPos, copyType(field.type, source), Modifier.FINAL); -			Annotation[] nonNulls = findAnnotations(field, NON_NULL_PATTERN); -			Annotation[] nullables = findAnnotations(field, NULLABLE_PATTERN); -			if (nonNulls.length != 0) { +			Annotation[] copyableAnnotations = findCopyableAnnotations(fieldNode); +			if (hasNonNullAnnotations(fieldNode)) {  				Statement nullCheck = generateNullCheck(parameter, sourceNode);  				if (nullCheck != null) nullChecks.add(nullCheck);  			} -			parameter.annotations = copyAnnotations(source, nonNulls, nullables); +			parameter.annotations = copyAnnotations(source, copyableAnnotations);  			params.add(parameter);  		} @@ -546,7 +545,7 @@ public class HandleConstructor {  			assigns.add(nameRef);  			Argument parameter = new Argument(field.name, fieldPos, copyType(field.type, source), Modifier.FINAL); -			parameter.annotations = copyAnnotations(source, findAnnotations(field, NON_NULL_PATTERN), findAnnotations(field, NULLABLE_PATTERN)); +			parameter.annotations = copyAnnotations(source, findCopyableAnnotations(fieldNode));  			params.add(parameter);  		} diff --git a/src/core/lombok/eclipse/handlers/HandleGetter.java b/src/core/lombok/eclipse/handlers/HandleGetter.java index d0c2cc23..7d3fe62f 100644 --- a/src/core/lombok/eclipse/handlers/HandleGetter.java +++ b/src/core/lombok/eclipse/handlers/HandleGetter.java @@ -236,8 +236,6 @@ public class HandleGetter extends EclipseAnnotationHandler<Getter> {  	}  	public MethodDeclaration createGetter(TypeDeclaration parent, EclipseNode fieldNode, String name, int modifier, ASTNode source, boolean lazy, List<Annotation> onMethod) { -		FieldDeclaration field = (FieldDeclaration) fieldNode.get(); -		  		// Remember the type; lazy will change it;  		TypeReference returnType = copyType(((FieldDeclaration) fieldNode.get()).type, source); @@ -271,11 +269,10 @@ public class HandleGetter extends EclipseAnnotationHandler<Getter> {  			}  			method.annotations = copyAnnotations(source, -					onMethod.toArray(new Annotation[0]), -					findAnnotations(field, NON_NULL_PATTERN), -					findAnnotations(field, NULLABLE_PATTERN), -					findDelegatesAndMarkAsHandled(fieldNode), -					deprecated); +				onMethod.toArray(new Annotation[0]), +				findCopyableAnnotations(fieldNode), +				findDelegatesAndMarkAsHandled(fieldNode), +				deprecated);  		}  		method.traverse(new SetGeneratedByVisitor(source), parent.scope); diff --git a/src/core/lombok/eclipse/handlers/HandleNonNull.java b/src/core/lombok/eclipse/handlers/HandleNonNull.java index d09993ed..ebc62909 100644 --- a/src/core/lombok/eclipse/handlers/HandleNonNull.java +++ b/src/core/lombok/eclipse/handlers/HandleNonNull.java @@ -58,7 +58,26 @@ import org.mangosdk.spi.ProviderFor;  @ProviderFor(EclipseAnnotationHandler.class)  @HandlerPriority(value = 512) // 2^9; onParameter=@__(@NonNull) has to run first.  public class HandleNonNull extends EclipseAnnotationHandler<NonNull> { +	public static final HandleNonNull INSTANCE = new HandleNonNull(); +	 +	public void fix(EclipseNode method) { +		for (EclipseNode m : method.down()) { +			if (m.getKind() != Kind.ARGUMENT) continue; +			for (EclipseNode c : m.down()) { +				if (c.getKind() == Kind.ANNOTATION) { +					if (annotationTypeMatches(NonNull.class, c)) { +						handle0((Annotation) c.get(), c, true); +					} +				} +			} +		} +	} +	  	@Override public void handle(AnnotationValues<NonNull> annotation, Annotation ast, EclipseNode annotationNode) { +		handle0(ast, annotationNode, false); +	} +	 +	private void handle0(Annotation ast, EclipseNode annotationNode, boolean force) {  		handleFlagUsage(annotationNode, ConfigurationKeys.NON_NULL_FLAG_USAGE, "@NonNull");  		if (annotationNode.up().getKind() == Kind.FIELD) { @@ -88,7 +107,7 @@ public class HandleNonNull extends EclipseAnnotationHandler<NonNull> {  			return;  		} -		if (isGenerated(declaration)) return; +		if (!force && isGenerated(declaration)) return;  		if (declaration.isAbstract()) {  			// This used to be a warning, but as @NonNull also has a documentary purpose, better to not warn about this. Since 1.16.7 diff --git a/src/core/lombok/eclipse/handlers/HandleSetter.java b/src/core/lombok/eclipse/handlers/HandleSetter.java index d4df0deb..529a7d19 100644 --- a/src/core/lombok/eclipse/handlers/HandleSetter.java +++ b/src/core/lombok/eclipse/handlers/HandleSetter.java @@ -236,10 +236,9 @@ public class HandleSetter extends EclipseAnnotationHandler<Setter> {  		method.bodyStart = method.declarationSourceStart = method.sourceStart = source.sourceStart;  		method.bodyEnd = method.declarationSourceEnd = method.sourceEnd = source.sourceEnd; -		Annotation[] nonNulls = findAnnotations(field, NON_NULL_PATTERN); -		Annotation[] nullables = findAnnotations(field, NULLABLE_PATTERN); +		Annotation[] copyableAnnotations = findCopyableAnnotations(fieldNode);  		List<Statement> statements = new ArrayList<Statement>(5); -		if (nonNulls.length == 0) { +		if (!hasNonNullAnnotations(fieldNode)) {  			statements.add(assignment);  		} else {  			Statement nullCheck = generateNullCheck(field, sourceNode); @@ -255,7 +254,7 @@ public class HandleSetter extends EclipseAnnotationHandler<Setter> {  			statements.add(returnStatement);  		}  		method.statements = statements.toArray(new Statement[0]); -		param.annotations = copyAnnotations(source, nonNulls, nullables, onParam.toArray(new Annotation[0])); +		param.annotations = copyAnnotations(source, copyableAnnotations, onParam.toArray(new Annotation[0]));  		method.traverse(new SetGeneratedByVisitor(source), parent.scope);  		return method; diff --git a/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java b/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java index 8f353cce..97e38904 100644 --- a/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java +++ b/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java @@ -156,9 +156,12 @@ public class HandleSuperBuilder extends EclipseAnnotationHandler<SuperBuilder> {  			EclipseNode isDefault = findAnnotation(Builder.Default.class, fieldNode);  			boolean isFinal = ((fd.modifiers & ClassFileConstants.AccFinal) != 0) || (valuePresent && !hasAnnotation(NonFinal.class, fieldNode)); +			Annotation[] copyableAnnotations = findCopyableAnnotations(fieldNode); +			  			BuilderFieldData bfd = new BuilderFieldData();  			bfd.rawName = fieldNode.getName().toCharArray();  			bfd.name = removePrefixFromField(fieldNode); +			bfd.annotations = copyAnnotations(fd, copyableAnnotations);  			bfd.type = fd.type;  			bfd.singularData = getSingularData(fieldNode, ast);  			bfd.originalFieldNode = fieldNode; @@ -516,12 +519,9 @@ public class HandleSuperBuilder extends EclipseAnnotationHandler<SuperBuilder> {  				statements.add(assignment);  			} -			Annotation[] nonNulls = findAnnotations((FieldDeclaration)fieldNode.originalFieldNode.get(), NON_NULL_PATTERN); -			if (nonNulls.length != 0) { -				Statement nullCheck = generateNullCheck((FieldDeclaration)fieldNode.originalFieldNode.get(), sourceNode); -				if (nullCheck != null) { -					statements.add(nullCheck); -				} +			if (hasNonNullAnnotations(fieldNode.originalFieldNode)) { +				Statement nullCheck = generateNullCheck((FieldDeclaration) fieldNode.originalFieldNode.get(), sourceNode); +				if (nullCheck != null) statements.add(nullCheck);  			}  		} @@ -851,13 +851,13 @@ public class HandleSuperBuilder extends EclipseAnnotationHandler<SuperBuilder> {  		};  		if (bfd.singularData == null || bfd.singularData.getSingularizer() == null) { -			generateSimpleSetterMethodForBuilder(builderType, deprecate, bfd.createdFields.get(0), bfd.nameOfSetFlag, returnTypeMaker.make(), returnStatementMaker.make(), sourceNode); +			generateSimpleSetterMethodForBuilder(builderType, deprecate, bfd.createdFields.get(0), bfd.nameOfSetFlag, returnTypeMaker.make(), returnStatementMaker.make(), sourceNode, bfd.annotations);  		} else {  			bfd.singularData.getSingularizer().generateMethods(bfd.singularData, deprecate, builderType, true, returnTypeMaker, returnStatementMaker);  		}  	} -	private void generateSimpleSetterMethodForBuilder(EclipseNode builderType, boolean deprecate, EclipseNode fieldNode, char[] nameOfSetFlag, TypeReference returnType, Statement returnStatement, EclipseNode sourceNode) { +	private void generateSimpleSetterMethodForBuilder(EclipseNode builderType, boolean deprecate, EclipseNode fieldNode, char[] nameOfSetFlag, TypeReference returnType, Statement returnStatement, EclipseNode sourceNode, Annotation[] annosOnParam) {  		TypeDeclaration td = (TypeDeclaration) builderType.get();  		AbstractMethodDeclaration[] existing = td.methods;  		if (existing == null) existing = EMPTY_METHODS; @@ -874,7 +874,7 @@ public class HandleSuperBuilder extends EclipseAnnotationHandler<SuperBuilder> {  		String setterName = fieldNode.getName();  		MethodDeclaration setter = HandleSetter.createSetter(td, deprecate, fieldNode, setterName, nameOfSetFlag, returnType, returnStatement, ClassFileConstants.AccPublic, -			sourceNode, Collections.<Annotation>emptyList(), Collections.<Annotation>emptyList()); +			sourceNode, Collections.<Annotation>emptyList(), annosOnParam != null ? Arrays.asList(copyAnnotations(sourceNode.get(), annosOnParam)) : Collections.<Annotation>emptyList());  		injectMethod(builderType, setter);  	} diff --git a/src/core/lombok/eclipse/handlers/HandleWither.java b/src/core/lombok/eclipse/handlers/HandleWither.java index c035fc26..a99789a6 100644 --- a/src/core/lombok/eclipse/handlers/HandleWither.java +++ b/src/core/lombok/eclipse/handlers/HandleWither.java @@ -240,8 +240,7 @@ public class HandleWither extends EclipseAnnotationHandler<Wither> {  		method.typeParameters = null;  		method.bits |= ECLIPSE_DO_NOT_TOUCH_FLAG; -		Annotation[] nonNulls = findAnnotations(field, NON_NULL_PATTERN); -		Annotation[] nullables = findAnnotations(field, NULLABLE_PATTERN); +		Annotation[] copyableAnnotations = findCopyableAnnotations(fieldNode);  		if (!makeAbstract) {  			List<Expression> args = new ArrayList<Expression>(); @@ -277,7 +276,7 @@ public class HandleWither extends EclipseAnnotationHandler<Wither> {  			method.bodyEnd = method.declarationSourceEnd = method.sourceEnd = source.sourceEnd;  			List<Statement> statements = new ArrayList<Statement>(5); -			if (nonNulls.length > 0) { +			if (hasNonNullAnnotations(fieldNode)) {  				Statement nullCheck = generateNullCheck(field, sourceNode);  				if (nullCheck != null) statements.add(nullCheck);  			} @@ -285,7 +284,7 @@ public class HandleWither extends EclipseAnnotationHandler<Wither> {  			method.statements = statements.toArray(new Statement[0]);  		} -		param.annotations = copyAnnotations(source, nonNulls, nullables, onParam.toArray(new Annotation[0])); +		param.annotations = copyAnnotations(source, copyableAnnotations, onParam.toArray(new Annotation[0]));  		method.traverse(new SetGeneratedByVisitor(source), parent.scope);  		return method; diff --git a/src/core/lombok/eclipse/handlers/singulars/EclipseGuavaSingularizer.java b/src/core/lombok/eclipse/handlers/singulars/EclipseGuavaSingularizer.java index f1687c9c..17fc5e09 100644 --- a/src/core/lombok/eclipse/handlers/singulars/EclipseGuavaSingularizer.java +++ b/src/core/lombok/eclipse/handlers/singulars/EclipseGuavaSingularizer.java @@ -32,6 +32,7 @@ import lombok.core.GuavaTypeMap;  import lombok.core.LombokImmutableList;  import lombok.core.handlers.HandlerUtil;  import lombok.eclipse.EclipseNode; +import lombok.eclipse.handlers.HandleNonNull;  import lombok.eclipse.handlers.EclipseSingularsRecipes.EclipseSingularizer;  import lombok.eclipse.handlers.EclipseSingularsRecipes.SingularData;  import lombok.eclipse.handlers.EclipseSingularsRecipes.StatementMaker; @@ -150,14 +151,17 @@ abstract class EclipseGuavaSingularizer extends EclipseSingularizer {  		md.arguments = new Argument[suffixes.size()];  		for (int i = 0; i < suffixes.size(); i++) {  			TypeReference tr = cloneParamType(i, data.getTypeArgs(), builderType); -			md.arguments[i] = new Argument(names[i], 0, tr, 0); +			Annotation[] typeUseAnns = getTypeUseAnnotations(tr); +			removeTypeUseAnnotations(tr); +			md.arguments[i] = new Argument(names[i], 0, tr, ClassFileConstants.AccFinal); +			md.arguments[i].annotations = typeUseAnns;  		}  		md.returnType = returnType;  		md.selector = fluent ? data.getSingularName() : HandlerUtil.buildAccessorName(getAddMethodName(), new String(data.getSingularName())).toCharArray();  		md.annotations = deprecate ? new Annotation[] { generateDeprecatedAnnotation(data.getSource()) } : null;  		data.setGeneratedByRecursive(md); -		injectMethod(builderType, md); +		HandleNonNull.INSTANCE.fix(injectMethod(builderType, md));  	}  	void generatePluralMethod(boolean deprecate, TypeReference returnType, Statement returnStatement, SingularData data, EclipseNode builderType, boolean fluent) { @@ -182,7 +186,7 @@ abstract class EclipseGuavaSingularizer extends EclipseSingularizer {  		TypeReference paramType;  		paramType = new QualifiedTypeReference(fromQualifiedName(getAddAllTypeName()), NULL_POSS);  		paramType = addTypeArgs(getTypeArgumentsCount(), true, builderType, paramType, data.getTypeArgs()); -		Argument param = new Argument(data.getPluralName(), 0, paramType, 0); +		Argument param = new Argument(data.getPluralName(), 0, paramType, ClassFileConstants.AccFinal);  		md.arguments = new Argument[] {param};  		md.returnType = returnType;  		md.selector = fluent ? data.getPluralName() : HandlerUtil.buildAccessorName(getAddMethodName() + "All", new String(data.getPluralName())).toCharArray(); diff --git a/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilListSetSingularizer.java b/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilListSetSingularizer.java index 5f86a4dc..c7315790 100644 --- a/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilListSetSingularizer.java +++ b/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilListSetSingularizer.java @@ -30,6 +30,7 @@ import java.util.List;  import lombok.core.handlers.HandlerUtil;  import lombok.eclipse.EclipseNode; +import lombok.eclipse.handlers.HandleNonNull;  import lombok.eclipse.handlers.EclipseSingularsRecipes.SingularData;  import lombok.eclipse.handlers.EclipseSingularsRecipes.StatementMaker;  import lombok.eclipse.handlers.EclipseSingularsRecipes.TypeReferenceMaker; @@ -138,14 +139,18 @@ abstract class EclipseJavaUtilListSetSingularizer extends EclipseJavaUtilSingula  		md.statements = statements.toArray(new Statement[statements.size()]);  		TypeReference paramType = cloneParamType(0, data.getTypeArgs(), builderType); -		Argument param = new Argument(data.getSingularName(), 0, paramType, 0); +		Annotation[] typeUseAnns = getTypeUseAnnotations(paramType); +		removeTypeUseAnnotations(paramType); +		Argument param = new Argument(data.getSingularName(), 0, paramType, ClassFileConstants.AccFinal); +		param.annotations = typeUseAnns;  		md.arguments = new Argument[] {param};  		md.returnType = returnType;  		md.selector = fluent ? data.getSingularName() : HandlerUtil.buildAccessorName("add", new String(data.getSingularName())).toCharArray();  		md.annotations = deprecate ? new Annotation[] { generateDeprecatedAnnotation(data.getSource()) } : null;  		data.setGeneratedByRecursive(md); -		injectMethod(builderType, md); +		 +		HandleNonNull.INSTANCE.fix(injectMethod(builderType, md));  	}  	void generatePluralMethod(boolean deprecate, TypeReference returnType, Statement returnStatement, SingularData data, EclipseNode builderType, boolean fluent) { @@ -169,7 +174,7 @@ abstract class EclipseJavaUtilListSetSingularizer extends EclipseJavaUtilSingula  		TypeReference paramType = new QualifiedTypeReference(TypeConstants.JAVA_UTIL_COLLECTION, NULL_POSS);  		paramType = addTypeArgs(1, true, builderType, paramType, data.getTypeArgs()); -		Argument param = new Argument(data.getPluralName(), 0, paramType, 0); +		Argument param = new Argument(data.getPluralName(), 0, paramType, ClassFileConstants.AccFinal);  		md.arguments = new Argument[] {param};  		md.returnType = returnType;  		md.selector = fluent ? data.getPluralName() : HandlerUtil.buildAccessorName("addAll", new String(data.getPluralName())).toCharArray(); diff --git a/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilMapSingularizer.java b/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilMapSingularizer.java index 69c2186a..174cd5fc 100644 --- a/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilMapSingularizer.java +++ b/src/core/lombok/eclipse/handlers/singulars/EclipseJavaUtilMapSingularizer.java @@ -59,6 +59,7 @@ import lombok.eclipse.handlers.EclipseSingularsRecipes.EclipseSingularizer;  import lombok.eclipse.handlers.EclipseSingularsRecipes.SingularData;  import lombok.eclipse.handlers.EclipseSingularsRecipes.StatementMaker;  import lombok.eclipse.handlers.EclipseSingularsRecipes.TypeReferenceMaker; +import lombok.eclipse.handlers.HandleNonNull;  @ProviderFor(EclipseSingularizer.class)  public class EclipseJavaUtilMapSingularizer extends EclipseJavaUtilSingularizer { @@ -214,16 +215,23 @@ public class EclipseJavaUtilMapSingularizer extends EclipseJavaUtilSingularizer  		md.statements = statements.toArray(new Statement[statements.size()]);  		TypeReference keyParamType = cloneParamType(0, data.getTypeArgs(), builderType); -		Argument keyParam = new Argument(keyParamName, 0, keyParamType, 0);  		TypeReference valueParamType = cloneParamType(1, data.getTypeArgs(), builderType); -		Argument valueParam = new Argument(valueParamName, 0, valueParamType, 0); +		Annotation[] typeUseAnnsKey = getTypeUseAnnotations(keyParamType); +		Annotation[] typeUseAnnsValue = getTypeUseAnnotations(valueParamType); +		 +		removeTypeUseAnnotations(keyParamType); +		removeTypeUseAnnotations(valueParamType); +		Argument keyParam = new Argument(keyParamName, 0, keyParamType, ClassFileConstants.AccFinal); +		Argument valueParam = new Argument(valueParamName, 0, valueParamType, ClassFileConstants.AccFinal); +		keyParam.annotations = typeUseAnnsKey; +		valueParam.annotations = typeUseAnnsValue;  		md.arguments = new Argument[] {keyParam, valueParam};  		md.returnType = returnType;  		md.selector = fluent ? data.getSingularName() : HandlerUtil.buildAccessorName("put", new String(data.getSingularName())).toCharArray();  		md.annotations = deprecate ? new Annotation[] { generateDeprecatedAnnotation(data.getSource()) } : null;  		data.setGeneratedByRecursive(md); -		injectMethod(builderType, md); +		HandleNonNull.INSTANCE.fix(injectMethod(builderType, md));  	}  	private void generatePluralMethod(boolean deprecate, TypeReference returnType, Statement returnStatement, SingularData data, EclipseNode builderType, boolean fluent) { @@ -280,7 +288,7 @@ public class EclipseJavaUtilMapSingularizer extends EclipseJavaUtilSingularizer  		TypeReference paramType = new QualifiedTypeReference(JAVA_UTIL_MAP, NULL_POSS);  		paramType = addTypeArgs(2, true, builderType, paramType, data.getTypeArgs()); -		Argument param = new Argument(data.getPluralName(), 0, paramType, 0); +		Argument param = new Argument(data.getPluralName(), 0, paramType, ClassFileConstants.AccFinal);  		md.arguments = new Argument[] {param};  		md.returnType = returnType;  		md.selector = fluent ? data.getPluralName() : HandlerUtil.buildAccessorName("putAll", new String(data.getPluralName())).toCharArray(); diff --git a/src/core/lombok/javac/handlers/HandleBuilder.java b/src/core/lombok/javac/handlers/HandleBuilder.java index 201b5048..bf260644 100644 --- a/src/core/lombok/javac/handlers/HandleBuilder.java +++ b/src/core/lombok/javac/handlers/HandleBuilder.java @@ -85,6 +85,7 @@ public class HandleBuilder extends JavacAnnotationHandler<Builder> {  	}  	public static class BuilderFieldData { +		List<JCAnnotation> annotations;  		JCExpression type;  		Name rawName;  		Name name; @@ -148,9 +149,11 @@ public class HandleBuilder extends JavacAnnotationHandler<Builder> {  				JCVariableDecl fd = (JCVariableDecl) fieldNode.get();  				JavacNode isDefault = findAnnotation(Builder.Default.class, fieldNode, false);  				boolean isFinal = (fd.mods.flags & Flags.FINAL) != 0 || (valuePresent && !hasAnnotation(NonFinal.class, fieldNode)); +				  				BuilderFieldData bfd = new BuilderFieldData();  				bfd.rawName = fd.name;  				bfd.name = removePrefixFromField(fieldNode); +				bfd.annotations = findCopyableAnnotations(fieldNode);  				bfd.type = fd.vartype;  				bfd.singularData = getSingularData(fieldNode);  				bfd.originalFieldNode = fieldNode; @@ -326,9 +329,11 @@ public class HandleBuilder extends JavacAnnotationHandler<Builder> {  			for (JavacNode param : fillParametersFrom.down()) {  				if (param.getKind() != Kind.ARGUMENT) continue;  				BuilderFieldData bfd = new BuilderFieldData(); +				  				JCVariableDecl raw = (JCVariableDecl) param.get();  				bfd.name = raw.name;  				bfd.rawName = raw.name; +				bfd.annotations = findCopyableAnnotations(param);  				bfd.type = raw.vartype;  				bfd.singularData = getSingularData(param);  				bfd.originalFieldNode = param; @@ -678,13 +683,13 @@ public class HandleBuilder extends JavacAnnotationHandler<Builder> {  	public void makeSetterMethodsForBuilder(JavacNode builderType, BuilderFieldData fieldNode, JavacNode source, boolean fluent, boolean chain) {  		boolean deprecate = isFieldDeprecated(fieldNode.originalFieldNode);  		if (fieldNode.singularData == null || fieldNode.singularData.getSingularizer() == null) { -			makeSimpleSetterMethodForBuilder(builderType, deprecate, fieldNode.createdFields.get(0), fieldNode.nameOfSetFlag, source, fluent, chain); +			makeSimpleSetterMethodForBuilder(builderType, deprecate, fieldNode.createdFields.get(0), fieldNode.nameOfSetFlag, source, fluent, chain, fieldNode.annotations);  		} else {  			fieldNode.singularData.getSingularizer().generateMethods(fieldNode.singularData, deprecate, builderType, source.get(), fluent, chain);  		}  	} -	private void makeSimpleSetterMethodForBuilder(JavacNode builderType, boolean deprecate, JavacNode fieldNode, Name nameOfSetFlag, JavacNode source, boolean fluent, boolean chain) { +	private void makeSimpleSetterMethodForBuilder(JavacNode builderType, boolean deprecate, JavacNode fieldNode, Name nameOfSetFlag, JavacNode source, boolean fluent, boolean chain, List<JCAnnotation> annosOnParam) {  		Name fieldName = ((JCVariableDecl) fieldNode.get()).name;  		for (JavacNode child : builderType.down()) { @@ -698,7 +703,7 @@ public class HandleBuilder extends JavacAnnotationHandler<Builder> {  		JavacTreeMaker maker = fieldNode.getTreeMaker(); -		JCMethodDecl newMethod = HandleSetter.createSetter(Flags.PUBLIC, deprecate, fieldNode, maker, setterName, nameOfSetFlag, chain, source, List.<JCAnnotation>nil(), List.<JCAnnotation>nil()); +		JCMethodDecl newMethod = HandleSetter.createSetter(Flags.PUBLIC, deprecate, fieldNode, maker, setterName, nameOfSetFlag, chain, source, List.<JCAnnotation>nil(), annosOnParam);  		injectMethod(builderType, newMethod);  	} diff --git a/src/core/lombok/javac/handlers/HandleConstructor.java b/src/core/lombok/javac/handlers/HandleConstructor.java index 76caaffe..3c434d40 100644 --- a/src/core/lombok/javac/handlers/HandleConstructor.java +++ b/src/core/lombok/javac/handlers/HandleConstructor.java @@ -127,7 +127,7 @@ public class HandleConstructor {  			//Skip static fields.  			if ((fieldFlags & Flags.STATIC) != 0) continue;  			boolean isFinal = (fieldFlags & Flags.FINAL) != 0; -			boolean isNonNull = nullMarked && !findAnnotations(child, NON_NULL_PATTERN).isEmpty(); +			boolean isNonNull = nullMarked && hasNonNullAnnotations(child);  			if ((isFinal || isNonNull) && fieldDecl.init == null) fields.append(child);  		}  		return fields.toList(); @@ -329,12 +329,11 @@ public class HandleConstructor {  			JCVariableDecl field = (JCVariableDecl) fieldNode.get();  			Name fieldName = removePrefixFromField(fieldNode);  			Name rawName = field.name; -			List<JCAnnotation> nonNulls = findAnnotations(fieldNode, NON_NULL_PATTERN); -			List<JCAnnotation> nullables = findAnnotations(fieldNode, NULLABLE_PATTERN); +			List<JCAnnotation> copyableAnnotations = findCopyableAnnotations(fieldNode);  			long flags = JavacHandlerUtil.addFinalIfNeeded(Flags.PARAMETER, typeNode.getContext()); -			JCVariableDecl param = maker.VarDef(maker.Modifiers(flags, nonNulls.appendList(nullables)), fieldName, field.vartype, null); +			JCVariableDecl param = maker.VarDef(maker.Modifiers(flags, copyableAnnotations), fieldName, field.vartype, null);  			params.append(param); -			if (!nonNulls.isEmpty()) { +			if (hasNonNullAnnotations(fieldNode)) {  				JCStatement nullCheck = generateNullCheck(maker, fieldNode, param, source);  				if (nullCheck != null) nullChecks.append(nullCheck);  			} @@ -471,10 +470,9 @@ public class HandleConstructor {  			JCVariableDecl field = (JCVariableDecl) fieldNode.get();  			Name fieldName = removePrefixFromField(fieldNode);  			JCExpression pType = cloneType(maker, field.vartype, source, typeNode.getContext()); -			List<JCAnnotation> nonNulls = findAnnotations(fieldNode, NON_NULL_PATTERN); -			List<JCAnnotation> nullables = findAnnotations(fieldNode, NULLABLE_PATTERN); +			List<JCAnnotation> copyableAnnotations = findCopyableAnnotations(fieldNode);  			long flags = JavacHandlerUtil.addFinalIfNeeded(Flags.PARAMETER, typeNode.getContext()); -			JCVariableDecl param = maker.VarDef(maker.Modifiers(flags, nonNulls.appendList(nullables)), fieldName, pType, null); +			JCVariableDecl param = maker.VarDef(maker.Modifiers(flags, copyableAnnotations), fieldName, pType, null);  			params.append(param);  			args.append(maker.Ident(fieldName));  		} diff --git a/src/core/lombok/javac/handlers/HandleGetter.java b/src/core/lombok/javac/handlers/HandleGetter.java index 4fc6155c..7a178f66 100644 --- a/src/core/lombok/javac/handlers/HandleGetter.java +++ b/src/core/lombok/javac/handlers/HandleGetter.java @@ -243,12 +243,9 @@ public class HandleGetter extends JavacAnnotationHandler<Getter> {  		List<JCExpression> throwsClauses = List.nil();  		JCExpression annotationMethodDefaultValue = null; -		List<JCAnnotation> nonNulls = findAnnotations(field, NON_NULL_PATTERN); -		List<JCAnnotation> nullables = findAnnotations(field, NULLABLE_PATTERN); -		 +		List<JCAnnotation> copyableAnnotations = findCopyableAnnotations(field);  		List<JCAnnotation> delegates = findDelegatesAndRemoveFromField(field); -		 -		List<JCAnnotation> annsOnMethod = copyAnnotations(onMethod).appendList(nonNulls).appendList(nullables); +		List<JCAnnotation> annsOnMethod = copyAnnotations(onMethod).appendList(copyableAnnotations);  		if (isFieldDeprecated(field)) {  			annsOnMethod = annsOnMethod.prepend(treeMaker.Annotation(genJavaLangTypeRef(field, "Deprecated"), List.<JCExpression>nil()));  		} diff --git a/src/core/lombok/javac/handlers/HandleSetter.java b/src/core/lombok/javac/handlers/HandleSetter.java index 0ddaa7d7..28f5318d 100644 --- a/src/core/lombok/javac/handlers/HandleSetter.java +++ b/src/core/lombok/javac/handlers/HandleSetter.java @@ -226,16 +226,15 @@ public class HandleSetter extends JavacAnnotationHandler<Setter> {  		JCAssign assign = treeMaker.Assign(fieldRef, treeMaker.Ident(fieldDecl.name));  		ListBuffer<JCStatement> statements = new ListBuffer<JCStatement>(); -		List<JCAnnotation> nonNulls = findAnnotations(field, NON_NULL_PATTERN); -		List<JCAnnotation> nullables = findAnnotations(field, NULLABLE_PATTERN); +		List<JCAnnotation> copyableAnnotations = findCopyableAnnotations(field);  		Name methodName = field.toName(setterName); -		List<JCAnnotation> annsOnParam = copyAnnotations(onParam).appendList(nonNulls).appendList(nullables); +		List<JCAnnotation> annsOnParam = copyAnnotations(onParam).appendList(copyableAnnotations);  		long flags = JavacHandlerUtil.addFinalIfNeeded(Flags.PARAMETER, field.getContext());  		JCVariableDecl param = treeMaker.VarDef(treeMaker.Modifiers(flags, annsOnParam), fieldDecl.name, fieldDecl.vartype, null); -		if (nonNulls.isEmpty()) { +		if (!hasNonNullAnnotations(field)) {  			statements.append(treeMaker.Exec(assign));  		} else {  			JCStatement nullCheck = generateNullCheck(treeMaker, field, source); diff --git a/src/core/lombok/javac/handlers/HandleSuperBuilder.java b/src/core/lombok/javac/handlers/HandleSuperBuilder.java index a440c9be..c84988ea 100644 --- a/src/core/lombok/javac/handlers/HandleSuperBuilder.java +++ b/src/core/lombok/javac/handlers/HandleSuperBuilder.java @@ -131,6 +131,7 @@ public class HandleSuperBuilder extends JavacAnnotationHandler<SuperBuilder> {  			BuilderFieldData bfd = new BuilderFieldData();  			bfd.rawName = fd.name;  			bfd.name = removePrefixFromField(fieldNode); +			bfd.annotations = findCopyableAnnotations(fieldNode);  			bfd.type = fd.vartype;  			bfd.singularData = getSingularData(fieldNode);  			bfd.originalFieldNode = fieldNode; @@ -451,8 +452,7 @@ public class HandleSuperBuilder extends JavacAnnotationHandler<SuperBuilder> {  				statements.append(assign);  			} -			List<JCAnnotation> nonNulls = findAnnotations(bfd.originalFieldNode, NON_NULL_PATTERN); -			if (!nonNulls.isEmpty()) { +			if (hasNonNullAnnotations(bfd.originalFieldNode)) {  				JCStatement nullCheck = generateNullCheck(maker, bfd.originalFieldNode, source);  				if (nullCheck != null) statements.append(nullCheck);  			} @@ -797,13 +797,13 @@ public class HandleSuperBuilder extends JavacAnnotationHandler<SuperBuilder> {  		}};  		if (fieldNode.singularData == null || fieldNode.singularData.getSingularizer() == null) { -			generateSimpleSetterMethodForBuilder(builderType, deprecate, fieldNode.createdFields.get(0), fieldNode.nameOfSetFlag, source, true, returnTypeMaker.make(), returnStatementMaker.make()); +			generateSimpleSetterMethodForBuilder(builderType, deprecate, fieldNode.createdFields.get(0), fieldNode.nameOfSetFlag, source, true, returnTypeMaker.make(), returnStatementMaker.make(), fieldNode.annotations);  		} else {  			fieldNode.singularData.getSingularizer().generateMethods(fieldNode.singularData, deprecate, builderType, source.get(), true, returnTypeMaker, returnStatementMaker);  		}  	} -	private void generateSimpleSetterMethodForBuilder(JavacNode builderType, boolean deprecate, JavacNode fieldNode, Name nameOfSetFlag, JavacNode source, boolean fluent, JCExpression returnType, JCStatement returnStatement) { +	private void generateSimpleSetterMethodForBuilder(JavacNode builderType, boolean deprecate, JavacNode fieldNode, Name nameOfSetFlag, JavacNode source, boolean fluent, JCExpression returnType, JCStatement returnStatement, List<JCAnnotation> annosOnParam) {  		Name fieldName = ((JCVariableDecl) fieldNode.get()).name;  		for (JavacNode child : builderType.down()) { @@ -817,7 +817,7 @@ public class HandleSuperBuilder extends JavacAnnotationHandler<SuperBuilder> {  		JavacTreeMaker maker = fieldNode.getTreeMaker(); -		JCMethodDecl newMethod = HandleSetter.createSetter(Flags.PUBLIC, deprecate, fieldNode, maker, setterName, nameOfSetFlag, returnType, returnStatement, source, List.<JCAnnotation>nil(), List.<JCAnnotation>nil()); +		JCMethodDecl newMethod = HandleSetter.createSetter(Flags.PUBLIC, deprecate, fieldNode, maker, setterName, nameOfSetFlag, returnType, returnStatement, source, List.<JCAnnotation>nil(), annosOnParam);  		injectMethod(builderType, newMethod);  	} diff --git a/src/core/lombok/javac/handlers/HandleWither.java b/src/core/lombok/javac/handlers/HandleWither.java index 87f3c16a..33c4dec2 100644 --- a/src/core/lombok/javac/handlers/HandleWither.java +++ b/src/core/lombok/javac/handlers/HandleWither.java @@ -222,8 +222,7 @@ public class HandleWither extends JavacAnnotationHandler<Wither> {  		JCVariableDecl fieldDecl = (JCVariableDecl) field.get(); -		List<JCAnnotation> nonNulls = findAnnotations(field, NON_NULL_PATTERN); -		List<JCAnnotation> nullables = findAnnotations(field, NULLABLE_PATTERN); +		List<JCAnnotation> copyableAnnotations = findCopyableAnnotations(field);  		Name methodName = field.toName(witherName); @@ -231,7 +230,7 @@ public class HandleWither extends JavacAnnotationHandler<Wither> {  		JCBlock methodBody = null;  		long flags = JavacHandlerUtil.addFinalIfNeeded(Flags.PARAMETER, field.getContext()); -		List<JCAnnotation> annsOnParam = copyAnnotations(onParam).appendList(nonNulls).appendList(nullables); +		List<JCAnnotation> annsOnParam = copyAnnotations(onParam).appendList(copyableAnnotations);  		JCVariableDecl param = maker.VarDef(maker.Modifiers(flags, annsOnParam), fieldDecl.name, fieldDecl.vartype, null); @@ -264,7 +263,7 @@ public class HandleWither extends JavacAnnotationHandler<Wither> {  			JCConditional conditional = maker.Conditional(identityCheck, maker.Ident(field.toName("this")), newClass);  			JCReturn returnStatement = maker.Return(conditional); -			if (nonNulls.isEmpty()) { +			if (!hasNonNullAnnotations(field)) {  				statements.append(returnStatement);  			} else {  				JCStatement nullCheck = generateNullCheck(maker, field, source); diff --git a/src/core/lombok/javac/handlers/JavacHandlerUtil.java b/src/core/lombok/javac/handlers/JavacHandlerUtil.java index 92c642d4..e4e40095 100644 --- a/src/core/lombok/javac/handlers/JavacHandlerUtil.java +++ b/src/core/lombok/javac/handlers/JavacHandlerUtil.java @@ -27,6 +27,7 @@ import static lombok.javac.Javac.*;  import static lombok.javac.JavacAugments.JCTree_generatedNode;  import java.lang.annotation.Annotation; +import java.lang.reflect.Constructor;  import java.lang.reflect.Field;  import java.lang.reflect.Method;  import java.lang.reflect.Modifier; @@ -49,6 +50,7 @@ import lombok.core.LombokImmutableList;  import lombok.core.AnnotationValues.AnnotationValue;  import lombok.core.TypeResolver;  import lombok.core.configuration.NullCheckExceptionType; +import lombok.core.configuration.TypeName;  import lombok.core.handlers.HandlerUtil;  import lombok.delombok.LombokOptionsFactory;  import lombok.experimental.Accessors; @@ -1038,6 +1040,57 @@ public class JavacHandlerUtil {  		return (field.mods.flags & Flags.ENUM) != 0;  	} +	static class JCAnnotatedTypeReflect { +		private static Class<?> TYPE; +		private static Constructor<?> CONSTRUCTOR; +		private static Field ANNOTATIONS, UNDERLYING_TYPE; +		 +		private static void init(Class<?> in) { +			if (TYPE != null) return; +			if (!in.getName().equals("com.sun.tools.javac.tree.JCTree$JCAnnotatedType")) return; +			try { +				CONSTRUCTOR = in.getDeclaredConstructor(List.class, JCExpression.class); +				CONSTRUCTOR.setAccessible(true); +				ANNOTATIONS = in.getDeclaredField("annotations"); +				UNDERLYING_TYPE = in.getDeclaredField("underlyingType"); +				TYPE = in; +			} catch (Exception ignore) {} +		} +		 +		static boolean is(JCTree obj) { +			if (obj == null) return false; +			init(obj.getClass()); +			return obj.getClass() == TYPE; +		} +		 +		@SuppressWarnings("unchecked") +		static List<JCAnnotation> getAnnotations(JCTree obj) { +			init(obj.getClass()); +			try { +				return (List<JCAnnotation>) ANNOTATIONS.get(obj); +			} catch (Exception e) { +				return List.nil(); +			} +		} +		 +		static JCExpression getUnderlyingType(JCTree obj) { +			init(obj.getClass()); +			try { +				return (JCExpression) UNDERLYING_TYPE.get(obj); +			} catch (Exception e) { +				return null; +			} +		} +		 +		static JCExpression create(List<JCAnnotation> annotations, JCExpression underlyingType) { +			try { +				return (JCExpression) CONSTRUCTOR.newInstance(annotations, underlyingType); +			} catch (Exception e) { +				return null; +			} +		} +	} +	  	// jdk9 support, types have changed, names stay the same  	static class ClassSymbolMembersField {  		private static final Field membersField; @@ -1335,6 +1388,63 @@ public class JavacHandlerUtil {  		return result.toList();  	} +	public static boolean hasNonNullAnnotations(JavacNode node) { +		for (JavacNode child : node.down()) { +			if (child.getKind() == Kind.ANNOTATION) { +				JCAnnotation annotation = (JCAnnotation) child.get(); +				for (String nn : NONNULL_ANNOTATIONS) if (typeMatches(nn, node, annotation.annotationType)) return true; +			} +		} +		 +		return false; +	} +	 +	/** +	 * Searches the given field node for annotations and returns each one that is 'copyable' (either via configuration or from the base list). +	 */ +	public static List<JCAnnotation> findCopyableAnnotations(JavacNode node) { +		JCAnnotation anno = null; +		String annoName = null; +		for (JavacNode child : node.down()) { +			if (child.getKind() == Kind.ANNOTATION) { +				if (anno != null) { +					annoName = ""; +					break; +				} +				JCAnnotation annotation = (JCAnnotation) child.get(); +				annoName = annotation.annotationType.toString(); +				anno = annotation; +			} +		} +		 +		if (annoName == null) return List.nil(); +		 +		java.util.List<TypeName> configuredCopyable = node.getAst().readConfiguration(ConfigurationKeys.COPYABLE_ANNOTATIONS); +		 +		if (!annoName.isEmpty()) { +			for (TypeName cn : configuredCopyable) if (typeMatches(cn.toString(), node, anno.annotationType)) return List.of(anno); +			for (String bn : BASE_COPYABLE_ANNOTATIONS) if (typeMatches(bn, node, anno.annotationType)) return List.of(anno); +		} +		 +		ListBuffer<JCAnnotation> result = new ListBuffer<JCAnnotation>(); +		for (JavacNode child : node.down()) { +			if (child.getKind() == Kind.ANNOTATION) { +				JCAnnotation annotation = (JCAnnotation) child.get(); +				boolean match = false; +				for (TypeName cn : configuredCopyable) if (typeMatches(cn.toString(), node, annotation.annotationType)) { +					result.append(annotation); +					match = true; +					break; +				} +				if (!match) for (String bn : BASE_COPYABLE_ANNOTATIONS) if (typeMatches(bn, node, annotation.annotationType)) { +					result.append(annotation); +					break; +				} +			} +		} +		return result.toList(); +	} +	  	/**  	 * Generates a new statement that checks if the given variable is null, and if so, throws a configured exception with the  	 * variable name as message. @@ -1512,6 +1622,16 @@ public class JavacHandlerUtil {  		return out.toList();  	} +	public static List<JCAnnotation> getTypeUseAnnotations(JCExpression from) { +		if (!JCAnnotatedTypeReflect.is(from)) return List.nil(); +		return JCAnnotatedTypeReflect.getAnnotations(from); +	} +	 +	public static JCExpression removeTypeUseAnnotations(JCExpression from) { +		if (!JCAnnotatedTypeReflect.is(from)) return from; +		return JCAnnotatedTypeReflect.getUnderlyingType(from); +	} +	  	public static JCExpression namePlusTypeParamsToTypeReference(JavacTreeMaker maker, Name typeName, List<JCTypeParameter> params) {  		if (params.isEmpty()) {  			return maker.Ident(typeName); @@ -1592,7 +1712,7 @@ public class JavacHandlerUtil {  	}  	/** -	 * Creates a full clone of a given javac AST type node. Every part is cloned (every identifier, every select, every wildcard, every type apply). +	 * Creates a full clone of a given javac AST type node. Every part is cloned (every identifier, every select, every wildcard, every type apply, every type_use annotation).  	 *   	 * If there's any node in the tree that we don't know how to clone, that part isn't cloned. However, we wouldn't know what could possibly show up that we  	 * can't currently clone; that's just a safeguard. @@ -1654,6 +1774,12 @@ public class JavacHandlerUtil {  			return maker.Wildcard(newKind, newInner);  		} +		if (JCAnnotatedTypeReflect.is(in)) { +			JCExpression underlyingType = cloneType0(maker, JCAnnotatedTypeReflect.getUnderlyingType(in)); +			List<JCAnnotation> anns = copyAnnotations(JCAnnotatedTypeReflect.getAnnotations(in)); +			return JCAnnotatedTypeReflect.create(anns, underlyingType); +		} +		  		// This is somewhat unsafe, but it's better than outright throwing an exception here. Returning null will just cause an exception down the pipeline.  		return (JCExpression) in;  	} @@ -1829,7 +1955,7 @@ public class JavacHandlerUtil {  	public static boolean isDirectDescendantOfObject(JavacNode typeNode) {  		if (!(typeNode.get() instanceof JCClassDecl)) throw new IllegalArgumentException("not a type node"); -		JCTree extending = Javac.getExtendsClause((JCClassDecl)typeNode.get()); +		JCTree extending = Javac.getExtendsClause((JCClassDecl) typeNode.get());  		if (extending == null) return true;  		String p = extending.toString();  		return p.equals("Object") || p.equals("java.lang.Object"); diff --git a/src/core/lombok/javac/handlers/singulars/JavacGuavaSingularizer.java b/src/core/lombok/javac/handlers/singulars/JavacGuavaSingularizer.java index ffaf6674..74010d52 100644 --- a/src/core/lombok/javac/handlers/singulars/JavacGuavaSingularizer.java +++ b/src/core/lombok/javac/handlers/singulars/JavacGuavaSingularizer.java @@ -39,6 +39,7 @@ import lombok.javac.handlers.JavacSingularsRecipes.StatementMaker;  import com.sun.tools.javac.code.Flags;  import com.sun.tools.javac.tree.JCTree; +import com.sun.tools.javac.tree.JCTree.JCAnnotation;  import com.sun.tools.javac.tree.JCTree.JCBlock;  import com.sun.tools.javac.tree.JCTree.JCExpression;  import com.sun.tools.javac.tree.JCTree.JCMethodDecl; @@ -125,7 +126,10 @@ abstract class JavacGuavaSingularizer extends JavacSingularizer {  		ListBuffer<JCVariableDecl> params = new ListBuffer<JCVariableDecl>();  		for (int i = 0; i < suffixes.size(); i++) {  			JCExpression pt = cloneParamType(i, maker, data.getTypeArgs(), builderType, source); -			JCVariableDecl p = maker.VarDef(maker.Modifiers(paramFlags), names[i], pt, null); +			List<JCAnnotation> typeUseAnns = getTypeUseAnnotations(pt); +			pt = removeTypeUseAnnotations(pt); +			JCModifiers paramMods = typeUseAnns.isEmpty() ? maker.Modifiers(paramFlags) : maker.Modifiers(paramFlags, typeUseAnns); +			JCVariableDecl p = maker.VarDef(paramMods, names[i], pt, null);  			params.append(p);  		} diff --git a/src/core/lombok/javac/handlers/singulars/JavacJavaUtilListSetSingularizer.java b/src/core/lombok/javac/handlers/singulars/JavacJavaUtilListSetSingularizer.java index 39e53ebb..26ff8ba6 100644 --- a/src/core/lombok/javac/handlers/singulars/JavacJavaUtilListSetSingularizer.java +++ b/src/core/lombok/javac/handlers/singulars/JavacJavaUtilListSetSingularizer.java @@ -36,6 +36,7 @@ import lombok.javac.handlers.JavacSingularsRecipes.StatementMaker;  import com.sun.tools.javac.code.Flags;  import com.sun.tools.javac.tree.JCTree; +import com.sun.tools.javac.tree.JCTree.JCAnnotation;  import com.sun.tools.javac.tree.JCTree.JCBlock;  import com.sun.tools.javac.tree.JCTree.JCExpression;  import com.sun.tools.javac.tree.JCTree.JCMethodDecl; @@ -124,7 +125,10 @@ abstract class JavacJavaUtilListSetSingularizer extends JavacJavaUtilSingularize  		long paramFlags = JavacHandlerUtil.addFinalIfNeeded(Flags.PARAMETER, builderType.getContext());  		if (!fluent) name = builderType.toName(HandlerUtil.buildAccessorName("add", name.toString()));  		JCExpression paramType = cloneParamType(0, maker, data.getTypeArgs(), builderType, source); -		JCVariableDecl param = maker.VarDef(maker.Modifiers(paramFlags), data.getSingularName(), paramType, null); +		List<JCAnnotation> typeUseAnns = getTypeUseAnnotations(paramType); +		paramType = removeTypeUseAnnotations(paramType); +		JCModifiers paramMods = typeUseAnns.isEmpty() ? maker.Modifiers(paramFlags) : maker.Modifiers(paramFlags, typeUseAnns); +		JCVariableDecl param = maker.VarDef(paramMods, data.getSingularName(), paramType, null);  		JCMethodDecl method = maker.MethodDef(mods, name, returnType, typeParams, List.of(param), thrown, body, null);  		injectMethod(builderType, method);  	} diff --git a/src/core/lombok/javac/handlers/singulars/JavacJavaUtilMapSingularizer.java b/src/core/lombok/javac/handlers/singulars/JavacJavaUtilMapSingularizer.java index 34350f40..a009b88c 100644 --- a/src/core/lombok/javac/handlers/singulars/JavacJavaUtilMapSingularizer.java +++ b/src/core/lombok/javac/handlers/singulars/JavacJavaUtilMapSingularizer.java @@ -40,6 +40,7 @@ import org.mangosdk.spi.ProviderFor;  import com.sun.tools.javac.code.Flags;  import com.sun.tools.javac.tree.JCTree; +import com.sun.tools.javac.tree.JCTree.JCAnnotation;  import com.sun.tools.javac.tree.JCTree.JCBlock;  import com.sun.tools.javac.tree.JCTree.JCExpression;  import com.sun.tools.javac.tree.JCTree.JCMethodDecl; @@ -165,8 +166,14 @@ public class JavacJavaUtilMapSingularizer extends JavacJavaUtilSingularizer {  		if (!fluent) name = builderType.toName(HandlerUtil.buildAccessorName("put", name.toString()));  		JCExpression paramTypeKey = cloneParamType(0, maker, data.getTypeArgs(), builderType, source);  		JCExpression paramTypeValue = cloneParamType(1, maker, data.getTypeArgs(), builderType, source); -		JCVariableDecl paramKey = maker.VarDef(maker.Modifiers(paramFlags), keyName, paramTypeKey, null); -		JCVariableDecl paramValue = maker.VarDef(maker.Modifiers(paramFlags), valueName, paramTypeValue, null); +		List<JCAnnotation> typeUseAnnsKey = getTypeUseAnnotations(paramTypeKey); +		List<JCAnnotation> typeUseAnnsValue = getTypeUseAnnotations(paramTypeValue); +		paramTypeKey = removeTypeUseAnnotations(paramTypeKey); +		paramTypeValue = removeTypeUseAnnotations(paramTypeValue); +		JCModifiers paramModsKey = typeUseAnnsKey.isEmpty() ? maker.Modifiers(paramFlags) : maker.Modifiers(paramFlags, typeUseAnnsKey); +		JCModifiers paramModsValue = typeUseAnnsValue.isEmpty() ? maker.Modifiers(paramFlags) : maker.Modifiers(paramFlags, typeUseAnnsValue); +		JCVariableDecl paramKey = maker.VarDef(paramModsKey, keyName, paramTypeKey, null); +		JCVariableDecl paramValue = maker.VarDef(paramModsValue, valueName, paramTypeValue, null);  		JCMethodDecl method = maker.MethodDef(mods, name, returnType, typeParams, List.of(paramKey, paramValue), thrown, body, null);  		injectMethod(builderType, method);  	} | 
