The constructors will now also add non-final fields if they have a NonNull annotation

The constructor will test for null-values

The constructor and static constructor will copy the NonNull annotations from the fields

1 files changed, 19 insertions, 3 deletions

diff --git a/src/lombok/eclipse/handlers/HandleData.java b/src/lombok/eclipse/handlers/HandleData.java
index f1623e39..0296d5e4 100644
--- a/src/lombok/eclipse/handlers/HandleData.java
+++ b/src/lombok/eclipse/handlers/HandleData.java
@@ -89,7 +89,8 @@ public class HandleData implements EclipseAnnotationHandler<Data> {
 			//Skip static fields.
 			if ( (fieldDecl.modifiers & ClassFileConstants.AccStatic) != 0 ) continue;
 			boolean isFinal = (fieldDecl.modifiers & ClassFileConstants.AccFinal) != 0;
-			if ( isFinal && fieldDecl.initialization == null ) nodesForConstructor.add(child);
+			boolean isNonNull = findNonNullAnnotations(fieldDecl).length != 0;
+			if ( (isFinal || isNonNull) && fieldDecl.initialization == null ) nodesForConstructor.add(child);
 			new HandleGetter().generateGetterForField(child, annotationNode.get());
 			if ( !isFinal ) new HandleSetter().generateSetterForField(child, annotationNode.get());
 		}
@@ -139,18 +140,27 @@ public class HandleData implements EclipseAnnotationHandler<Data> {
 		
 		List<Argument> args = new ArrayList<Argument>();
 		List<Statement> assigns = new ArrayList<Statement>();
+		List<Statement> nullChecks = new ArrayList<Statement>();
 		
 		for ( Node fieldNode : fields ) {
 			FieldDeclaration field = (FieldDeclaration) fieldNode.get();
 			FieldReference thisX = new FieldReference(("this." + new String(field.name)).toCharArray(), p);
 			thisX.receiver = new ThisReference((int)(p >> 32), (int)p);
 			thisX.token = field.name;
+			
 			assigns.add(new Assignment(thisX, new SingleNameReference(field.name, p), (int)p));
 			long fieldPos = (((long)field.sourceStart) << 32) | field.sourceEnd;
-			args.add(new Argument(field.name, fieldPos, copyType(field.type), 0));
+			Argument argument = new Argument(field.name, fieldPos, copyType(field.type), 0);
+			Annotation[] nonNulls = findNonNullAnnotations(field);
+			if (nonNulls.length != 0) {
+				nullChecks.add(generateNullCheck(field));
+				argument.annotations = copyAnnotations(nonNulls);
+			}
+			args.add(argument);
 		}
 		
-		constructor.statements = assigns.isEmpty() ? null : assigns.toArray(new Statement[assigns.size()]);
+		nullChecks.addAll(assigns);
+		constructor.statements = nullChecks.isEmpty() ? null : nullChecks.toArray(new Statement[nullChecks.size()]);
 		constructor.arguments = args.isEmpty() ? null : args.toArray(new Argument[args.size()]);
 		return constructor;
 	}
@@ -188,6 +198,12 @@ public class HandleData implements EclipseAnnotationHandler<Data> {
 			FieldDeclaration field = (FieldDeclaration) fieldNode.get();
 			long fieldPos = (((long)field.sourceStart) << 32) | field.sourceEnd;
 			assigns.add(new SingleNameReference(field.name, fieldPos));
+			
+			Argument argument = new Argument(field.name, fieldPos, copyType(field.type), 0);
+			Annotation[] nonNulls = findNonNullAnnotations(field);
+			if (nonNulls.length != 0) {
+				argument.annotations = copyAnnotations(nonNulls);
+			}
 			args.add(new Argument(field.name, fieldPos, copyType(field.type), 0));
 		}