aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Molodetskikh <yalterz@gmail.com>2025-01-04 10:14:51 +0300
committerIvan Molodetskikh <yalterz@gmail.com>2025-01-04 11:22:56 +0300
commita2f9d132a088e399fb1f292d84d3d3862127f02e (patch)
tree0e04941d8ae35be9362c53f8d41177cc71e24214
parent1973b97cc2a51d697add3d9ad7210a4e6eba9183 (diff)
downloadniri-a2f9d132a088e399fb1f292d84d3d3862127f02e.tar.gz
niri-a2f9d132a088e399fb1f292d84d3d3862127f02e.tar.bz2
niri-a2f9d132a088e399fb1f292d84d3d3862127f02e.zip
Migrate to new Rectangle functions
-rw-r--r--niri-visual-tests/src/cases/gradient_angle.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_area.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklab.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklab_alpha.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklch_alpha.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklch_decreasing.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklch_increasing.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklch_longer.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_oklch_shorter.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_srgb.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_srgb_alpha.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_srgblinear.rs8
-rw-r--r--niri-visual-tests/src/cases/gradient_srgblinear_alpha.rs8
-rw-r--r--niri-visual-tests/src/cases/tile.rs2
-rw-r--r--niri-visual-tests/src/smithay_view.rs2
-rw-r--r--src/handlers/xdg_shell.rs2
-rw-r--r--src/layout/floating.rs4
-rw-r--r--src/layout/focus_ring.rs13
-rw-r--r--src/layout/mod.rs14
-rw-r--r--src/layout/monitor.rs16
-rw-r--r--src/layout/opening_window.rs2
-rw-r--r--src/layout/scrolling.rs22
-rw-r--r--src/layout/tile.rs12
-rw-r--r--src/layout/workspace.rs8
-rw-r--r--src/niri.rs26
-rw-r--r--src/protocols/screencopy.rs4
-rw-r--r--src/render_helpers/clipped_surface.rs24
-rw-r--r--src/render_helpers/damage.rs2
-rw-r--r--src/render_helpers/mod.rs4
-rw-r--r--src/render_helpers/resize.rs2
-rw-r--r--src/render_helpers/shader_element.rs8
-rw-r--r--src/render_helpers/solid_color.rs7
-rw-r--r--src/render_helpers/texture.rs6
-rw-r--r--src/ui/screenshot_ui.rs25
-rw-r--r--src/utils/mod.rs4
-rw-r--r--src/window/mapped.rs6
36 files changed, 160 insertions, 159 deletions
diff --git a/niri-visual-tests/src/cases/gradient_angle.rs b/niri-visual-tests/src/cases/gradient_angle.rs
index 39a2e4ef..807e7aa6 100644
--- a/niri-visual-tests/src/cases/gradient_angle.rs
+++ b/niri-visual-tests/src/cases/gradient_angle.rs
@@ -5,7 +5,7 @@ use niri::render_helpers::border::BorderRenderElement;
use niri_config::{Color, CornerRadius, GradientInterpolation};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -50,16 +50,16 @@ impl TestCase for GradientAngle {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 4, size.h / 4);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
GradientInterpolation::default(),
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
self.angle - FRAC_PI_2,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_area.rs b/niri-visual-tests/src/cases/gradient_area.rs
index 6f0cf4f3..73b71ce9 100644
--- a/niri-visual-tests/src/cases/gradient_area.rs
+++ b/niri-visual-tests/src/cases/gradient_area.rs
@@ -65,8 +65,8 @@ impl TestCase for GradientArea {
let f = (self.progress.sin() + 1.) / 2.;
let (a, b) = (size.w / 4, size.h / 4);
- let rect_size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), rect_size).to_f64();
+ let rect_size = Size::from((size.w - a * 2, size.h - b * 2));
+ let area = Rectangle::new(Point::from((a, b)), rect_size).to_f64();
let g_size = Size::from((
(size.w as f32 / 8. + size.w as f32 / 8. * 7. * f).round() as i32,
@@ -74,7 +74,7 @@ impl TestCase for GradientArea {
));
let g_loc = Point::from(((size.w - g_size.w) / 2, (size.h - g_size.h) / 2)).to_f64();
let g_size = g_size.to_f64();
- let mut g_area = Rectangle::from_loc_and_size(g_loc, g_size);
+ let mut g_area = Rectangle::new(g_loc, g_size);
g_area.loc -= area.loc;
self.border.update_render_elements(
@@ -99,7 +99,7 @@ impl TestCase for GradientArea {
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
FRAC_PI_4,
- Rectangle::from_loc_and_size((0, 0), rect_size).to_f64(),
+ Rectangle::from_size(rect_size).to_f64(),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklab.rs b/niri-visual-tests/src/cases/gradient_oklab.rs
index eac2aaf0..8230be99 100644
--- a/niri-visual-tests/src/cases/gradient_oklab.rs
+++ b/niri-visual-tests/src/cases/gradient_oklab.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientOklab {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklab_alpha.rs b/niri-visual-tests/src/cases/gradient_oklab_alpha.rs
index e9bdcf17..372bfb47 100644
--- a/niri-visual-tests/src/cases/gradient_oklab_alpha.rs
+++ b/niri-visual-tests/src/cases/gradient_oklab_alpha.rs
@@ -2,7 +2,7 @@ use niri::render_helpers::border::BorderRenderElement;
use niri_config::{Color, CornerRadius, GradientColorSpace, GradientInterpolation};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -29,16 +29,16 @@ impl TestCase for GradientOklabAlpha {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 0.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklch_alpha.rs b/niri-visual-tests/src/cases/gradient_oklch_alpha.rs
index 695dc2b8..0c649b0d 100644
--- a/niri-visual-tests/src/cases/gradient_oklch_alpha.rs
+++ b/niri-visual-tests/src/cases/gradient_oklch_alpha.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientOklchAlpha {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 0.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklch_decreasing.rs b/niri-visual-tests/src/cases/gradient_oklch_decreasing.rs
index 208dd9b0..b693e032 100644
--- a/niri-visual-tests/src/cases/gradient_oklch_decreasing.rs
+++ b/niri-visual-tests/src/cases/gradient_oklch_decreasing.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientOklchDecreasing {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklch_increasing.rs b/niri-visual-tests/src/cases/gradient_oklch_increasing.rs
index 92beca2c..e562f170 100644
--- a/niri-visual-tests/src/cases/gradient_oklch_increasing.rs
+++ b/niri-visual-tests/src/cases/gradient_oklch_increasing.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientOklchIncreasing {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklch_longer.rs b/niri-visual-tests/src/cases/gradient_oklch_longer.rs
index 924d56ce..bb3c5de0 100644
--- a/niri-visual-tests/src/cases/gradient_oklch_longer.rs
+++ b/niri-visual-tests/src/cases/gradient_oklch_longer.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientOklchLonger {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_oklch_shorter.rs b/niri-visual-tests/src/cases/gradient_oklch_shorter.rs
index fec62af3..d0103f30 100644
--- a/niri-visual-tests/src/cases/gradient_oklch_shorter.rs
+++ b/niri-visual-tests/src/cases/gradient_oklch_shorter.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientOklchShorter {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_srgb.rs b/niri-visual-tests/src/cases/gradient_srgb.rs
index a3182b80..6e704e29 100644
--- a/niri-visual-tests/src/cases/gradient_srgb.rs
+++ b/niri-visual-tests/src/cases/gradient_srgb.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientSrgb {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_srgb_alpha.rs b/niri-visual-tests/src/cases/gradient_srgb_alpha.rs
index f4542e79..237bfad4 100644
--- a/niri-visual-tests/src/cases/gradient_srgb_alpha.rs
+++ b/niri-visual-tests/src/cases/gradient_srgb_alpha.rs
@@ -2,7 +2,7 @@ use niri::render_helpers::border::BorderRenderElement;
use niri_config::{Color, CornerRadius, GradientColorSpace, GradientInterpolation};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -29,16 +29,16 @@ impl TestCase for GradientSrgbAlpha {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 0.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_srgblinear.rs b/niri-visual-tests/src/cases/gradient_srgblinear.rs
index dc18ce82..a154971c 100644
--- a/niri-visual-tests/src/cases/gradient_srgblinear.rs
+++ b/niri-visual-tests/src/cases/gradient_srgblinear.rs
@@ -4,7 +4,7 @@ use niri_config::{
};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -31,16 +31,16 @@ impl TestCase for GradientSrgbLinear {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 1.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/gradient_srgblinear_alpha.rs b/niri-visual-tests/src/cases/gradient_srgblinear_alpha.rs
index 3c73dc7c..847b3a6b 100644
--- a/niri-visual-tests/src/cases/gradient_srgblinear_alpha.rs
+++ b/niri-visual-tests/src/cases/gradient_srgblinear_alpha.rs
@@ -2,7 +2,7 @@ use niri::render_helpers::border::BorderRenderElement;
use niri_config::{Color, CornerRadius, GradientColorSpace, GradientInterpolation};
use smithay::backend::renderer::element::RenderElement;
use smithay::backend::renderer::gles::GlesRenderer;
-use smithay::utils::{Physical, Rectangle, Size};
+use smithay::utils::{Physical, Point, Rectangle, Size};
use super::{Args, TestCase};
@@ -29,16 +29,16 @@ impl TestCase for GradientSrgbLinearAlpha {
) -> Vec<Box<dyn RenderElement<GlesRenderer>>> {
let (a, b) = (size.w / 6, size.h / 3);
let size = (size.w - a * 2, size.h - b * 2);
- let area = Rectangle::from_loc_and_size((a, b), size).to_f64();
+ let area = Rectangle::new(Point::from((a, b)), Size::from(size)).to_f64();
[BorderRenderElement::new(
area.size,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
self.gradient_format,
Color::new_unpremul(1., 0., 0., 1.),
Color::new_unpremul(0., 1., 0., 0.),
0.,
- Rectangle::from_loc_and_size((0., 0.), area.size),
+ Rectangle::from_size(area.size),
0.,
CornerRadius::default(),
1.,
diff --git a/niri-visual-tests/src/cases/tile.rs b/niri-visual-tests/src/cases/tile.rs
index 0be80054..4bef6e40 100644
--- a/niri-visual-tests/src/cases/tile.rs
+++ b/niri-visual-tests/src/cases/tile.rs
@@ -114,7 +114,7 @@ impl TestCase for Tile {
self.tile.update(
true,
- Rectangle::from_loc_and_size((-location.x, -location.y), size.to_logical(1.)),
+ Rectangle::new(Point::from((-location.x, -location.y)), size.to_logical(1.)),
);
self.tile
.render(
diff --git a/niri-visual-tests/src/smithay_view.rs b/niri-visual-tests/src/smithay_view.rs
index 416729f0..7b8e77ee 100644
--- a/niri-visual-tests/src/smithay_view.rs
+++ b/niri-visual-tests/src/smithay_view.rs
@@ -145,7 +145,7 @@ mod imp {
case.advance_animations(self.clock.borrow_mut().now());
- let rect: Rectangle<i32, Physical> = Rectangle::from_loc_and_size((0, 0), size);
+ let rect: Rectangle<i32, Physical> = Rectangle::from_size(Size::from(size));
let elements = unsafe {
with_framebuffer_save_restore(renderer, |renderer| {
diff --git a/src/handlers/xdg_shell.rs b/src/handlers/xdg_shell.rs
index df8cb456..f9b41567 100644
--- a/src/handlers/xdg_shell.rs
+++ b/src/handlers/xdg_shell.rs
@@ -1050,7 +1050,7 @@ impl State {
// The target geometry for the positioner should be relative to its parent's geometry, so
// we will compute that here.
- let mut target = Rectangle::from_loc_and_size((0, 0), output_geo.size);
+ let mut target = Rectangle::from_size(output_geo.size);
target.loc -= layer_geo.loc;
target.loc -= get_popup_toplevel_coords(popup);
diff --git a/src/layout/floating.rs b/src/layout/floating.rs
index 1453415c..3705f9ef 100644
--- a/src/layout/floating.rs
+++ b/src/layout/floating.rs
@@ -330,7 +330,7 @@ impl<W: LayoutElement> FloatingSpace<W> {
let (tile, offset) = self.tiles_with_offsets().next()?;
let tile_size = tile.tile_size();
- let tile_rect = Rectangle::from_loc_and_size(offset, tile_size);
+ let tile_rect = Rectangle::new(offset, tile_size);
self.working_area.intersection(tile_rect)
}
@@ -1105,7 +1105,7 @@ impl<W: LayoutElement> FloatingSpace<W> {
pos: Point<f64, Logical>,
size: Size<f64, Logical>,
) -> Point<f64, Logical> {
- let mut rect = Rectangle::from_loc_and_size(pos, size);
+ let mut rect = Rectangle::new(pos, size);
clamp_preferring_top_left_in_area(self.working_area, &mut rect);
rect.loc
}
diff --git a/src/layout/focus_ring.rs b/src/layout/focus_ring.rs
index 7cd73760..b6c65b3f 100644
--- a/src/layout/focus_ring.rs
+++ b/src/layout/focus_ring.rs
@@ -94,7 +94,7 @@ impl FocusRing {
in_: GradientInterpolation::default(),
});
- let full_rect = Rectangle::from_loc_and_size((-width, -width), self.full_size);
+ let full_rect = Rectangle::new(Point::from((-width, -width)), self.full_size);
let gradient_area = match gradient.relative_to {
GradientRelativeTo::Window => full_rect,
GradientRelativeTo::WorkspaceView => view_rect,
@@ -178,12 +178,12 @@ impl FocusRing {
for (border, (loc, size)) in zip(&mut self.borders, zip(self.locations, self.sizes)) {
border.update(
size,
- Rectangle::from_loc_and_size(gradient_area.loc - loc, gradient_area.size),
+ Rectangle::new(gradient_area.loc - loc, gradient_area.size),
gradient.in_,
gradient.from,
gradient.to,
((gradient.angle as f32) - 90.).to_radians(),
- Rectangle::from_loc_and_size(full_rect.loc - loc, full_rect.size),
+ Rectangle::new(full_rect.loc - loc, full_rect.size),
rounded_corner_border_width,
radius,
scale as f32,
@@ -196,15 +196,12 @@ impl FocusRing {
self.borders[0].update(
self.sizes[0],
- Rectangle::from_loc_and_size(
- gradient_area.loc - self.locations[0],
- gradient_area.size,
- ),
+ Rectangle::new(gradient_area.loc - self.locations[0], gradient_area.size),
gradient.in_,
gradient.from,
gradient.to,
((gradient.angle as f32) - 90.).to_radians(),
- Rectangle::from_loc_and_size(full_rect.loc - self.locations[0], full_rect.size),
+ Rectangle::new(full_rect.loc - self.locations[0], full_rect.size),
rounded_corner_border_width,
radius,
scale as f32,
diff --git a/src/layout/mod.rs b/src/layout/mod.rs
index 081a5f35..4923282b 100644
--- a/src/layout/mod.rs
+++ b/src/layout/mod.rs
@@ -1289,7 +1289,7 @@ impl<W: LayoutElement> Layout<W> {
// window geometry.
let width = move_.tile.window_size().w;
let height = output_size(&move_.output).h;
- let mut target = Rectangle::from_loc_and_size((0., 0.), (width, height));
+ let mut target = Rectangle::from_size(Size::from((width, height)));
// FIXME: ideally this shouldn't include the tile render offset, but the code
// duplication would be a bit annoying for this edge case.
target.loc.y -= move_.tile_render_location().y;
@@ -2405,10 +2405,8 @@ impl<W: LayoutElement> Layout<W> {
if let Some(InteractiveMoveState::Moving(move_)) = &mut self.interactive_move {
if output.map_or(true, |output| move_.output == *output) {
let pos_within_output = move_.tile_render_location();
- let view_rect = Rectangle::from_loc_and_size(
- pos_within_output.upscale(-1.),
- output_size(&move_.output),
- );
+ let view_rect =
+ Rectangle::new(pos_within_output.upscale(-1.), output_size(&move_.output));
move_.tile.update(true, view_rect);
}
}
@@ -4121,7 +4119,7 @@ mod tests {
id,
parent_id: None,
is_floating: false,
- bbox: Rectangle::from_loc_and_size((0, 0), (100, 200)),
+ bbox: Rectangle::from_size(Size::from((100, 200))),
min_max_size: Default::default(),
}
}
@@ -4295,7 +4293,7 @@ mod tests {
any::<(i16, i16, u16, u16)>().prop_map(|(x, y, w, h)| {
let loc: Point<i32, _> = Point::from((x.into(), y.into()));
let size: Size<i32, _> = Size::from((w.max(1).into(), h.max(1).into()));
- Rectangle::from_loc_and_size(loc, size)
+ Rectangle::new(loc, size)
})
}
@@ -6078,7 +6076,7 @@ mod tests {
Op::AddWindow {
params: TestWindowParams {
- bbox: Rectangle::from_loc_and_size((0, 0), (1280, 200)),
+ bbox: Rectangle::from_size(Size::from((1280, 200))),
..TestWindowParams::new(1)
},
}
diff --git a/src/layout/monitor.rs b/src/layout/monitor.rs
index 13079319..2de3c760 100644
--- a/src/layout/monitor.rs
+++ b/