1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
|
use std::fmt::{self, Write as _};
use insta::assert_snapshot;
use niri_config::Config;
use rayon::iter::{IntoParallelIterator, ParallelIterator};
use super::*;
use crate::utils::with_toplevel_role;
#[test]
fn simple_no_workspaces() {
let mut f = Fixture::new();
let id = f.add_client();
let window = f.client(id).create_window();
let surface = window.surface.clone();
window.commit();
f.roundtrip(id);
let window = f.client(id).window(&surface);
assert_snapshot!(
window.format_recent_configures(),
@"size: 0 × 0, bounds: 0 × 0, states: []"
);
window.attach_new_buffer();
window.set_size(100, 100);
window.ack_last_and_commit();
f.double_roundtrip(id);
let window = f.client(id).window(&surface);
assert_snapshot!(
window.format_recent_configures(),
@"size: 100 × 688, bounds: 1248 × 688, states: []"
);
}
#[test]
fn simple() {
let mut f = Fixture::new();
f.add_output(1, (1920, 1080));
let id = f.add_client();
let window = f.client(id).create_window();
let surface = window.surface.clone();
window.commit();
f.roundtrip(id);
let window = f.client(id).window(&surface);
assert_snapshot!(
window.format_recent_configures(),
@"size: 936 × 1048, bounds: 1888 × 1048, states: []"
);
window.attach_new_buffer();
window.ack_last_and_commit();
f.double_roundtrip(id);
let window = f.client(id).window(&surface);
assert_snapshot!(
window.format_recent_configures(),
@"size: 936 × 1048, bounds: 1888 × 1048, states: [Activated]"
);
}
#[test]
fn dont_ack_initial_configure() {
let mut f = Fixture::new();
f.add_output(1, (1920, 1080));
let id = f.add_client();
let window = f.client(id).create_window();
let surface = window.surface.clone();
window.commit();
f.roundtrip(id);
let window = f.client(id).window(&surface);
window.attach_new_buffer();
// Don't ack the configure.
window.commit();
f.double_roundtrip(id);
// FIXME: Technically this is a protocol violation but uh. Smithay currently doesn't check it,
// and I'm not sure if it can be done generically in Smithay (because a compositor may not use
// its rendering helpers). I might add a check in niri itself sometime; I'm just not sure if
// there might be clients that this could break.
let window = f.client(id).window(&surface);
assert_snapshot!(
window.format_recent_configures(),
@r"
size: 936 × 1048, bounds: 1888 × 1048, states: []
size: 936 × 1048, bounds: 1888 × 1048, states: [Activated]
"
);
}
#[derive(Clone, Copy)]
enum WantFullscreen {
No,
UnsetBeforeInitial,
BeforeInitial(Option<&'static str>),
UnsetAfterInitial,
AfterInitial(Option<&'static str>),
}
impl fmt::Display for WantFullscreen {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
WantFullscreen::No => write!(f, "U")?,
WantFullscreen::UnsetBeforeInitial => write!(f, "BU")?,
WantFullscreen::UnsetAfterInitial => write!(f, "AA")?,
WantFullscreen::BeforeInitial(m) => write!(f, "B{}", m.unwrap_or("N"))?,
WantFullscreen::AfterInitial(m) => write!(f, "A{}", m.unwrap_or("N"))?,
}
Ok(())
}
}
#[derive(Clone, Copy)]
enum SetParent {
BeforeInitial(&'static str),
AfterInitial(&'static str),
}
impl fmt::Display for SetParent {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
SetParent::BeforeInitial(m) => write!(f, "B{m}")?,
SetParent::AfterInitial(m) => write!(f, "A{m}")?,
}
Ok(())
}
}
#[test]
fn target_output_and_workspaces() {
// Here we test a massive powerset of settings that can affect where a window opens:
//
// * open-on-workspace
// * open-on-output
// * has parent (windows will open next to their parent)
// * want fullscreen (windows can request the target fullscreen output)
// * open-fullscreen (can deny the fullscreen request)
let open_on_workspace = [None, Some("1"), Some("2")];
let open_on_output = [None, Some("1"), Some("2")];
let open_fullscreen = [None, Some("false"), Some("true")];
let want_fullscreen = [
WantFullscreen::No,
WantFullscreen::UnsetBeforeInitial, // GTK 4
WantFullscreen::BeforeInitial(None),
WantFullscreen::BeforeInitial(Some("1")),
WantFullscreen::BeforeInitial(Some("2")),
WantFullscreen::UnsetAfterInitial,
// mpv, osu!
WantFullscreen::AfterInitial(None),
WantFullscreen::AfterInitial(Some("1")),
WantFullscreen::AfterInitial(Some("2")),
];
let set_parent = [
None,
Some(SetParent::BeforeInitial("1")),
Some(SetParent::BeforeInitial("2")),
Some(SetParent::AfterInitial("1")),
Some(SetParent::AfterInitial("2")),
];
let mut powerset = Vec::new();
for ws in open_on_workspace {
for out in open_on_output {
for fs in open_fullscreen {
for wfs in want_fullscreen {
for sp in set_parent {
powerset.push((ws, out, fs, wfs, sp));
}
}
}
}
}
powerset.into_par_iter().for_each(|(ws, out, fs, wfs, sp)| {
check_target_output_and_workspace(ws, out, fs, wfs, sp);
});
}
fn check_target_output_and_workspace(
open_on_workspace: Option<&str>,
open_on_output: Option<&str>,
open_fullscreen: Option<&str>,
want_fullscreen: WantFullscreen,
set_parent: Option<SetParent>,
) {
let mut snapshot_desc = Vec::new();
let mut snapshot_suffix = Vec::new();
let mut config = String::from(
r##"
workspace "ws-1" {
open-on-output "headless-1"
}
workspace "ws-2" {
open-on-output "headless-2"
}
window-rule {
exclude title="parent"
"##,
);
if let Some(x) = open_on_workspace {
writeln!(config, " open-on-workspace \"ws-{x}\"").unwrap();
snapshot_suffix.push(format!("ws{x}"));
}
if let Some(x) = open_on_output {
writeln!(config, " open-on-output \"headless-{x}\"").unwrap();
snapshot_suffix.push(format!("out{x}"));
}
if let Some(x) = open_fullscreen {
writeln!(config, " open-fullscreen {x}").unwrap();
let x = if x == "true" { "T" } else { "F" };
snapshot_suffix.push(format!("fs{x}"));
}
config.push('}');
match &want_fullscreen {
WantFullscreen::No => (),
x => {
snapshot_desc.push(format!("want fullscreen: {x}"));
snapshot_suffix.push(format!("wfs{x}"));
}
}
if let Some(set_parent) = set_parent {
let mon = match set_parent {
SetParent::BeforeInitial(mon) => mon,
SetParent::AfterInitial(mon) => mon,
};
write!(
config,
"
window-rule {{
match title=\"parent\"
open-on-output \"headless-{mon}\"
}}"
)
.unwrap();
snapshot_desc.push(format!("set parent: {set_parent}"));
snapshot_suffix.push(format!("sp{set_parent}"));
}
snapshot_desc.push(format!("config:{config}"));
|