Update ch-1.pl

Iterate indices instead of substrings.

1 files changed, 2 insertions, 10 deletions

diff --git a/challenge-018/jaime/perl5/ch-1.pl b/challenge-018/jaime/perl5/ch-1.pl
index ce9415e8c2..eeb61845eb 100644
--- a/challenge-018/jaime/perl5/ch-1.pl
+++ b/challenge-018/jaime/perl5/ch-1.pl
@@ -4,18 +4,10 @@
 # Write a script that takes 2 or more strings as command line parameters
 # and print the longest common substring.
 
-sub of_size {
-    my ($n,$s) = @_;
-    my @subs = ();
-    for (my $i = 0; ($i+$n) <= length $s; $i++) {
-	push @subs, substr($s,$i,$n);
-    }
-    return @subs; #substrings of $s of length $n.
-}
-
 my $head = shift;
 for my $n (reverse 1..(length $head)) {
-    for my $s (of_size($n,$head)) {
+    for my $i (0..((length $head)-$n)) {
+	my $s = substr($head,$i,$n);
 	if (@ARGV == grep(/$s/,@ARGV)) {
 	    print "$s\n";
 	    exit;