diff options
| author | drbaggy <js5@sanger.ac.uk> | 2021-10-19 19:46:31 +0100 |
|---|---|---|
| committer | drbaggy <js5@sanger.ac.uk> | 2021-10-19 19:46:31 +0100 |
| commit | a4bcff6a73947487e3e38ea21b9e2e6acade2ebf (patch) | |
| tree | aa3689c888947c41eb2375b547c08cc21e28786e | |
| parent | a9ca60217253cfa36cd97314e99741214db1704c (diff) | |
| download | perlweeklychallenge-club-a4bcff6a73947487e3e38ea21b9e2e6acade2ebf.tar.gz perlweeklychallenge-club-a4bcff6a73947487e3e38ea21b9e2e6acade2ebf.tar.bz2 perlweeklychallenge-club-a4bcff6a73947487e3e38ea21b9e2e6acade2ebf.zip | |
shorter
| -rw-r--r-- | challenge-135/james-smith/perl/ch-1.pl | 2 | ||||
| -rw-r--r-- | challenge-135/james-smith/perl/ch-2.pl | 10 |
2 files changed, 6 insertions, 6 deletions
diff --git a/challenge-135/james-smith/perl/ch-1.pl b/challenge-135/james-smith/perl/ch-1.pl index dbbf9a33b7..cf1329eb75 100644 --- a/challenge-135/james-smith/perl/ch-1.pl +++ b/challenge-135/james-smith/perl/ch-1.pl @@ -35,6 +35,6 @@ sub middle3 { sub middle3compact { my$l=length(my$n=abs$_[0]); - return$l<3?'Too short':$l%2?substr$n,$l/2-1,3:'Even digits'; + return$l<3?'Too short':$l%2?substr$n,$l/2-1,3:'Even digits' } diff --git a/challenge-135/james-smith/perl/ch-2.pl b/challenge-135/james-smith/perl/ch-2.pl index 9c09365af4..4af6ee9a24 100644 --- a/challenge-135/james-smith/perl/ch-2.pl +++ b/challenge-135/james-smith/perl/ch-2.pl @@ -18,7 +18,7 @@ my @TESTS = ( [ 'BG03Y86', 1 ], ); -is( is_sedol($_->[0]), $_->[1] ) for @TESTS; +is( is_sedol( $_->[0]), $_->[1] ) for @TESTS; is( is_sedol_compact($_->[0]), $_->[1] ) for @TESTS; done_testing(); @@ -38,9 +38,9 @@ sub is_sedol { } sub is_sedol_compact { - return 0 unless$_[0]=~/^[0-9B-HJ-NP-TW-Z]{6}\d$/; - my($t,@w)=qw(0 1 3 1 7 3 9 1); - $t+=(/\d/?$_:-55+ord$_)*shift@w for split//,$_[0]; - $t%10?0:1; + return 0if$_[0]!~/^[0-9B-HJ-NP-TW-Z]{6}\d$/; + my($t,@w)=qw(0 1 9 3 7 1 3 1); + $t+=(/\d/?$_:-55+ord$_)*pop@w for split//,$_[0]; + $t%10?0:1 } |