Adding tests and fix stupid typo bugs. Small optimization

2 files changed, 11 insertions, 5 deletions

diff --git a/challenge-199/perlboy1967/perl/ch-1.pl b/challenge-199/perlboy1967/perl/ch-1.pl
index a1389d07e4..868028af41 100755
--- a/challenge-199/perlboy1967/perl/ch-1.pl
+++ b/challenge-199/perlboy1967/perl/ch-1.pl
@@ -26,13 +26,15 @@ use Test::More;
 use Test::Deep qw(cmp_deeply);
 
 
-sub goodPairs {
+sub goodPairs (@) {
   my $ar = [];
-  for my $i (0 .. scalar(@_) - 1) {
+
+  for my $i (0 .. scalar(@_) - 2) {
     for my $j ($i + 1 .. scalar(@_) - 1) {
       push(@$ar,[$i,$j]) if ($_[$i] == $_[$j] and $i < $j);
     }
   }
+
   return $ar;
 }
 
@@ -40,5 +42,6 @@ sub goodPairs {
 cmp_deeply(goodPairs(1,2,3,1,1,3),[[0,3],[0,4],[2,5],[3,4]]);
 cmp_deeply(goodPairs(1,2,3),[]);
 cmp_deeply(goodPairs(1,1,1,1),[[0,1],[0,2],[0,3],[1,2],[1,3],[2,3]]);
+cmp_deeply(goodPairs(1,2,1,2),[[0,2],[1,3]]);
 
 done_testing;
diff --git a/challenge-199/perlboy1967/perl/ch-2.pl b/challenge-199/perlboy1967/perl/ch-2.pl
index 523c272b95..07c63ec12d 100755
--- a/challenge-199/perlboy1967/perl/ch-2.pl
+++ b/challenge-199/perlboy1967/perl/ch-2.pl
@@ -35,9 +35,10 @@ sub goodTriplets ($$$\@) {
   my ($x,$y,$z,$arIn) = @_;
 
   my $arOut = [];
-  for my $i (0 .. scalar(@_) - 1) {
-    for my $j ($i + 1 .. scalar(@_) - 1) {
-      for my $k ($j + 1 .. scalar(@_) - 1) {
+
+  for my $i (0 .. scalar(@$arIn) - 3) {
+    for my $j ($i + 1 .. scalar(@$arIn) - 2) {
+      for my $k ($j + 1 .. scalar(@$arIn) - 1) {
         push(@$arOut,[$$arIn[$i],$$arIn[$j],$$arIn[$k]]) 
           if (abs($$arIn[$i] - $$arIn[$j]) <= $x and
               abs($$arIn[$j] - $$arIn[$k]) <= $y and
@@ -54,5 +55,7 @@ cmp_deeply(goodTriplets(7,2,3,@{[3,0,1,1,9,7]}),
            [[3,0,1],[3,0,1],[3,1,1],[0,1,1]]);
 cmp_deeply(goodTriplets(0,0,1,@{[1,1,2,2,3]}),
            []);
+cmp_deeply(goodTriplets(3,2,1,@{[1,4,2,0,3]}),
+           [[1,4,2],[1,2,0],[4,2,3]]);
 
 done_testing;