summaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authortemperrr <temperrr@users.noreply.github.com>2021-11-08 17:03:30 +0100
committerGitHub <noreply@github.com>2021-11-08 17:03:30 +0100
commit8fd18e46c6096300ce47f983f389288940a488a8 (patch)
tree99be74fef34ea2085d792a3c455380a6b4b50f44 /docs
parent9cbc18054e4ab81b09e235f5bbf804629fc77c3d (diff)
downloadwiki-8fd18e46c6096300ce47f983f389288940a488a8.tar.gz
wiki-8fd18e46c6096300ce47f983f389288940a488a8.tar.bz2
wiki-8fd18e46c6096300ce47f983f389288940a488a8.zip
Update how to test a pr (#649)
* Extra note git pull origin pull... Added a note what to do when you get merge conflicts and to be aware of this. * docker instructions windows * Update docs/how-to-test-a-pr.md
Diffstat (limited to 'docs')
-rw-r--r--docs/how-to-test-a-pr.md6
1 files changed, 5 insertions, 1 deletions
diff --git a/docs/how-to-test-a-pr.md b/docs/how-to-test-a-pr.md
index c48b49b..c760ec8 100644
--- a/docs/how-to-test-a-pr.md
+++ b/docs/how-to-test-a-pr.md
@@ -69,6 +69,9 @@ The terminal will prompt an editor (usually `nano` or `vim`) that asks to save t
You can read more about the `git` configuration and its default editor [here](http://web.mit.edu/6.005/www/fa14/tutorial/git/config.html).
+- Note: Check the message in your console. If it states 'Automatic merge failed; fix conflicts and then commit the result', you should report back to the PR, asking the Developer to please fix the merge conflicts, and remove the 'waiting to be tested' label and attach a 'merge conflict' label.
+
+
## Update your local server to apply the changes
Now you simply need to update your local server with the new changes. The procedure is analogue to a normal server update.
@@ -91,7 +94,8 @@ Then start the server just the way you always do.
If you are using the Docker setup, you can simply trigger the recompilation by running:
-```./bin/acore-docker-build```
+Linux: ```./bin/acore-docker-build```
+Windows: ```./acore.sh docker build```
then to launch the server you have to destroy and recreate the containers using `docker-compose down` and `docker-compose up`.