implement error correctly for the error types

3 files changed, 42 insertions, 4 deletions

diff --git a/Cargo.toml b/Cargo.toml
index 83cb2ec..8be897a 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -4,7 +4,6 @@ version = "0.1.0"
 authors = ["Joey Sacchini <joey@sacchini.net>"]
 edition = "2018"
 license = "Apache-2.0"
-license-file = "LICENSE"
 keywords = ["minecraft", "games", "protocol", "serialziers", "deserializers", "packets", "mc"]
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
diff --git a/src/deserialize.rs b/src/deserialize.rs
index f87cb49..f6eca35 100644
--- a/src/deserialize.rs
+++ b/src/deserialize.rs
@@ -1,7 +1,7 @@
 use crate::types::VarInt;
 use std::string::FromUtf8Error;
+use std::fmt;
 
-#[derive(Debug)]
 pub enum DeserializeErr {
     Eof,
     VarNumTooLong(Vec<u8>),
@@ -15,6 +15,30 @@ pub enum DeserializeErr {
     FailedJsonDeserialize(String),
 }
 
+impl fmt::Display for DeserializeErr {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        use DeserializeErr::*;
+        match self {
+            Eof => f.write_str("unexpected eof"),
+            VarNumTooLong(data) => f.write_fmt(format_args!("var num is too long: data={:?}", data)),
+            NegativeLength(data) => f.write_fmt(format_args!("negative length encountered {:?}", data)),
+            BadStringEncoding(data) => f.write_fmt(format_args!("failed to decode string, utf error: {:?}", data)),
+            InvalidBool(value) => f.write_fmt(format_args!("could not decode boolean, unexpected byte: {:?}", value)),
+            NbtUnknownTagType(data) => f.write_fmt(format_args!("nbt: bad tag type {}", data)),
+            NbtBadLength(data) => f.write_fmt(format_args!("nbt: bad length {:?}", data)),
+            NbtInvalidStartTag(data) => f.write_fmt(format_args!("nbt: unexpected start tag id: {:?}", data)),
+            CannotUnderstandValue(data) => f.write_fmt(format_args!("cannot understand value: {:?}", data)),
+            FailedJsonDeserialize(data) => f.write_fmt(format_args!("failed to deserialize json: {:?}", data)),
+        }
+    }
+}
+
+impl fmt::Debug for DeserializeErr {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        <dyn fmt::Display>::fmt(self, f)
+    }
+}
+
 impl<'b, R> Into<DeserializeResult<'b, R>> for DeserializeErr {
     #[inline]
     fn into(self) -> DeserializeResult<'b, R> {
diff --git a/src/serialize.rs b/src/serialize.rs
index 3239b66..65e2d80 100644
--- a/src/serialize.rs
+++ b/src/serialize.rs
@@ -1,7 +1,22 @@
-#[derive(Debug)]
+use std::fmt;
+
 pub enum SerializeErr {
     FailedJsonEncode(String),
-    InconsistentPlayerActions(String),
+}
+
+impl fmt::Display for SerializeErr {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        use SerializeErr::*;
+        match self {
+            FailedJsonEncode(data) => f.write_fmt(format_args!("failed to serialize json: {:?}", data)),
+        }
+    }
+}
+
+impl fmt::Debug for SerializeErr {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        <dyn fmt::Display>::fmt(self, f)
+    }
 }
 
 pub type SerializeResult = Result<(), SerializeErr>;