Metal detector solver updates

- Move beacon beam rendering related code into RenderUtils
- Show beacons and labels for metal detector locations
- Replace code that Hypixel would likely ban as X-Ray with code based on
  eliminating duplicate Y values. The number of unique locations for the
  new code to work is still 2-3, but results in odd locations being
  treated as valid (mid-air, outside Mines, blocks not exposed to air).
  This could be made better by detecting the NPCs coordinates to filter
  valid coordinates.
  - Add a TODO in reset to add a delay after a chest is found

1 files changed, 74 insertions, 30 deletions

diff --git a/src/main/java/io/github/moulberry/notenoughupdates/miscfeatures/CrystalMetalDetectorSolver.java b/src/main/java/io/github/moulberry/notenoughupdates/miscfeatures/CrystalMetalDetectorSolver.java
index 73e2b412..3fbff9c8 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/miscfeatures/CrystalMetalDetectorSolver.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/miscfeatures/CrystalMetalDetectorSolver.java
@@ -11,82 +11,106 @@ import java.util.List;
 
 public class CrystalMetalDetectorSolver {
     private static final Minecraft mc = Minecraft.getMinecraft();
-    private static BlockPos prevPos;
-    private static double prevDist = 0;
+    private static BlockPos prevPlayerPos;
+    private static double prevDistToTreasure = 0;
     private static List<BlockPos> possibleBlocks = new ArrayList<>();
     private static final List<BlockPos> locations = new ArrayList<>();
 
     public static void process(IChatComponent message) {
         if (SBInfo.getInstance().getLocation() != null && SBInfo.getInstance().getLocation().equals("crystal_hollows")
                 && message.getUnformattedText().contains("TREASURE: ")) {
-            double dist = Double.parseDouble(message.getUnformattedText().split("TREASURE: ")[1].split("m")[0].replaceAll("(?!\\.)\\D", ""));
-            if (NotEnoughUpdates.INSTANCE.config.mining.metalDetectorEnabled && prevDist == dist && prevPos.getX() == mc.thePlayer.getPosition().getX() &&
-                    prevPos.getY() == mc.thePlayer.getPosition().getY() &&
-                    prevPos.getZ() == mc.thePlayer.getPosition().getZ() && !locations.contains(mc.thePlayer.getPosition())) {
+            double distToTreasure = Double.parseDouble(message.getUnformattedText().split("TREASURE: ")[1].split("m")[0].replaceAll("(?!\\.)\\D", ""));
+            if (NotEnoughUpdates.INSTANCE.config.mining.metalDetectorEnabled && prevDistToTreasure == distToTreasure &&
+                    prevPlayerPos.getX() == mc.thePlayer.getPosition().getX() &&
+                    prevPlayerPos.getY() == mc.thePlayer.getPosition().getY() &&
+                    prevPlayerPos.getZ() == mc.thePlayer.getPosition().getZ() && !locations.contains(mc.thePlayer.getPosition())) {
                 if (possibleBlocks.size() == 0) {
                     locations.add(mc.thePlayer.getPosition());
-                    for (int zOffset = (int) Math.floor(-dist); zOffset <= Math.ceil(dist); zOffset++) {
+                    for (int zOffset = (int) Math.floor(-distToTreasure); zOffset <= Math.ceil(distToTreasure); zOffset++) {
                         for (int y = 65; y <= 75; y++) {
                             double calculatedDist = 0;
                             int xOffset = 0;
-                            while (calculatedDist < dist) {
+                            while (calculatedDist < distToTreasure) {
                                 BlockPos pos = new BlockPos(Math.floor(mc.thePlayer.posX) + xOffset,
                                         y, Math.floor(mc.thePlayer.posZ) + zOffset);
-                                BlockPos above = new BlockPos(Math.floor(mc.thePlayer.posX) + xOffset,
-                                        y + 1, Math.floor(mc.thePlayer.posZ) + zOffset);
                                 calculatedDist = getPlayerPos().distanceTo(new Vec3(pos).addVector(0D, 1D, 0D));
-                                if (round(calculatedDist, 1) == dist && treasureAllowed(pos) && !possibleBlocks.contains(pos) &&
-                                        mc.theWorld.getBlockState(above).getBlock().getRegistryName().equals("minecraft:air")) {
+                                if (round(calculatedDist, 1) == distToTreasure && !possibleBlocks.contains(pos)) {
                                     possibleBlocks.add(pos);
                                 }
                                 xOffset++;
                             }
                             xOffset = 0;
                             calculatedDist = 0;
-                            while (calculatedDist < dist) {
+                            while (calculatedDist < distToTreasure) {
                                 BlockPos pos = new BlockPos(Math.floor(mc.thePlayer.posX) - xOffset,
                                         y, Math.floor(mc.thePlayer.posZ) + zOffset);
-                                BlockPos above = new BlockPos(Math.floor(mc.thePlayer.posX) - xOffset,
-                                        y + 1, Math.floor(mc.thePlayer.posZ) + zOffset);
                                 calculatedDist = getPlayerPos().distanceTo(new Vec3(pos).addVector(0D, 1D, 0D));
-                                if (round(calculatedDist, 1) == dist && treasureAllowed(pos) && !possibleBlocks.contains(pos) &&
-                                        mc.theWorld.getBlockState(above).getBlock().getRegistryName().equals("minecraft:air")) {
+                                if (round(calculatedDist, 1) == distToTreasure && !possibleBlocks.contains(pos)) {
                                     possibleBlocks.add(pos);
                                 }
                                 xOffset++;
                             }
                         }
                     }
+                    removeDuplicates();
                     sendMessage();
                 } else if (possibleBlocks.size() != 1) {
                     locations.add(mc.thePlayer.getPosition());
                     List<BlockPos> temp = new ArrayList<>();
                     for (BlockPos pos : possibleBlocks) {
-                        if (round(getPlayerPos().distanceTo(new Vec3(pos).addVector(0D, 1D, 0D)), 1) == dist) {
+                        if (round(getPlayerPos().distanceTo(new Vec3(pos).addVector(0D, 1D, 0D)), 1) == distToTreasure) {
                             temp.add(pos);
                         }
                     }
                     possibleBlocks = temp;
+                    removeDuplicates();
                     sendMessage();
+                } else if (possibleBlocks.size() == 1) {
+                    BlockPos pos =  possibleBlocks.get(0);
+                    if (distToTreasure > (5 + getPlayerPos().distanceTo(new Vec3(pos)))) {
+                        mc.thePlayer.addChatMessage(new ChatComponentText(EnumChatFormatting.RED + "[NEU] Previous solution is invalid."));
+                        reset(false);
+                    }
                 }
+
             }
-            prevPos = mc.thePlayer.getPosition();
-            prevDist = dist;
+
+            prevPlayerPos = mc.thePlayer.getPosition();
+            prevDistToTreasure = distToTreasure;
         }
     }
 
-    public static void reset() {
+    public static void reset(Boolean chestFound) {
+        if (chestFound) {
+            // TODO: Add a delay to keep the old chest location from being treated as the new chest location
+        }
+
         possibleBlocks.clear();
         locations.clear();
     }
 
     public static void render(float partialTicks) {
+        int beaconRGB = 0xa839ce;
+
         if (SBInfo.getInstance().getLocation() != null && SBInfo.getInstance().getLocation().equals("crystal_hollows") &&
                 SBInfo.getInstance().location.equals("Mines of Divan")) {
+            BlockPos viewer = RenderUtils.getCurrentViewer(partialTicks);
+
             if (possibleBlocks.size() == 1) {
+                BlockPos block = possibleBlocks.get(0);
+                double x = block.getX() - viewer.getX();
+                double y = block.getY() - viewer.getY();
+                double z = block.getZ() - viewer.getZ();
+
+                RenderUtils.renderBeaconBeam(x, y, z, beaconRGB, 1.0f, partialTicks);
                 RenderUtils.renderWayPoint("Treasure", possibleBlocks.get(0).add(0, 2.5, 0), partialTicks);
             } else if (possibleBlocks.size() > 1 && NotEnoughUpdates.INSTANCE.config.mining.metalDetectorShowPossible) {
                 for (BlockPos block : possibleBlocks) {
+                    double x = block.getX() - viewer.getX();
+                    double y = block.getY() - viewer.getY();;
+                    double z = block.getZ() - viewer.getZ();;
+
+                    RenderUtils.renderBeaconBeam(x, y, z, beaconRGB, 1.0f, partialTicks);
                     RenderUtils.renderWayPoint("Possible Treasure Location", block.add(0, 2.5, 0), partialTicks);
                 }
             }
@@ -98,14 +122,34 @@ public class CrystalMetalDetectorSolver {
         return (double) Math.round(value * scale) / scale;
     }
 
-    private static boolean treasureAllowed(BlockPos pos) {
-        return mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:gold_block") ||
-                mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:prismarine") ||
-                mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:chest") ||
-                mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:stained_glass") ||
-                mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:stained_glass_pane") ||
-                mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:wool") ||
-                mc.theWorld.getBlockState(pos).getBlock().getRegistryName().equals("minecraft:stained_hardened_clay");
+    private static void removeDuplicates() {
+        if (possibleBlocks.size() > 1 && possibleBlocks.size() < 7) {
+            double firstX = possibleBlocks.get(0).getX();
+            double firstZ = possibleBlocks.get(0).getZ();
+            Boolean yOnlyDiffers = true;
+
+            double lowestY = possibleBlocks.get(0).getY();
+            int lowestYIndex = 0;
+
+            for (int i = 1; i < possibleBlocks.size(); i++) {
+                BlockPos block = possibleBlocks.get(i);
+                if (block.getX() != firstX || block.getZ() != firstZ) {
+                    yOnlyDiffers = false;
+                    break;
+                }
+
+                if (block.getY() < lowestY) {
+                    lowestY = block.getY();
+                    lowestYIndex = i;
+                }
+            }
+
+            if (yOnlyDiffers) {
+                List<BlockPos> temp = new ArrayList<>();
+                temp.add(possibleBlocks.get(lowestYIndex));
+                possibleBlocks = temp;
+            }
+        }
     }
 
     private static void sendMessage() {
@@ -114,7 +158,7 @@ public class CrystalMetalDetectorSolver {
                     + possibleBlocks.size()));
         } else if (possibleBlocks.size() == 0) {
             mc.thePlayer.addChatMessage(new ChatComponentText(EnumChatFormatting.RED + "[NEU] Failed to find solution."));
-            reset();
+            reset(false);
         } else {
             mc.thePlayer.addChatMessage(new ChatComponentText(EnumChatFormatting.YELLOW + "[NEU] Found solution."));
         }