summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJesse Plamondon-Willard <Pathoschild@users.noreply.github.com>2019-07-31 14:49:54 -0400
committerJesse Plamondon-Willard <Pathoschild@users.noreply.github.com>2019-09-14 18:59:50 -0400
commit85715988f987a2bf1e7016e9ad82e76ec44d4f94 (patch)
tree5d76c1357aa63884c817a4f0fa149230f7ea2da4
parentb0ec0de2ceff089189a5a1ff999ef86d246040b6 (diff)
downloadSMAPI-85715988f987a2bf1e7016e9ad82e76ec44d4f94.tar.gz
SMAPI-85715988f987a2bf1e7016e9ad82e76ec44d4f94.tar.bz2
SMAPI-85715988f987a2bf1e7016e9ad82e76ec44d4f94.zip
fix error when Chucklefish page doesn't exist for update checks
-rw-r--r--docs/release-notes.md6
-rw-r--r--src/SMAPI.Web/Framework/Clients/Chucklefish/ChucklefishClient.cs2
2 files changed, 5 insertions, 3 deletions
diff --git a/docs/release-notes.md b/docs/release-notes.md
index fd0cda51..9ee8ae8f 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -15,6 +15,10 @@ These changes have not been released yet.
* Save Backup now works in the background, to avoid affecting startup time for players with a large number of saves.
* Duplicate-mod errors now show the mod version in each folder.
* Updated mod compatibility list.
+ * Improved update checks:
+ * Update checks are now faster in some cases.
+ * Fixed error if a Nexus mod is marked as adult content.
+ * Fixed error if the Chucklefish page for an update key doesn't exist.
* Fixed mods needing to load custom `Map` assets before the game accesses them (SMAPI will now do so automatically).
* Fixed Save Backup not pruning old backups if they're uncompressed.
* Fixed issues when a farmhand reconnects before the game notices they're disconnected.
@@ -25,8 +29,6 @@ These changes have not been released yet.
* Fixed map reloads resetting tilesheet seasons.
* Fixed map reloads not updating door warps.
* Fixed outdoor tilesheets being seasonalised when added to an indoor location.
- * Fixed update checks failing for Nexus mods marked as adult content.
- * Fixed update checks not recognising releases on GitHub if they're not explicitly listed as update keys.
* For the mod compatibility list:
* Now loads faster (since data is fetched in a background service).
diff --git a/src/SMAPI.Web/Framework/Clients/Chucklefish/ChucklefishClient.cs b/src/SMAPI.Web/Framework/Clients/Chucklefish/ChucklefishClient.cs
index 2753e33a..939c32c6 100644
--- a/src/SMAPI.Web/Framework/Clients/Chucklefish/ChucklefishClient.cs
+++ b/src/SMAPI.Web/Framework/Clients/Chucklefish/ChucklefishClient.cs
@@ -45,7 +45,7 @@ namespace StardewModdingAPI.Web.Framework.Clients.Chucklefish
.GetAsync(string.Format(this.ModPageUrlFormat, id))
.AsString();
}
- catch (ApiException ex) when (ex.Status == HttpStatusCode.NotFound)
+ catch (ApiException ex) when (ex.Status == HttpStatusCode.NotFound || ex.Status == HttpStatusCode.Forbidden)
{
return null;
}