summaryrefslogtreecommitdiff
path: root/src/SMAPI
diff options
context:
space:
mode:
authorJesse Plamondon-Willard <github@jplamondonw.com>2018-01-12 01:24:49 -0500
committerJesse Plamondon-Willard <github@jplamondonw.com>2018-01-12 01:24:49 -0500
commit0ad9fbddddbf9edfd847c507d70e10d2f8ce559b (patch)
treea7bf3bd2b04767bbb0ad9c23fdb3e7ea0edee895 /src/SMAPI
parentdc2ceb39f31c35752c943b5052d5abaa7b6494fa (diff)
downloadSMAPI-0ad9fbddddbf9edfd847c507d70e10d2f8ce559b.tar.gz
SMAPI-0ad9fbddddbf9edfd847c507d70e10d2f8ce559b.tar.bz2
SMAPI-0ad9fbddddbf9edfd847c507d70e10d2f8ce559b.zip
fix semantic versions always ignoring `-0` tag (#421)
Diffstat (limited to 'src/SMAPI')
-rw-r--r--src/SMAPI/Framework/LegacyManifestVersion.cs26
-rw-r--r--src/SMAPI/Framework/Serialisation/SFieldConverter.cs2
-rw-r--r--src/SMAPI/StardewModdingAPI.csproj1
3 files changed, 28 insertions, 1 deletions
diff --git a/src/SMAPI/Framework/LegacyManifestVersion.cs b/src/SMAPI/Framework/LegacyManifestVersion.cs
new file mode 100644
index 00000000..454b9137
--- /dev/null
+++ b/src/SMAPI/Framework/LegacyManifestVersion.cs
@@ -0,0 +1,26 @@
+using Newtonsoft.Json;
+
+namespace StardewModdingAPI.Framework
+{
+ /// <summary>An implementation of <see cref="ISemanticVersion"/> that hamdles the legacy <see cref="IManifest"/> version format.</summary>
+ internal class LegacyManifestVersion : SemanticVersion
+ {
+ /*********
+ ** Public methods
+ *********/
+ /// <summary>Construct an instance.</summary>
+ /// <param name="majorVersion">The major version incremented for major API changes.</param>
+ /// <param name="minorVersion">The minor version incremented for backwards-compatible changes.</param>
+ /// <param name="patchVersion">The patch version for backwards-compatible bug fixes.</param>
+ /// <param name="build">An optional build tag.</param>
+ [JsonConstructor]
+ public LegacyManifestVersion(int majorVersion, int minorVersion, int patchVersion, string build = null)
+ : base(
+ majorVersion,
+ minorVersion,
+ patchVersion,
+ build != "0" ? build : null // '0' from incorrect examples in old SMAPI documentation
+ )
+ { }
+ }
+}
diff --git a/src/SMAPI/Framework/Serialisation/SFieldConverter.cs b/src/SMAPI/Framework/Serialisation/SFieldConverter.cs
index 917c950d..6e068599 100644
--- a/src/SMAPI/Framework/Serialisation/SFieldConverter.cs
+++ b/src/SMAPI/Framework/Serialisation/SFieldConverter.cs
@@ -51,7 +51,7 @@ namespace StardewModdingAPI.Framework.Serialisation
int minor = obj.Value<int>(nameof(ISemanticVersion.MinorVersion));
int patch = obj.Value<int>(nameof(ISemanticVersion.PatchVersion));
string build = obj.Value<string>(nameof(ISemanticVersion.Build));
- return new SemanticVersion(major, minor, patch, build);
+ return new LegacyManifestVersion(major, minor, patch, build);
}
case JTokenType.String:
diff --git a/src/SMAPI/StardewModdingAPI.csproj b/src/SMAPI/StardewModdingAPI.csproj
index f76ac439..c9c302f5 100644
--- a/src/SMAPI/StardewModdingAPI.csproj
+++ b/src/SMAPI/StardewModdingAPI.csproj
@@ -86,6 +86,7 @@
<Link>Properties\GlobalAssemblyInfo.cs</Link>
</Compile>
<Compile Include="Framework\Content\ContentCache.cs" />
+ <Compile Include="Framework\LegacyManifestVersion.cs" />
<Compile Include="Framework\Models\ModCompatibility.cs" />
<Compile Include="Framework\ModLoading\Finders\EventFinder.cs" />
<Compile Include="Framework\ModLoading\Finders\FieldFinder.cs" />