diff options
| author | Jesse Plamondon-Willard <github@jplamondonw.com> | 2018-04-18 20:58:25 -0400 |
|---|---|---|
| committer | Jesse Plamondon-Willard <github@jplamondonw.com> | 2018-04-18 20:58:25 -0400 |
| commit | e80e6564b374b9b5a37748f1a42e10025d92776f (patch) | |
| tree | c74c8cad7a37405ff1de7ffe00239913f50ca6c0 /src/SMAPI | |
| parent | c79601ad76c25c58e3810a746cfff1be6edba1e1 (diff) | |
| download | SMAPI-e80e6564b374b9b5a37748f1a42e10025d92776f.tar.gz SMAPI-e80e6564b374b9b5a37748f1a42e10025d92776f.tar.bz2 SMAPI-e80e6564b374b9b5a37748f1a42e10025d92776f.zip | |
detect broken references to fields which changed generic type (#453)
Previously generic types couldn't be compared correctly, since we'd end up with false differences like "Dictionary`1 != Dictionary<string, string>". That seems to be fixed now, possibly due to the PDB file being included.
Diffstat (limited to 'src/SMAPI')
| -rw-r--r-- | src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs index b5e45742..2cbb3a8e 100644 --- a/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs +++ b/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs @@ -59,10 +59,6 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders FieldReference fieldRef = RewriteHelper.AsFieldReference(instruction); if (fieldRef != null && this.ShouldValidate(fieldRef.DeclaringType)) { - // can't compare generic type parameters between definition and reference - if (fieldRef.FieldType.IsGenericInstance || fieldRef.FieldType.IsGenericParameter) - return InstructionHandleResult.None; - // get target field FieldDefinition targetField = fieldRef.DeclaringType.Resolve()?.Fields.FirstOrDefault(p => p.Name == fieldRef.Name); if (targetField == null) |